-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decoder: Support template expressions #322
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbanck
force-pushed
the
f-expr-template
branch
3 times, most recently
from
September 29, 2023 08:52
903b28d
to
e940874
Compare
dbanck
force-pushed
the
f-expr-template
branch
3 times, most recently
from
November 15, 2023 12:05
3f4d8fa
to
7bdde56
Compare
dbanck
force-pushed
the
f-expr-template
branch
from
November 15, 2023 15:28
7bdde56
to
469e808
Compare
dbanck
force-pushed
the
f-expr-template
branch
from
November 17, 2023 13:41
469e808
to
ee32bb0
Compare
radeksimko
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aside from the support of HEREDOC in hover and semantic tokens.
I'm happy to finish it given your upcoming OOO though.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
${...}
template expressions in attribute values terraform-ls#522This PR adds support for template expressions inside single and multiline strings.
I filed #345 to track edge cases for empty template expressions inside maps and objects.
Example UX
Directives
if
directives within template expressions are turned into conditional expressions andfor
directives are turned into for expressions. So I would defer support for this until those expressions landfor
-in
-if
expressions terraform-ls#527condition ? true : false
) terraform-ls#528