Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decoder: Support template expressions #322

Merged
merged 10 commits into from
Nov 22, 2023
Merged

decoder: Support template expressions #322

merged 10 commits into from
Nov 22, 2023

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Sep 27, 2023


This PR adds support for template expressions inside single and multiline strings.

I filed #345 to track edge cases for empty template expressions inside maps and objects.

Example UX

2023-11-17 14 45 22

Directives

if directives within template expressions are turned into conditional expressions and for directives are turned into for expressions. So I would defer support for this until those expressions land

@dbanck dbanck added the enhancement New feature or request label Sep 27, 2023
@dbanck dbanck self-assigned this Sep 27, 2023
@dbanck dbanck force-pushed the f-expr-template branch 3 times, most recently from 903b28d to e940874 Compare September 29, 2023 08:52
@dbanck dbanck force-pushed the f-expr-template branch 3 times, most recently from 3f4d8fa to 7bdde56 Compare November 15, 2023 12:05
@dbanck dbanck marked this pull request as ready for review November 17, 2023 13:48
@dbanck dbanck requested a review from a team as a code owner November 17, 2023 13:48
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from the support of HEREDOC in hover and semantic tokens.

I'm happy to finish it given your upcoming OOO though.

decoder/expr_any_hover_test.go Show resolved Hide resolved
decoder/expr_any_completion_test.go Show resolved Hide resolved
decoder/expr_any_completion_test.go Show resolved Hide resolved
decoder/expr_any_hover.go Show resolved Hide resolved
decoder/expr_any_semtok.go Show resolved Hide resolved
@radeksimko radeksimko assigned radeksimko and unassigned dbanck Nov 21, 2023
@radeksimko radeksimko merged commit 99d5763 into main Nov 22, 2023
5 checks passed
@radeksimko radeksimko deleted the f-expr-template branch November 22, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants