Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decoder: Add support for conditional expression #326

Merged
merged 5 commits into from
Nov 30, 2023
Merged

decoder: Add support for conditional expression #326

merged 5 commits into from
Nov 30, 2023

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Oct 4, 2023 •
edited
Loading

@radeksimko radeksimko added the enhancement New feature or request label Oct 4, 2023
@radeksimko radeksimko self-assigned this Oct 4, 2023
@radeksimko radeksimko force-pushed the f-expr-conditional branch 2 times, most recently from 61bf824 to 4930343 Compare November 22, 2023 11:50
@radeksimko radeksimko marked this pull request as ready for review November 22, 2023 18:00
@radeksimko radeksimko requested a review from a team as a code owner November 22, 2023 18:00
This was referenced Nov 27, 2023
Open
Open
Open
jpogran
jpogran approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great addition and also makes the best of a situation with partial or incomplete knowledge of the configuration

decoder/expr_any_completion.go Outdated Show resolved Hide resolved
@radeksimko radeksimko merged commit 2555459 into main Nov 30, 2023
5 checks passed
@radeksimko radeksimko deleted the f-expr-conditional branch November 30, 2023 10:01
@dbanck dbanck mentioned this pull request Dec 12, 2023
Merged
@BrewTestBot BrewTestBot mentioned this pull request Dec 12, 2023
Merged
This was referenced Jan 4, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpogran jpogran jpogran approved these changes

Assignees

@radeksimko radeksimko

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeksimko @jpogran