fix: associate correct constraints with nested origins #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
changed the title
radeksimko
force-pushed
the
b-ref-origins-schema
branch
from
b6a5674
to
e9f6219
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address a bug reported in hashicorp/terraform-ls#592 where origins were being associated with incorrect expression constraints (e.g. map of traversals instead of traversal).
There is still more work to do in terms of fully supporting nested expressions, but this at least covers the most common and obvious cases of list, set, tuple, map and object expressions. Remaining expression types are to be dealt with as part of hashicorp/terraform-ls#496 (tracked there but most of the work will be done in this repo).