unknown upgraded splat values may have no elements #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbardin
force-pushed
the
jbardin/unknown-splat
branch
from
1e7e388
to
4fde447
Compare
When upgrading an unknown splat value, the resulting collection may have 0 elements if the value ends up being `null`. This means the type must be dynamic.
jbardin
force-pushed
the
jbardin/unknown-splat
branch
from
4fde447
to
fadd95c
Compare
apparentlymart
approved these changes
Dec 1, 2021
There was a problem hiding this comment.
The loss of the type information here is unfortunate for sure, but I think it makes pragmatic sense given the various different permutations this operator supports in order to match as closely as possible how Terraform v0.11 and earlier treated .* in resource references; it isn't really a thing that was designed with precise type information in mind, after all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #493, which ensured the value of an upgraded splat expression on an unknown value is unknown, but could result in the wrong type. When the previous PR was updated to allow specific types for expressions with attribute selectors after the splat, the resulting types were still unknown tuples even though the number of elements could not be determined.
When upgrading an unknown splat value, the resulting collection may have 0 elements if the value ends up being
null. Since the final result may be a tuple type with 0 or 1 elements, the unknown value must also be dynamic.