added an option to NewHCPConfig() to not auto login when no local aut… #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h method are found
bcmdarroch
reviewed
Apr 11, 2023
There was a problem hiding this comment.
My main suggestion here is to move the logic entirely into the config package. My review is spread over a few comments, but to sum it up in one place:
- Instead of adding a
noBrowserLoginflag to the config, we can "turn off" the existingoauth2Configfield. - In the config package, an empty
oauth2Configcan be detected and result in aNoValidAuthFound.
auth/user.go
Outdated
| "fmt" | ||
| "log" | ||
| "time" | ||
|
|
||
| "golang.org/x/oauth2" | ||
| ) | ||
|
|
||
| var ( | ||
| // ErrorNoValidAuthFound is returned if no local auth methods were found and the invoker created the config with the option WithoutBrowserLogin | ||
| ErrorNoValidAuthFound = errors.New("there were no valid auth methods found") |
There was a problem hiding this comment.
I would move this up into the config package.
Co-authored-by: Brenna Hewer-Darroch <21015366+bcmdarroch@users.noreply.github.com>
bcmdarroch
reviewed
Apr 12, 2023
bcmdarroch
reviewed
Apr 12, 2023
Co-authored-by: Brenna Hewer-Darroch <21015366+bcmdarroch@users.noreply.github.com>
Co-authored-by: Brenna Hewer-Darroch <21015366+bcmdarroch@users.noreply.github.com>
bcmdarroch
approved these changes
Apr 12, 2023
jesdavpet
approved these changes
Apr 12, 2023
There was a problem hiding this comment.
This is just a rubber stamp approval to +1 @bcmdarroch's review until we can remove @hashicorp/experiences-platform from this repo's CODEOWNERS file.
bcmdarroch
reviewed
Apr 17, 2023
bcmdarroch
reviewed
Apr 17, 2023
bcmdarroch
reviewed
Apr 17, 2023
bcmdarroch
reviewed
Apr 17, 2023
bcmdarroch
reviewed
Apr 17, 2023
Co-authored-by: Brenna Hewer-Darroch <21015366+bcmdarroch@users.noreply.github.com>
Co-authored-by: Brenna Hewer-Darroch <21015366+bcmdarroch@users.noreply.github.com>
Co-authored-by: Brenna Hewer-Darroch <21015366+bcmdarroch@users.noreply.github.com>
Co-authored-by: Brenna Hewer-Darroch <21015366+bcmdarroch@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…h method are found
🛠️ Description
🔗 External Links
👍 Definition of Done