Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regenerate sdk #55

Merged
merged 1 commit into from
Oct 4, 2021
Merged

regenerate sdk #55

merged 1 commit into from
Oct 4, 2021

Conversation

SwampDragons
Copy link
Contributor

@SwampDragons SwampDragons commented Oct 1, 2021

🛠️ Description

Regenerated the cloud-packer-service client.

The main purpose was to add the SourceImageID field to the CreateBuild and UpdateBuild endpoints.

But it is bigger than that because in the intervening time, we switched to prefixing the proto files which changed the names of all the pieces in the SDK.

We changed the prefixing because it made life easier for the folks generating the Packer service api docs.

🔗 External Links

🚢 Release Note

Release note for CHANGELOG:

Updated SDK to add SourceImageID field to the UpdateBuild and CreateBuild endpoints. 

👍 Definition of Done

  • SDK added
  • SDK updated
  • Tests added?
  • Docs updated?

@SwampDragons SwampDragons requested a review from a team October 1, 2021 23:00
Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I did want to call out since it isn't in the changelog section of the PR, but I believe the rename for certain objects (eg. CreateBucketParams -> PackerServiceCreateBucketParams) will result in a breaking change for the sdk release.

@SwampDragons
Copy link
Contributor Author

Yes, I realized that. I think it's ok since the SDK is only used internally; I can go in and fix the terraform provider today.

@roaks3
Copy link
Contributor

roaks3 commented Oct 4, 2021

Oh gotcha! My note was mainly intended to surface that change if another developer ended up cutting the release, but if you're following the change through then you can ignore me 😄 . No concerns from my end!

@SwampDragons
Copy link
Contributor Author

Sounds good. :D

@SwampDragons SwampDragons merged commit 0f36fad into main Oct 4, 2021
@SwampDragons SwampDragons deleted the update_packer branch October 4, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants