Refactor makefile to GNUmakefile and use gometalinter. #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the Levant makefile to use gometalinter to provide better static checks with the possibility of using more in the future. The makefile is now also a GNUmakefile with added help functionality with the cruft removed.
|
Ooohhh I was just looking at opening an issue about this :) |
|
This LGTM - I really like that tools are now installed as part of the Makefile - it means we can run :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the Levant makefile to use gometalinter to
provide better static checks with the possibility of using more in
the future. The makefile is now also a GNUmakefile with added help
functionality with the cruft removed.