Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

levant/deploy: skip health checks for task groups without canaries #83

Merged
merged 1 commit into from
Jan 12, 2018

Conversation

pmcatominey
Copy link
Contributor

if a job contains at least one task group with canary deployments configured
and at least one without, the deployment watcher will fail the deployment
as the check for healthy canaries assumed every task group is configured for
canary deployments.

Tested with levant deploy -canary-auto-promote 30 echo.nomad and the following Job specification (add/remove :latest to the image argument to trigger a deployment):

job "echo" {
  datacenters = ["dc1"]
  type = "service"

  group "echo-canary" {
    count = 2

    update {
      canary       = 2
      max_parallel = 2
    }

    task "echo-canary" {
      driver = "docker"
      config {
        image = "alpine"
        command = "tail"
        args = ["-f", "/dev/null"]
      }
    }
  }

  group "echo-standard" {
    count = 1

    update {
      max_parallel = 1
    }

    task "echo-standard" {
      driver = "docker"
      config {
        image = "alpine"
        command = "tail"
        args = ["-f", "/dev/null"]
      }
    }
  }
}

if a job contains at least one task group with canary deployments configured
and at least one without, the deployment watcher will fail the deployment
as the check for healthy canaries assumed every task group is configured for
canary deployments
@jrasell jrasell added the bug label Jan 11, 2018
@jrasell jrasell merged commit 3bd6683 into hashicorp:master Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants