Add simple conversions #3
Conversation
| right = &ast.CallExpr{ | ||
| Fun: leftType, | ||
| Args: []ast.Expr{right}, | ||
| } |
There was a problem hiding this comment.
This basically fudges the right in this:
left = right
to be
left = leftType(right)
| @@ -54,7 +55,8 @@ type StringSlice []string | |||
| type WorkloadSlice []*Workload | |||
|
|
|||
| type Workload struct { | |||
| ID string | |||
| ID string | |||
| Value int | |||
There was a problem hiding this comment.
While I was here, I also edited the e2e to have an example of int-to-int32 conversion which does require a user provided function since it could be lossy.
| // Only allow this for basic and named. | ||
|
|
||
| switch typeDecode.(type) { | ||
| case *types.Basic, *types.Named: |
There was a problem hiding this comment.
Basic: stuff like string or int
Named: stuff like Label in type Label string
| return false | ||
| } | ||
|
|
||
| if types.ConvertibleTo(typ, typeDecode) && types.ConvertibleTo(typeDecode, typ) { |
There was a problem hiding this comment.
typeDecode is the most underlying type for typ.
- For pointers this is the type of the ultimate memory location
- For named types, it is the type of the real underlying type
This check only lets this special code execute if BOTH the left and right are convertible to their underlying type (which in effect selects type LEFT RIGHT types).
| return false | ||
| } | ||
|
|
||
| if types.Identical(typ, typeDecode) { |
There was a problem hiding this comment.
for example typ=string will have typeDecode=string too and string is convertible to string but we don't want that to trigger the special code.
rboyer
force-pushed
the
add-simple-conversions
branch
from
f52aef2
to
d879198
Compare
There was a problem hiding this comment.
🚀 Thank you @rboyer!! this will remove a bunch of annotations in Consul.
This should handle
type Label stringautomatic conversions to/from each other.