fix basic type conversions from pointer to non-pointer #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rboyer
commented
Oct 27, 2023
| @@ -12,6 +12,8 @@ type ClusterNode struct { | |||
| Label Label | |||
| // Labels []Label | |||
| // WorkPointer []*Workload | |||
| Flag *bool | |||
There was a problem hiding this comment.
Added a pair of bool/uint32 pointer to non pointer conversions to the e2e test.
rboyer
commented
Oct 27, 2023
| @@ -10,6 +10,13 @@ func NodeToCore(s *Node, t *core.ClusterNode) { | |||
| } | |||
| t.ID = s.ID | |||
| t.Label = core.Label(s.Label) | |||
| t.Flag = &s.Flag | |||
There was a problem hiding this comment.
This shows you what the updated basic type conversion code looks like when crossing pointer/nonpointer boundaries.
rboyer
commented
Oct 27, 2023
| leftRealType = leftPtrType.X | ||
| } | ||
|
|
||
| return &ast.IfStmt{ |
There was a problem hiding this comment.
This lifted code from the existing area of code that handled the struct-to-struct conversions, which are different than basic type conversions for Go reasons.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conversions from things like
bool <-> *booloruint32 <-> *uint32would panic if the RHS wasnilas it would just generate:This fixes it so that it does the following in that scenario: