driver: fix image_pull_timeout #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the value for `image_pull_timeout` was being capped by `client_http_timeout` because the image pull request used the same HTTP client as other requests. Increasing `client_http_timeout` in order to be able to set a higher `image_pull_timeout` is not a good option since it requires updating all client's configuration. It also affects all other HTTP requests, which may not be desirable. The change creates a separate client for slow operations that don't have a timeout configured. Operation timeout is controlled using a ContextWithTimeout().
lgfa29
commented
Mar 11, 2023
lgfa29
force-pushed
the
fix-pull-timeout
branch
4 times, most recently
from
dccc7a0
to
94a8524
Compare
lgfa29
force-pushed
the
fix-pull-timeout
branch
from
94a8524
to
352ba70
Compare
|
lgtm. Thank you. |
jdoss
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the value for
image_pull_timeoutwas being capped byclient_http_timeoutbecause the image pull request used the same HTTP client as other requests.Increasing
client_http_timeoutin order to be able to set a higherimage_pull_timeoutis not a good option since it requires updating all client's configuration. It also affects all other HTTP requests, which may not be desirable.The change creates a separate client for slow operations that don't have a timeout configured. Operation timeout is controlled using a ContextWithTimeout().
Closes #207