backport 13205 to 1.2.x #13211

…ix/hardly-selected-jaguar This pull request was automerged via backport-assistant

…ions/admittedly-merry-hermit This pull request was automerged via backport-assistant

…apidly-clever-fowl This pull request was automerged via backport-assistant

…ications/internally-rapid-mole This pull request was automerged via backport-assistant

…ted-client-options/urgently-topical-shiner This pull request was automerged via backport-assistant

…ewrite/poorly-bright-pug This pull request was automerged via backport-assistant

…mplate-detail/firstly-glorious-panther This pull request was automerged via backport-assistant

…1-website/plainly-trusty-foxhound This pull request was automerged via backport-assistant

…st-beagle This pull request was automerged via backport-assistant

…-1.2.6 (#12377)

Co-authored-by: Sarah <sthompson@hashicorp.com> Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>

…p-canary-deploys/routinely-able-pangolin This pull request was automerged via backport-assistant

…-good-frog This pull request was automerged via backport-assistant

…-resources/truly-fond-walleye This pull request was automerged via backport-assistant

…eserved-cores/amazingly-valued-lacewing This pull request was automerged via backport-assistant

…ely-coherent-calf This pull request was automerged via backport-assistant

…s/optionally-just-pup This pull request was automerged via backport-assistant

…p-reservedMemory-unit/curiously-calm-snake This pull request was automerged via backport-assistant

…#11956)

…cate-check/admittedly-precise-anteater This pull request was automerged via backport-assistant

…-counts/currently-beloved-terrier This pull request was automerged via backport-assistant

…-rodent This pull request was automerged via backport-assistant

…/initially-evolved-mongrel This pull request was automerged via backport-assistant

…hing/presently-sacred-snail This pull request was automerged via backport-assistant

…estarts/shortly-open-lamprey This pull request was automerged via backport-assistant

…4/strangely-intimate-sponge This pull request was automerged via backport-assistant

…sly-suited-rat This pull request was automerged via backport-assistant

…kindly-touching-thrush This pull request was automerged via backport-assistant

…/frankly-sweet-guinea This pull request was automerged via backport-assistant

…lly-viable-newt This pull request was automerged via backport-assistant

…t-claim-time/specially-simple-swine This pull request was automerged via backport-assistant

…rally-real-orca This pull request was automerged via backport-assistant

…ially-exciting-kodiak This pull request was automerged via backport-assistant

…ry-on-claim/firmly-lucky-shark This pull request was automerged via backport-assistant

…ugin-on-job-delete/grossly-driving-dog This pull request was automerged via backport-assistant

…-responses/positively-divine-cowbird This pull request was automerged via backport-assistant

The Prestart hook for task runner hooks doesn't get called when we restore a task, because the task is already running. The Postrun hook for CSI plugin supervisors needs the socket path to have been populated so that the client has a valid path.

…fix/nicely-wealthy-monarch This pull request was automerged via backport-assistant

…-prefix/deeply-endless-wolf This pull request was automerged via backport-assistant

…tering/finally-diverse-squid This pull request was automerged via backport-assistant

…for-snapshot/commonly-living-cockatoo This pull request was automerged via backport-assistant

This reverts commit 1ffdda0.

The RPC for listing volume snapshots requires a plugin ID. Update the `volume snapshot list` command to find the specific plugin from the provided prefix.

…ible/firstly-still-ray This pull request was automerged via backport-assistant

Co-authored-by: Thomas Lefebvre <tlefebvre@cloudflare.com>

A volume that has single-use access mode is feasibility checked during scheduling to ensure that only a single reader or writer claim exists. However, because feasibility checking is done one alloc at a time before the plan is written, a job that's misconfigured to have count > 1 that mounts one of these volumes will pass feasibility checking. Enforce the check at validation time instead to prevent us from even trying to evaluation a job that's misconfigured this way.

When a node is garbage collected, we assume that the volume is no longer attached to it and ignore the `ErrUnknownNode` error. But we used `errors.Is` to check for a wrapped error, and RPC flattens the errors during serialization. This results in an error check that works in automated testing but not in real clusters. Use a string contains check instead.

Listing snapshots was incorrectly returning nanoseconds instead of seconds, and formatting of timestamps both list and create snapshot was treating the timestamp as though it were nanoseconds instead of seconds. This resulted in create timestamps always being displayed as zero values. Fix the unit conversion error in the command line and the incorrect extraction in the CSI plugin client code. Beef up the unit tests to make sure this code is actually exercised.

…-header/officially-tidy-lamb This pull request was automerged via backport-assistant

…ted-client-options/officially-enough-lemming This pull request was automerged via backport-assistant

…-order/evenly-cosmic-eft This pull request was automerged via backport-assistant

The volume watcher design was based on deploymentwatcher and drainer, but has an important difference: we don't want to maintain a goroutine for the lifetime of the volume. So we stop the volumewatcher goroutine for a volume when that volume has no more claims to free. But the shutdown races with updates on the parent goroutine, and it's possible to drop updates. Fortunately these updates are picked up on the next core GC job, but we're most likely to hit this race when we're replacing an allocation and that's the time we least want to wait. Wait until the volume has "settled" before stopping this goroutine so that the race between shutdown and the parent goroutine sending on `<-updateCh` is pushed to after the window we most care about quick freeing of claims. * Fixes a resource leak when volumewatchers are no longer needed. The volume is nil and can't ever be started again, so the volume's `watcher` should be removed from the top-level `Watcher`. * De-flakes the GC job test: the test throws an error because the claimed node doesn't exist and is unreachable. This flaked instead of failed because we didn't correctly wait for the first pass through the volumewatcher. Make the GC job wait for the volumewatcher to reach the quiescent timeout window state before running the GC eval under test, so that we're sure the GC job's work isn't being picked up by processing one of the earlier claims. Update the claims used so that we're sure the GC pass won't hit a node unpublish error. * Adds trace logging to unpublish operations

The plugin manager for CSI hands out instances of a plugin for callers that need to mount a volume. The `MounterForPlugin` method accesses the internal instances map without a lock, and can be called concurrently from outside the plugin manager's main run-loop. The original commit for the instances map included a warning that it needed to be accessed only from the main loop but that comment was unfortunately ignored shortly thereafter, so this bug has existed in the code for a couple years without being detected until we ran tests with `-race` in #12098. Lesson learned here: comments make for lousy enforcement of invariants!

…tus/partly-modern-mastiff This pull request was automerged via backport-assistant

…4/actually-elegant-tick This pull request was automerged via backport-assistant

…11927/primarily-robust-sawfly This pull request was automerged via backport-assistant

…lid-marmoset This pull request was automerged via backport-assistant

The Prestart hook for task runner hooks doesn't get called when we restore a task, because the task is already running. The Postrun hook for CSI plugin supervisors needs the socket path to have been populated so that the client has a valid path. Co-authored-by: Tim Gross <tgross@hashicorp.com>

…unds-link/yearly-valued-gecko This pull request was automerged via backport-assistant

…client-restart/amazingly-hot-owl This pull request was automerged via backport-assistant

…estructive/forcibly-noted-mayfly This pull request was automerged via backport-assistant

…cerely-handy-sheep This pull request was automerged via backport-assistant

…12813)

* Merge pull request #11889 from hashicorp/build-update-circle build: upgrade circleci configuration * Merge pull request #12299 from hashicorp/ci-parallel ci: trade test parallelization for unconstrained gomaxprocs * Merge pull request #12321 from hashicorp/ci-less-logging ci: limit gotestsum to circle ci * CI: build binaries for UI branches (#12594) Build binaries for every code change, not just backend code changes. This means that we'll have up-to-date compiled assets for every commit available in CircleCI artifacts. * Merge pull request #12736 from hashicorp/build-update-go-1.17.9 build: update golang to 1.17.9 * cgutil test: reserve only a single CPU for AddAlloc test Reserving the entire machine's worth of CPUs for the `AddAlloc` test triggers a condition where the empty shared CPUs defaults to the parent CPU set on some system configurations. This was done in `main` as part of cgroups v2 work, but we need to backport this to earlier branches in order to use the same machines across branches. Co-authored-by: Seth Hoenig <seth.a.hoenig@gmail.com> Co-authored-by: Tim Gross <tgross@hashicorp.com>

…acity/positively-concise-goblin This pull request was automerged via backport-assistant

…kefile/hardly-eternal-bee This pull request was automerged via backport-assistant

…ral-fowl This pull request was automerged via backport-assistant

…worthy-catfish This pull request was automerged via backport-assistant

…/vaguely-chief-polliwog This pull request was automerged via backport-assistant

…/badly-settled-gibbon This pull request was automerged via backport-assistant

…ing/centrally-main-monkfish This pull request was automerged via backport-assistant

…igorously-living-liger This pull request was automerged via backport-assistant

…node-plan-rejected-log/probably-whole-rooster This pull request was automerged via backport-assistant

…ny/newly-known-hyena This pull request was automerged via backport-assistant

* remove website source code and related circle jobs * remove data files * updates platform-cli * update local instructions * updates package-lock

During the release there are several files that need to be modified: - .release/ci.hcl: the notification channel needs to be updated to a channel with greater team visibility during the release. - version/version.go: the Version and VersionPrerelease variables need to be set so they match the release version. After the release these files need to be reverted. For GA releases the following additional changes also need to happen: - version/version.go: the Version variable needs to be bumped to the next version number. - GNUMakefile: the LAST_RELEASE variable needs to be set to the version that was just released. Since the release process will commit file changes to the branch being used for the release, it should _never_ run on main, so the first step is now to protect against that. It also adds a validation to make the user input version is correct. After looking at the different release options and steps I noticed that automatic CHANGELOG generation is actually the exception, so it would be better to have the default to be false.

add service acct to codeowners for backport merging