Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: fix long loading times on /jobs/:jobId page #14989

Closed
wants to merge 10 commits into from
Closed

Conversation

ChaiWithJai
Copy link
Contributor

@ChaiWithJai ChaiWithJai commented Oct 20, 2022

This PR is part of resolving 14787.

This PR does not solve long loading times on the jobs.index route. I believe we can and should use pagination and we can also patch 10555 while we do that to keep PRs small.

@github-actions
Copy link

github-actions bot commented Oct 20, 2022

Ember Asset Size action

As of df5825d

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +130 B +56 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

Ember Test Audit comparison

main df5825d change
passes 1427 1425 -2
failures 0 2 +2
flaky 0 0 0
duration 11m 27s 561ms 000ms -11m 27s 561ms

@djenriquez
Copy link

Hi @ChaiWithJai, I'm looking at creating a local branch where I merge v1.5.3 into this branch (since thats the release we're on internally). Do you foresee any incompatibilities with that?

@ChaiWithJai
Copy link
Contributor Author

Hi @ChaiWithJai, I'm looking at creating a local branch where I merge v1.5.3 into this branch (since thats the release we're on internally). Do you foresee any incompatibilities with that?

Merging this branch might not be suitable for your needs as it does not solve the problem for the jobs.index page (The main Jobs list page). And I think that @philrenaud solves this same from this PR in his current block of work which we'll be out soon.

@djenriquez
Copy link

Hi @ChaiWithJai, I'm looking at creating a local branch where I merge v1.5.3 into this branch (since thats the release we're on internally). Do you foresee any incompatibilities with that?

Merging this branch might not be suitable for your needs as it does not solve the problem for the jobs.index page (The main Jobs list page). And I think that @philrenaud solves this same from this PR in his current block of work which we'll be out soon.

Ok, just to confirm, theres a PR that exists which we think will handle the problems in GH-14787?

@philrenaud
Copy link
Contributor

Hi @djenriquez — the PR that Jai is referring to is #17214 but that doesn't solve for the slow index page issue of #14787 — it's meant to make child jobs specifically less painful to use within the UI, but won't impact the /jobs index page.

The correct solution for that is for us to paginate jobs index requests; we're working on setting that up but have some plans to depend on the unpaginated "all jobs" request for some upcoming features. As of now, the plan is to set up a new "all jobs' summaries" request, and to use a paginated jobs request otherwise.

This seems like something worth prioritizing, so we'll kick off work related to it soon. We appreciate your patience on this!

@djenriquez
Copy link

Completely understood @philrenaud , thank you for the reply.

@tgross tgross added the stage/needs-rebase This PR needs to be rebased on main before it can be backported to pick up new BPA workflows label May 17, 2024
@philrenaud
Copy link
Contributor

Made less necessary with the work in #20452

@philrenaud philrenaud closed this Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stage/needs-rebase This PR needs to be rebased on main before it can be backported to pick up new BPA workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants