-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: create node pool model #17301
Merged
Merged
ui: create node pool model #17301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ember Test Audit comparison
|
philrenaud
approved these changes
May 25, 2023
lgfa29
approved these changes
May 25, 2023
c40f31d
to
df7598c
Compare
lgfa29
suggested changes
Jun 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great!
I think removing the all
node pool from the client list dropdown is the main blocker, otherwise you would always get an empty list result.
It would nice to have the topoviz updates as well, since it's such a useful page 😄
ade5ec9
to
1134e58
Compare
85d306b
to
d18e6f4
Compare
lgfa29
reviewed
Jun 21, 2023
lgfa29
reviewed
Jun 21, 2023
* refact: update models for relationship * chore: setup mirage models + factory hooks (#17321) * chore: setup mirage models + factory hooks * Acceptance test hardening to avoid faker/mirage randomness --------- Co-authored-by: Phil Renaud <phil@riotindustries.com> * chore: update comment Co-authored-by: Luiz Aoqui <luiz@hashicorp.com> --------- Co-authored-by: Phil Renaud <phil@riotindustries.com> Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>
* chore: create pool adapter * chore: mirage route handler * ui: add pool count to topo * ui: node pools data on `jobs.index` page (#17368) * ui: node filter on jobs.index * ui: add node pool to table viz * ui: node pools - client page visualization (#17372) * refact: update mirage models * ui: add pool filter to client list * ui: add pool to table viz * ui: add pool to statsboxes (#17373)
Require node pools to be created before nodes and jobs to force correct environment setup and improve test repeatability.
The built-in node pool `all` should not be a client filter because nodes are not allowed to register there.
Add node pool filter and tooltips to nodes and datacenters labels, and don't count node pool `all` in topoviz metrics.
The namespace, node pool, type, and priority values were already displayed at the page header, so they made the children job table quite crowded.
157c31e
to
42287d5
Compare
lgfa29
approved these changes
Jun 22, 2023
This was referenced Jun 22, 2023
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #17292
This PR adds a new NodePool model and serializer. The NodePool model is used to represent a pool of nodes that can be used to run applications. The serializer is used to serialize the JSON response of a NodePool object to a JSON:API object.
The NodePool model has the following properties:
The serializer serializes NodePool objects to JSON:API by converting the properties of the objects to strings. The following is an example of the serialized object that is generated for a NodePool object: