Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: make sure consul_hook does not perform double requests for tasks #19137

Merged
merged 2 commits into from
Nov 21, 2023
Merged

client: make sure consul_hook does not perform double requests for tasks #19137

merged 2 commits into from
Nov 21, 2023

Conversation

pkazmierczak
Copy link
Contributor

Fixes #19127

@pkazmierczak pkazmierczak self-assigned this Nov 20, 2023
lgfa29
lgfa29 approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

client/allocrunner/consul_hook.go Outdated Show resolved Hide resolved
jrasell
jrasell approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pkazmierczak pkazmierczak merged commit e9019d5 into main Nov 21, 2023
23 checks passed
@pkazmierczak pkazmierczak deleted the b-consul-hook-tokens-template branch November 21, 2023 09:24
nvanthao pushed a commit to nvanthao/nomad that referenced this pull request Mar 1, 2024
@pkazmierczak @nvanthao
client: make sure consul_hook does not perform double requests for ta…
b0939e8 
…sks (hashicorp#19137)
nvanthao pushed a commit to nvanthao/nomad that referenced this pull request Mar 1, 2024
@pkazmierczak @nvanthao
client: make sure consul_hook does not perform double requests for ta…
5bf13e1 
…sks (hashicorp#19137)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrasell jrasell jrasell approved these changes

@lgfa29 lgfa29 lgfa29 approved these changes

Assignees

@pkazmierczak pkazmierczak

Labels
theme/consul theme/workload-identity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workload Identity - Consul integration creates duplicate per-task tokens
3 participants
@pkazmierczak @lgfa29 @jrasell