Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: add a unit test for "container already exists" error when creating containers #22238

Merged
merged 3 commits into from
May 30, 2024
Merged

docker: add a unit test for "container already exists" error when creating containers #22238

merged 3 commits into from
May 30, 2024

Conversation

pkazmierczak
Copy link
Contributor

relates to #22218

@pkazmierczak pkazmierczak self-assigned this May 24, 2024
@pkazmierczak pkazmierczak marked this pull request as draft May 24, 2024 15:52
@pkazmierczak pkazmierczak marked this pull request as ready for review May 30, 2024 08:40
@pkazmierczak pkazmierczak requested a review from jrasell May 30, 2024 08:40
jrasell
jrasell approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor comment about the test comment.

Lets also backport it, so future engineers touching this code can backport with ease.

drivers/docker/driver_test.go Outdated Show resolved Hide resolved
@pkazmierczak pkazmierczak added backport/ent/1.6.x+ent Changes are backported to 1.6.x+ent backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/1.8.x backport to 1.8.x release line labels May 30, 2024
@pkazmierczak pkazmierczak merged commit bf11e39 into main May 30, 2024
31 checks passed
@pkazmierczak pkazmierczak deleted the b-docker-container-already-exists branch May 30, 2024 09:24
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request May 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnyplaydrums johnnyplaydrums johnnyplaydrums left review comments

@jrasell jrasell jrasell approved these changes

Assignees

@pkazmierczak pkazmierczak

Labels
backport/ent/1.6.x+ent Changes are backported to 1.6.x+ent backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/1.8.x backport to 1.8.x release line theme/driver/docker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pkazmierczak @jrasell @johnnyplaydrums