Add support for docker storage options #4908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickethier
requested changes
Nov 20, 2018
| @@ -1122,6 +1122,25 @@ func TestDockerDriver_SecurityOpt(t *testing.T) { | |||
| require.Exactly(t, cfg.SecurityOpt, container.HostConfig.SecurityOpt) | |||
| } | |||
|
|
|||
| func TestDockerDriver_CreateContainerConfig(t *testing.T) { | |||
There was a problem hiding this comment.
Since the point of this test is to specifically test the storage_opt field I would vote for appending _StorageOpt to the name.
There was a problem hiding this comment.
I intend for this test to be generic for all options we add in future (e.g. tmpfs options) - I simply started with image and storage opt, but I can add more as well.
notnoop
force-pushed
the
f-docker-opts-storageopt
branch
from
5ccf835
to
9b48b09
Compare
nickethier
approved these changes
Nov 21, 2018
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
--storage-optsflags.Making this PR targeting #4844 - to ease review, we can merge it into the PR or review it and merge it after the docker plugin PR is merged.