Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builder: add fedora-coreos-cloud project #192

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

lbajolet-hashicorp
Copy link
Contributor

When a user specifies a image_family_name to get the latest version of an image to build their custom image upon, the plugin attempts to get the family specified from a static list of projects.

In this case, a user attempted to get the fedora-coreos-stable' family, present in the fedora-coreos-cloud` project, which was not in the default list of the GCE driver.

This commit changes this.

Closes: #191

When a user specifies a `image_family_name` to get the latest version of
an image to build their custom image upon, the plugin attempts to get
the family specified from a static list of projects.

In this case, a user attempted to get the `fedora-coreos-stable' family,
present in the `fedora-coreos-cloud` project, which was not in the
default list of the GCE driver.

This commit changes this.
@lbajolet-hashicorp lbajolet-hashicorp requested a review from a team as a code owner October 23, 2023 20:22
@lbajolet-hashicorp
Copy link
Contributor Author

Note: as mentioned in the related issue, we should definitely add a way for users to specify the project they want to get their image from if someone else in the future attempts to get their image from another yet unsupported project.

@nywilken
Copy link
Contributor

Note: as mentioned in the related issue, we should definitely add a way for users to specify the project they want to get their image from if someone else in the future attempts to get their image from another yet unsupported project.

Note: as mentioned in the related issue, we should definitely add a way for users to specify the project they want to get their image from if someone else in the future attempts to get their image from another yet unsupported project.

Let’s create an issue for this if one doesn’t exist.

Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - feel free to cut a release for this.

@lbajolet-hashicorp
Copy link
Contributor Author

Will do tomorrow for sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fedora CoreOS cannot be used as a source image
2 participants