-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update version in example #90
Conversation
Updated version and fixed source link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updated source address for the required_plugins block is not meant to be a full GitHub URL. Please see my comments for the exact details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer an x.y.x
example semver format so that it doesn't need to be updated with each release.
Reset the path to pre-commit.
Reset to `source = "github.com/hashicorp/vmware"` Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>
Set `version = ">= x.y.z"` as an example so that this does not need to be continuatlly updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Updated version to the latest 1.0.7, and fixed the source link which was pointing to a non-existence repository on GitHub.