Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update version in example #90

Merged
merged 3 commits into from
Oct 12, 2022
Merged

docs: update version in example #90

merged 3 commits into from
Oct 12, 2022

Conversation

graememeyer
Copy link
Contributor

Updated version to the latest 1.0.7, and fixed the source link which was pointing to a non-existence repository on GitHub.

Updated version and fixed source link
@graememeyer graememeyer requested a review from a team as a code owner September 8, 2022 12:31
@hashicorp-cla
Copy link

hashicorp-cla commented Sep 8, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated source address for the required_plugins block is not meant to be a full GitHub URL. Please see my comments for the exact details.

docs/builders/index.mdx Outdated Show resolved Hide resolved
@tenthirtyam tenthirtyam changed the title Updated version and fixed source link docs: update version in examole Sep 28, 2022
@tenthirtyam tenthirtyam changed the title docs: update version in examole docs: update version in example Sep 28, 2022
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer an x.y.x example semver format so that it doesn't need to be updated with each release.

Reset the path to pre-commit.

docs/builders/index.mdx Outdated Show resolved Hide resolved
Reset to `source = "github.com/hashicorp/vmware"`

Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>
docs/builders/index.mdx Outdated Show resolved Hide resolved
Set `version = ">= x.y.z"` as an example so that this does not need to be continuatlly updated.
@tenthirtyam tenthirtyam dismissed nywilken’s stale review October 7, 2022 03:50

Committed the needed changes.

Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nywilken nywilken merged commit e171ce7 into hashicorp:main Oct 12, 2022
@tenthirtyam tenthirtyam added this to the v1.0.8 milestone Dec 4, 2022
@hashicorp hashicorp locked and limited conversation to collaborators Jun 29, 2024
@tenthirtyam tenthirtyam added documentation Improvements or additions to documentation and removed docs labels Jul 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants