New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement `iso_interface` setting #1200

Merged
merged 2 commits into from Sep 2, 2014

Conversation

Projects
None yet
3 participants
@zigg
Contributor

zigg commented May 24, 2014

Adds a new configuration option, iso_interface, that can be set to sata to mount the ISO on the SATA controller. Required for OS X, which can then be built by the template at https://github.com/zigg/osx-vm-templates/commit/f7e624dd97274abcf005ea465e2e7fb5e95649a5.

Fixes #822.

implement `iso_interface` setting
Adds a new configuration option, `iso_interface`, that can be set to
`sata` to mount the ISO on the SATA controller.  Required for OS X.

@zigg zigg referenced this pull request May 24, 2014

Closed

VirtualBox Support #7

@rasa

This comment has been minimized.

Show comment
Hide comment
@rasa

rasa May 24, 2014

Collaborator

Thanks for the unit tests. Let's get this in the next release.

Collaborator

rasa commented May 24, 2014

Thanks for the unit tests. Let's get this in the next release.

@rasa rasa added this to the 0.6.1 milestone May 24, 2014

@zigg

This comment has been minimized.

Show comment
Hide comment
@zigg

zigg Jun 12, 2014

Contributor

@rasa or anyone else:

Just wanted to bring your attention to the fact I went ahead and added documentation in https://github.com/zigg/packer/commit/32f6553d04d774b901fbb069ad13b50e6dc8294f. Thanks!

Contributor

zigg commented Jun 12, 2014

@rasa or anyone else:

Just wanted to bring your attention to the fact I went ahead and added documentation in https://github.com/zigg/packer/commit/32f6553d04d774b901fbb069ad13b50e6dc8294f. Thanks!

@rasa rasa modified the milestones: 0.6.2, 0.6.1 Jul 20, 2014

@mitchellh

This comment has been minimized.

Show comment
Hide comment
@mitchellh

mitchellh Sep 2, 2014

Member

Thanks, this LGTM.

Member

mitchellh commented Sep 2, 2014

Thanks, this LGTM.

mitchellh added a commit that referenced this pull request Sep 2, 2014

Merge pull request #1200 from zigg/feature/virtualbox-iso-sata
builder/virtualbox: implement `iso_interface` setting

@mitchellh mitchellh merged commit c185fa4 into hashicorp:master Sep 2, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment