Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builder/hyperv/iso: missing InterpolateContext #5184

Merged
merged 3 commits into from
Aug 8, 2017

Conversation

tsmolka
Copy link
Contributor

@tsmolka tsmolka commented Jul 27, 2017

I believe there is a trivial error in hyper-iso builder where context for interpolation is not set properly. This causes boot_command not to interpolate user variables and fail with similar errors:

Build 'hyperv-iso' errored: Error preparing boot command: template: root:1:3: executing "root" at <user `boot_command_p...>: error calling user: test

I have seen few references to what appears to be similar issue:

The proposed change fixed interpolation issue for me.

@mwhooker
Copy link
Contributor

mwhooker commented Aug 1, 2017

if you can fix the test (just need to gofmt the code) I think we can merge this in

@tsmolka
Copy link
Contributor Author

tsmolka commented Aug 8, 2017

thanks, formatting fixed

@mwhooker mwhooker merged commit 08ff748 into hashicorp:master Aug 8, 2017
@tsmolka tsmolka deleted the patch-1 branch August 28, 2017 12:04
egraff added a commit to egraff/packer that referenced this pull request Nov 5, 2017
@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants