Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update provisioner.go #6792

Merged
merged 1 commit into from
Oct 3, 2018
Merged

Update provisioner.go #6792

merged 1 commit into from
Oct 3, 2018

Conversation

Poddo
Copy link
Contributor

@Poddo Poddo commented Oct 3, 2018

Remove extra break statement that made it's way into the "reboot pending" loop when some logic was rearranged in 9fa47f5#diff-8bb0a16231863cd1487dd9a3d3792565

New build successfully waits for restart to complete.

azure-arm: Waiting for machine to restart...
azure-arm: A system shutdown is in progress.(1115)
azure-arm: A system shutdown is in progress.(1115)
azure-arm: A system shutdown is in progress.(1115)
azure-arm: A system shutdown is in progress.(1115)
azure-arm: A system shutdown is in progress.(1115)
azure-arm: restarted.

Closes #6733

Remove extra break statement that made it's way into the "reboot pending" loop when some logic was rearranged in hashicorp@9fa47f5#diff-8bb0a16231863cd1487dd9a3d3792565
Copy link
Contributor

@azr azr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. 🎉

@azr azr merged commit 83590b5 into hashicorp:master Oct 3, 2018
@nwesoccer
Copy link

Works for me as well! Thanks @azr!

@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows 2016 windows-restart provisioner not waiting for reboot after patching
4 participants