Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HCL2 singular blocks: use key/value or name/value depending on how the service names things #9078

Merged
merged 3 commits into from
Apr 23, 2020
Merged

HCL2 singular blocks: use key/value or name/value depending on how the service names things #9078

merged 3 commits into from
Apr 23, 2020

Conversation

azr
Copy link
Contributor

@azr azr commented Apr 16, 2020

close #8967

@azr azr requested review from chhaj5236, paulmey, zhuzhih2017 and a team as code owners April 16, 2020 15:23
@codecov
Copy link

codecov bot commented Apr 16, 2020 •
edited
Loading

Codecov Report

Merging #9078 into master will decrease coverage by 0.00%.
The diff coverage is 8.00%.

Impacted Files Coverage Δ
builder/alicloud/ecs/image_config.go 59.25% <ø> (ø)
builder/amazon/chroot/builder.go 33.45% <ø> (ø)
builder/amazon/common/ami_config.go 86.20% <ø> (ø)
builder/amazon/ebsvolume/block_device.go 17.64% <ø> (ø)
builder/amazon/ebsvolume/builder.go 15.54% <ø> (ø)
builder/azure/arm/config.go 83.08% <ø> (ø)
builder/hyperone/config.go 0.00% <ø> (ø)
builder/tencentcloud/cvm/run_config.go 79.01% <ø> (ø)
builder/triton/source_machine_config.go 47.82% <ø> (ø)
builder/triton/target_image_config.go 100.00% <ø> (ø)
... and 4 more

@azr azr added this to the 1.5.6 milestone Apr 21, 2020
@azr azr mentioned this pull request Apr 21, 2020
Closed
SwampDragons
SwampDragons approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@SwampDragons SwampDragons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one typo, otherwise lgtm.

website/pages/docs/from-1.5/expressions.mdx Outdated Show resolved Hide resolved
@azr @SwampDragons
Update website/pages/docs/from-1.5/expressions.mdx
304f615 
Co-Authored-By: Megan Marsh <megan@hashicorp.com>
@azr azr merged commit da4a522 into master Apr 23, 2020
@azr azr deleted the azr/upstream_key_value_names branch April 23, 2020 08:46
@mschuchard mschuchard mentioned this pull request May 21, 2020
Closed
@ghost
Copy link

ghost commented May 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SwampDragons SwampDragons SwampDragons approved these changes

@chhaj5236 chhaj5236 Awaiting requested review from chhaj5236

@paulmey paulmey Awaiting requested review from paulmey

@zhuzhih2017 zhuzhih2017 Awaiting requested review from zhuzhih2017

Assignees
No one assigned
Labels
breaking-change docs hcl2
Projects
None yet
Milestone
1.5.6
Development

Successfully merging this pull request may close these issues.

dynamic-blocks: An argument named "key" is not expected here
2 participants
@azr @SwampDragons