Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to use go.etcd.io/bbolt #19

Closed

Conversation

annismckenzie
Copy link

Closes #11.

@hashicorp-cla
Copy link

hashicorp-cla commented Oct 21, 2019

CLA assistant check
All committers have signed the CLA.

@catsby
Copy link
Contributor

catsby commented Oct 21, 2019

I believe there is some duplication here with #12

@vrazdalovschi
Copy link

vrazdalovschi commented Aug 22, 2020

@catsby Can you approve PR? This update also fixes the problem with go test -race ./... with go 1.14.
etcd-io/bbolt#187

go.mod Outdated Show resolved Hide resolved
Copy link

@mjmac mjmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this with my own code, verified that it fixes go test -race failures on go 1.15.

@annismckenzie
Copy link
Author

I can't merge but I'd appreciate if someone did because it's been approved. 🙈

@mjmac
Copy link

mjmac commented Oct 5, 2020

@vrazdalovschi/@catsby: Sorry to nudge, but... ::nudge:: Can we get this landed, please? The old boltdb repo is archived and unmaintained, and fails when built with the race detector enabled.

@schristoff
Copy link
Contributor

Howdy everyone,
Thanks so much for all the interest in this PR.
It's currently being looked into and tested to see if there are any raft log binary compatibility issues when it is added into relevant products, or if it can be seamlessly integrated into our products without significant code changes.
I appreciate your patience while we dig into this.

@mjmac
Copy link

mjmac commented Mar 8, 2021

Howdy everyone,
Thanks so much for all the interest in this PR.
It's currently being looked into and tested to see if there are any raft log binary compatibility issues when it is added into relevant products, or if it can be seamlessly integrated into our products without significant code changes.
I appreciate your patience while we dig into this.

Hi, any updates?

@schristoff
Copy link
Contributor

Hello again,
I am super sorry for the delay. I am currently working on this in #22.
I appreciate the patience as we tested that this would not be a breaking change for any of our internal users of this. At this time we have not found any breakage, and are using this method to allow for imports of the old and new version simultaneously. I will definitely give credit where credit is due (to #12 , and here in #19).
At this time I'm going to close this PR.

@schristoff schristoff closed this Mar 30, 2021
@schristoff schristoff mentioned this pull request Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update the boltdb import to bbolt
6 participants