Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean some linter errors and remove use of ioutils as it's deprecated #529

Merged
merged 2 commits into from
Mar 22, 2023
Merged

clean some linter errors and remove use of ioutils as it's deprecated #529

merged 2 commits into from
Mar 22, 2023

Conversation

dhiaayachi
Copy link
Contributor

This fix some of golangci-lint given errors and remove the use of the deprecated ioutils since go 1.16

@dhiaayachi dhiaayachi requested a review from a team as a code owner March 21, 2023 13:01
@dhiaayachi dhiaayachi requested review from JadhavPoonam and removed request for a team March 21, 2023 13:01
JadhavPoonam
JadhavPoonam approved these changes Mar 21, 2023
View reviewed changes
Copy link

@JadhavPoonam JadhavPoonam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhiaayachi dhiaayachi merged commit 4e47475 into main Mar 22, 2023
@dhiaayachi dhiaayachi deleted the cleanup-linter-errors branch March 22, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JadhavPoonam JadhavPoonam JadhavPoonam approved these changes

@loshz loshz loshz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhiaayachi @loshz @JadhavPoonam