-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Bump framer-motion
#1002
Conversation
π¦ Changeset detectedLatest commit: 8c92157 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
π¦ Canary Packages PublishedLatest commit: 8c92157 Published 2 packages@hashicorp/react-motion-config@0.4.0-canary-20230927184943
@hashicorp/react-notification@0.6.0-canary-20230927184943
|
@dstaley - mind taking a look at this PR? I think I have all my bases covered but would love for someone to poke holes in this. We paired on this awhile back but I put it down when higher priority work came up. Beyond a general review, two specific things come to mind that I'd love feedback on:
|
One other instance I know we're using |
Reference
web
PRDescription
We are currently using an old version of
framer-motion
. The most recent version offers new, useful functionality. This PR does several things:framer-motion
to the latest forreact-components
framer-motion
to the latest forreact-notification
andreact-motion-config
MotionConfig
featuresMotionConfig features
MotionConfig
is used across our properties and it allows us to reduce our bundle size by lazy loading specificframer-motion
features. Previously, we hand-picked features to load but it looks like this is no longer supported. This PR updatesMotionConfig
to usedomMax
instead of hand-picked features. When this change was tested before, I believe the difference in bundle size was pretty small (which was the reason why we hand-picked features initially).Validation Steps
In order to test this change, I've created a PR in
web
that bumpsframer-motion
and uses the canary releases for these components.Home
www
that uses the canary releases for this PRCOM
Terraform Overview