Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up all package-lock.jsons #330

Merged
merged 4 commits into from
Sep 13, 2021
Merged

Conversation

zchsh
Copy link
Contributor

@zchsh zchsh commented Sep 10, 2021

🎟️ Asana Task
πŸ” Preview Link


This PR cleans up package-specific package-lock.json files, which are no longer needed (I think?) as we've moved to npm workspaces.

PR Checklist πŸš€

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

  • Add Asana and Preview links above.
  • Conduct thorough self-review.
  • Add or update tests as appropriate.
  • Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Sauce Labs account for this, if you don't have access, just ask!).
  • Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
  • Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

@vercel
Copy link

vercel bot commented Sep 10, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

πŸ” Inspect: https://vercel.com/hashicorp/react-components/2zxcy2Mkpspt1SY4ctM39akp9Rf8
βœ… Preview: https://react-components-git-zscleanup-package-locks-hashicorp.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Sep 10, 2021

πŸ¦‹ Changeset detected

Latest commit: 2b55a14

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@hashicorp/react-accordion Patch
@hashicorp/react-callouts Patch
@hashicorp/react-case-study-slider Patch
@hashicorp/react-checkbox-input Patch
@hashicorp/react-consent-manager Patch
@hashicorp/react-enterprise-alert Patch
@hashicorp/react-featured-slider Patch
@hashicorp/react-learn-callout Patch
@hashicorp/react-logo-grid Patch
@hashicorp/react-min-100-layout Patch
@hashicorp/react-search Patch
@hashicorp/react-subnav Patch
@hashicorp/react-tabbed-accordion Patch
@hashicorp/react-tabs Patch
@hashicorp/react-text-input Patch
@hashicorp/react-toggle Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -15,6 +15,16 @@ The `packages` directory contains all the individual components. Let's talk abou
- `docs.mdx`: documentation for the component, see [swingset docs](https://github.com/hashicorp/swingset#usage) for more details on the format
- `props.js`: information about the component's props, see [swingset docs](https://github.com/hashicorp/swingset#props) for more details on the format

## Adding package dependencies
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this note to clarify the preferred mode for installing package dependencies. Also added a note on wanting to not have package-lock.json files in package subfolders.

'@hashicorp/react-toggle': patch
---

Removes package-lock.json
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure these releases are really necessary, but changesets thinks they are, and I trust that πŸ‘

@zchsh zchsh requested a review from jescalan September 10, 2021 16:19
@zchsh
Copy link
Contributor Author

zchsh commented Sep 10, 2021

@jescalan As discussed in Platform Triage, this PR:

  • drops package-level package-lock.json files
  • adds a README note on installing package dependencies

@zchsh zchsh merged commit 44a0e60 into main Sep 13, 2021
@zchsh zchsh deleted the zs.cleanup-package-locks branch September 13, 2021 19:51
@github-actions github-actions bot mentioned this pull request Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants