-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: clean up all package-lock.jsons #330
Conversation
This pull request is being automatically deployed with Vercel (learn more). π Inspect: https://vercel.com/hashicorp/react-components/2zxcy2Mkpspt1SY4ctM39akp9Rf8 |
π¦ Changeset detectedLatest commit: 2b55a14 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -15,6 +15,16 @@ The `packages` directory contains all the individual components. Let's talk abou | |||
- `docs.mdx`: documentation for the component, see [swingset docs](https://github.com/hashicorp/swingset#usage) for more details on the format | |||
- `props.js`: information about the component's props, see [swingset docs](https://github.com/hashicorp/swingset#props) for more details on the format | |||
|
|||
## Adding package dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this note to clarify the preferred mode for installing package dependencies. Also added a note on wanting to not have package-lock.json
files in package subfolders.
'@hashicorp/react-toggle': patch | ||
--- | ||
|
||
Removes package-lock.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure these releases are really necessary, but changesets
thinks they are, and I trust that π
@jescalan As discussed in Platform Triage, this PR:
|
ποΈ Asana Task
π Preview Link
This PR cleans up package-specific
package-lock.json
files, which are no longer needed (I think?) as we've moved tonpm workspaces
.PR Checklist π
Items in this checklist may not may not apply to your PR, but please consider each item carefully.