Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: Add support for 'hashicorp' titleLink logo #472

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

EnMod
Copy link
Contributor

@EnMod EnMod commented Dec 21, 2021

🔍 Preview Link


Description

This PR adds support for using our company logo in the <TitleLink /> component of <Subnav />. Now a consumer can pass titleLink={{ text: 'hashicorp' }} to the <Subnav /> and the HashiCorp logo will appear, much like how our other product options operate.

PR Checklist 🚀

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

  • Add Asana and Preview links above.
  • Conduct thorough self-review.
  • Add or update tests as appropriate.
  • Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Sauce Labs account for this, if you don't have access, just ask!).
  • Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
  • Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

@vercel
Copy link

vercel bot commented Dec 21, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hashicorp/react-components/AFQUnqxY8VUAr1gBVQ72U7AVqRJj
✅ Preview: https://react-components-git-nqsubnav-enable-hashicorp-logo-hashicorp.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Dec 21, 2021

🦋 Changeset detected

Latest commit: 2978c8b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hashicorp/react-subnav Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@EnMod EnMod marked this pull request as ready for review December 21, 2021 23:34
@EnMod EnMod merged commit 1ec3708 into main Dec 22, 2021
@EnMod EnMod deleted the nq.subnav/enable-hashicorp-logo branch December 22, 2021 16:27
@github-actions github-actions bot mentioned this pull request Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants