Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Intro): description check for HTML #727

Merged
merged 2 commits into from
Sep 28, 2022
Merged

Conversation

alexcarpenter
Copy link
Contributor

@alexcarpenter alexcarpenter commented Sep 16, 2022

Preview

Description

Refactors description HTML check from including a <p> string to HTML regex since <p> is not always returned but other markup can be returned from Dato.

CleanShot 2022-09-27 at 16 00 57@2x

PR Checklist 🚀

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

  • Add Asana and Preview links above.
  • Conduct thorough self-review.
  • Add or update tests as appropriate.
  • Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Sauce Labs account for this, if you don't have access, just ask!).
  • Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
  • Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

@vercel
Copy link

vercel bot commented Sep 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-components ✅ Ready (Inspect) Visit Preview Sep 16, 2022 at 1:57PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 16, 2022

🦋 Changeset detected

Latest commit: d8578bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hashicorp/react-intro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

📦 Canary Packages Published

Latest commit: d8578bb

Published 1 packages

@hashicorp/react-intro@0.4.2-canary-20220916135741

npm install @hashicorp/react-intro@canary

@alexcarpenter alexcarpenter requested a review from a team September 20, 2022 14:01
@alexcarpenter alexcarpenter marked this pull request as ready for review September 20, 2022 14:01
Copy link
Contributor

@EnMod EnMod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I like this! Covers all bases with respect to HTML detection 👍

@alexcarpenter alexcarpenter merged commit eff7596 into main Sep 28, 2022
@alexcarpenter alexcarpenter deleted the ac.intro-description-html branch September 28, 2022 19:15
@hashibot-web hashibot-web mentioned this pull request Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:canary Triggers a canary release for commits to this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants