Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ConsentManager): stack actions on mobile #729

Merged
merged 2 commits into from
Oct 5, 2022

Conversation

alexcarpenter
Copy link
Contributor

@alexcarpenter alexcarpenter commented Sep 28, 2022

Issue flagged: https://docs.google.com/document/d/1oGOdwsy1wktMTA4UCb2rwtVjKDxLlQiA7Irkl98cMZE/edit?disco=AAAAhEgPW4o
🔍 Preview Link


Description

image

PR Checklist 🚀

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

  • Add Asana and Preview links above.
  • Conduct thorough self-review.
  • Add or update tests as appropriate.
  • Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Sauce Labs account for this, if you don't have access, just ask!).
  • Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
  • Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

@vercel
Copy link

vercel bot commented Sep 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-components ✅ Ready (Inspect) Visit Preview Sep 28, 2022 at 5:50PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2022

🦋 Changeset detected

Latest commit: 541709f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hashicorp/react-consent-manager Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alexcarpenter alexcarpenter added the release:canary Triggers a canary release for commits to this pull request label Sep 28, 2022
@github-actions
Copy link
Contributor

📦 Canary Packages Published

Latest commit: 541709f

Published 1 packages

@hashicorp/react-consent-manager@8.1.0-canary-20220928175236

npm install @hashicorp/react-consent-manager@canary

@alexcarpenter alexcarpenter requested a review from a team September 30, 2022 16:13
@alexcarpenter alexcarpenter marked this pull request as ready for review October 3, 2022 15:39
Copy link
Contributor

@nandereck nandereck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexcarpenter alexcarpenter merged commit 13a6f0d into main Oct 5, 2022
@alexcarpenter alexcarpenter deleted the ac.consent-manager-actions branch October 5, 2022 18:43
@hashibot-web hashibot-web mentioned this pull request Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:canary Triggers a canary release for commits to this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants