feat: <RelatedContent /> component
#731
Conversation
🦋 Changeset detectedLatest commit: 63aac7a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nandereck
changed the title
RelatedContent WPL component<RelatedContent /> component
nandereck
changed the title
<RelatedContent /> component
nandereck
changed the title
<RelatedContent /> component
| --columns: 2; | ||
| } | ||
| @media (--large) { | ||
| --columns: 4; |
There was a problem hiding this comment.
Just to confirm expectations, if there are three cards provided, we still render 4 columns across vs 3 columns across?
There was a problem hiding this comment.
Bottom example rendering 3 columns vs 4.
There was a problem hiding this comment.
Just to confirm expectations, if there are three cards provided, we still render 4 columns across vs 3 columns across?
My understanding is that this component can only render 4 cards.
There was a problem hiding this comment.
Interesting, so to make use of RelatedContent, folks will need to provide at least 4 cards. Or it's ok that less than 4 cards are provided, they just will still render within 4 columns? I could see the need to use less based on some of content the content I have seen on .io sites.
If we've decided that is a requirement, what do you think about adding a length check to the cards array that at least 4 cards are provided then or update types to reflect 4 cards?
cards: [RelatedContentCardProps, RelatedContentCardProps, RelatedContentCardProps, RelatedContentCardProps]There was a problem hiding this comment.
FWIW also seeing less than and more than 4 related resources being used in the work @EnMod is doing with SI Partners.
There was a problem hiding this comment.
Interesting, so to make use of RelatedContent, folks will need to provide at least 4 cards. Or it's ok that less than 4 cards are provided, they just will still render within 4 columns? I could see the need to use less based on some of content the content I have seen on .io sites.
FWIW - I think this component should allow for multiple cards and not be limited to only 4. I wonder if it makes sense to enable that and make adjustments later. Especially if we're already seeing deviations from the initial requirements.
There was a problem hiding this comment.
@nandereck I agree: I think it makes sense to go with how it's currently implemented (render with 4 columns regardless of count, do not limit to 4 cards minimum). Especially with deviations already existing.
As an aside, this implementation is aligned with how local related resources components are currently implemented, an example being on our thank you page 👍
This reverts commit 8a4d2e8.
nandereck
force-pushed
the
nels/related-content/create-component
branch
from
c9dff7d
to
2a08f5b
Compare
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @hashicorp/react-related-content@0.2.0 ### Minor Changes - [#731](#731) [`2a26b0bf`](2a26b0b) Thanks [@nandereck](https://github.com/nandereck)! - Create RelatedContent component
🎟️ Asana Task
🔍 Preview Link
Description
Adds new
<RelatedContent />component. One thing to note is that this does not include the initially proposed dropdown. Instead, we've replaced with a CTA (using the<StandaloneLink />).Figma
PR Checklist 🚀
Items in this checklist may not may not apply to your PR, but please consider each item carefully.