New UI ✨ #131
Merged
New UI ✨ #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
prestonbourne
commented
Jul 19, 2023
| <main className="ss-h-full ss-w-full ss-overflow-auto ss-m-auto"> | ||
| <div | ||
| className={cx( | ||
| 'ss-flex ss-flex-col ss-flex-grow ss-m-auto ss-max-w-5xl ss-mb-24 ss-transition-all', |
There was a problem hiding this comment.
ss-mb-24 Ensures the last piece of content doesnt get clipped as part of the overflow.
Creating the margin pushes the div up
dstaley
suggested changes
Jul 19, 2023
Comment on lines
18
to
19
| !isOpen && 'ss-w-2/3', | ||
| isOpen && 'ss-w-1/2' |
There was a problem hiding this comment.
I think this would be more readable as a ternary expression.
isOpen ? `ss-w-1/2' : 'ss-w-2/3'
Comment on lines
18
to
19
| 'ss-hidden ss-absolute lg:ss-block hover:ss-text-action ss-ml-1 ss-p-1 ss-transition-all ss-top-3 ss-right-3', | ||
| !isOpen && 'ss--rotate-90', |
dstaley
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview
Summary
This PR does the following
ChevronintoBottomicon per design specmax-widthof main contentWhy
Quick explanation for the last one, when talking to @benjamin-gage we were discussing that the main reason for full-screen in the first place was so that someone can have more pleasant usage with
LiveComponent.Since now it links to Codesandbox, a fully equipped online IDE. Having full screen for reading content would likely just make the documentation harder to read.