This repository has been archived by the owner on Jan 25, 2023. It is now read-only.
Set up http_api access correctly #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the module is given only security groups and not cidr ranges, a security group rule is created without all the necessary attributes
brikis98
approved these changes
May 3, 2021
|
Tests passed! Merging now. |
|
thanks for the quick turnaround!
…On Mon, May 3, 2021 at 11:58 AM Yevgeniy Brikman ***@***.***> wrote:
https://github.com/hashicorp/terraform-aws-consul/releases/tag/v0.9.2
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#218 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEQD4EOGPYRQJ3PNYCGQTTTLZ6W5ANCNFSM43U2TEMQ>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Received an error using the module in our terraform:
Error: One of ['cidr_blocks', 'ipv6_cidr_blocks', 'self', 'source_security_group_id', 'prefix_list_ids'] must be set to create an AWS Security Group Rule
Error on .terraform/modules/consul_servers/modules/consul-security-group-rules/main.tf line 70, in resource "aws_security_group_rule" "allow_https_api_inbound":
Error: resource "aws_security_group_rule" "allow_https_api_inbound" {
If the module is given only security groups and not cidr ranges, a security group rule is created without all the necessary attributes. Change applies the right boolean logic for this case.