Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python JSII bug where strings are being taken as forwarded type declarations #2370

Closed
DanielMSchmidt opened this issue Dec 1, 2022 · 2 comments · Fixed by #2428
Closed
Assignees
Labels
bug Something isn't working confirmed independently reproduced by an engineer on the team language/python testing
Milestone

Comments

@DanielMSchmidt
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Expected Behavior

JSII should work with unions

Actual Behavior

It does not, see reference context below. We disabled the python/edge tests and need to re-enable them once the next version of JSII ships

Steps to Reproduce

Important Factoids

References

@DanielMSchmidt DanielMSchmidt added bug Something isn't working new Un-triaged issue labels Dec 1, 2022
@DanielMSchmidt DanielMSchmidt added this to the 0.15 milestone Dec 1, 2022
@ansgarm ansgarm removed the new Un-triaged issue label Dec 1, 2022
@DanielMSchmidt DanielMSchmidt added language/python testing confirmed independently reproduced by an engineer on the team labels Dec 2, 2022
@DanielMSchmidt
Copy link
Contributor Author

This was fixed in aws/jsii#3866 and released in JSII 1.72.0

DanielMSchmidt added a commit that referenced this issue Dec 15, 2022
@DanielMSchmidt DanielMSchmidt self-assigned this Dec 15, 2022
DanielMSchmidt added a commit that referenced this issue Dec 15, 2022
DanielMSchmidt added a commit that referenced this issue Dec 15, 2022
DanielMSchmidt added a commit that referenced this issue Jan 10, 2023
DanielMSchmidt added a commit that referenced this issue Jan 11, 2023
DanielMSchmidt added a commit that referenced this issue Jan 11, 2023
@github-actions
Copy link
Contributor

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working confirmed independently reproduced by an engineer on the team language/python testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants