chore(python): use builtins.str instead of just str in Dict keys #3866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an integration test to verify parameters named `builtins` or `str` do not shadow the relevant type names, which used to be problematic until aws#3848 fixed the overarching issue, hoever the existing test only covered the case where a parameter name shadowed an namespace/import. Additionally, changes various `typing.Dict` keys that were mistakenly spelled out as `str` to use `builtins.str` in order to improve overall consistency in type declarations (see also aws#3866). Co-authored-by: rmuller@amazon.fr
RomainMuller
changed the title
RomainMuller
approved these changes
Dec 1, 2022
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
DanielMSchmidt
added a commit
to hashicorp/terraform-cdk
that referenced
this pull request
Dec 1, 2022
The issue causing this problem will be released in the next days, but we have other problems in the release pipeline that should be fixed beforehand. Therefore I'll disable these tests for now and re-add them when updating JSII. The fix we are waiting for to be released is aws/jsii#3866
DanielMSchmidt
added a commit
to hashicorp/terraform-cdk
that referenced
this pull request
Dec 1, 2022
The issue causing this problem will be released in the next days, but we have other problems in the release pipeline that should be fixed beforehand. Therefore I'll disable these tests for now and re-add them when updating JSII. The fix we are waiting for to be released is aws/jsii#3866
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an integration test to verify parameters named
builtinsorstrdo not shadow the relevant type names, which used to be problematic
until #3848 fixed the overarching issue, hoever the existing test only
covered the case where a parameter name shadowed an namespace/import.
Additionally, changes various
typing.Dictkeys that were mistakenlyspelled out as
strto usebuiltins.strin order to improve overallconsistency in type declarations (see also #3866).
Co-authored-by: rmuller@amazon.fr
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.