Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Terraform 0.12 update #40

Merged
merged 8 commits into from
Jun 26, 2019
Merged

Terraform 0.12 update #40

merged 8 commits into from
Jun 26, 2019

Conversation

Etiene
Copy link
Contributor

@Etiene Etiene commented Jun 25, 2019

Updates to terraform > 0.12.0. This is a backwards incompatible change

Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left one comment on a minor style nit.

@@ -1,11 +1,12 @@
[![Maintained by Gruntwork.io](https://img.shields.io/badge/maintained%20by-gruntwork.io-%235849a6.svg)](https://gruntwork.io/?ref=repo_gcp_consul)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 to cleaning up the trailing whitespace!

@@ -4,35 +4,43 @@
# ---------------------------------------------------------------------------------------------------------------------

variable "gcp_project_id" {
type = string
description = "The name of the GCP Project where all resources will be launched."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type should be after description.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants