Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable cgo for builds #1193

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Disable cgo for builds #1193

merged 1 commit into from
Feb 22, 2023

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Feb 22, 2023

When migrating to CRT, I missed disabling cgo for native (Linux) builds. We had this set before in the .goreleaser.yml

The current binaries released for Linux are dynamically linked, as reported in hashicorp/vscode-terraform#1346

@dbanck dbanck added the ci Continuous integration/delivery related label Feb 22, 2023
@dbanck dbanck requested a review from a team February 22, 2023 13:16
@dbanck dbanck requested a review from a team as a code owner February 22, 2023 13:16
@dbanck dbanck self-assigned this Feb 22, 2023
@dbanck dbanck requested review from shore and claire-labry and removed request for a team February 22, 2023 13:16
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@dbanck dbanck merged commit 2350062 into main Feb 22, 2023
@dbanck dbanck deleted the b-fix-cgo-build branch February 22, 2023 13:24
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci Continuous integration/delivery related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants