Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach diag service to context #373

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Attach diag service to context #373

merged 1 commit into from
Jan 11, 2021

Conversation

appilon
Copy link
Contributor

@appilon appilon commented Jan 11, 2021

No description provided.

@appilon appilon requested a review from a team January 11, 2021 20:29
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I haven't tested this (yet) with hashicorp/vscode-terraform#540

@appilon
Copy link
Contributor Author

appilon commented Jan 11, 2021

Given the change in the PR I will merge this.

@appilon appilon merged commit 8dca2d8 into main Jan 11, 2021
@appilon appilon deleted the fix-executeCommand-validate branch January 11, 2021 21:43
@ghost
Copy link

ghost commented Feb 10, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Feb 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants