Utilize CPU better when loading modules #391
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #186
While the number of operations in parallel is capped, we can still overutilize the available CPU as per
terraform-ls/internal/terraform/module/module_manager.go
Line 46 in d31f6b4
(prior to #385)
and now
terraform-ls/internal/terraform/module/module_loader.go
Lines 25 to 26 in f5ddf9a
This patch therefore ensures that except for single-core we never run more threads than there is CPUs available, which should provide some relief to users with many modules in the hierarchy.