Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize CPU better when loading modules #391

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Feb 3, 2021

Closes #186

While the number of operations in parallel is capped, we can still overutilize the available CPU as per

defaultSize := 3 * runtime.NumCPU()

(prior to #385)

and now

nonPrioParallelism := 2 * runtime.NumCPU()
prioParallelism := 1 * runtime.NumCPU()

This patch therefore ensures that except for single-core we never run more threads than there is CPUs available, which should provide some relief to users with many modules in the hierarchy.

@radeksimko radeksimko added the enhancement New feature or request label Feb 3, 2021
@radeksimko radeksimko requested a review from a team February 3, 2021 12:31
Copy link
Contributor

@aeschright aeschright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ghost
Copy link

ghost commented Mar 5, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set a cap for auto-loading root modules
2 participants