Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tfvars (variable files) #540

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Add support for tfvars (variable files) #540

merged 1 commit into from
Jun 10, 2021

Conversation

beandrad
Copy link
Contributor

@beandrad beandrad commented May 28, 2021

So that we can use the language server for "tfvars" files.

Closes #50

Screenshot 2021-06-10 at 10 15 45

@hashicorp-cla
Copy link

hashicorp-cla commented May 28, 2021

CLA assistant check
All committers have signed the CLA.

go.mod Outdated Show resolved Hide resolved
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, this looks like a good start! I left you some in-line comments.

I have yet to decide about the language ID to use for these files but keep it tfvars for now - I assume it's just a minor implementation detail anyway that can be changed easily.

internal/terraform/module/module_manager.go Outdated Show resolved Hide resolved
internal/terraform/module/module_manager.go Outdated Show resolved Hide resolved
internal/terraform/module/module_manager_test.go Outdated Show resolved Hide resolved
internal/terraform/module/module_ops.go Outdated Show resolved Hide resolved
internal/terraform/module/module_manager.go Outdated Show resolved Hide resolved
internal/langserver/handlers/did_change.go Outdated Show resolved Hide resolved
internal/langserver/handlers/did_change.go Outdated Show resolved Hide resolved
internal/cmd/completion_command.go Outdated Show resolved Hide resolved
internal/state/module.go Outdated Show resolved Hide resolved
internal/state/module.go Outdated Show resolved Hide resolved
internal/state/module.go Outdated Show resolved Hide resolved
internal/state/module_test.go Outdated Show resolved Hide resolved
internal/lsp/language_id.go Outdated Show resolved Hide resolved
internal/terraform/module/module_ops.go Outdated Show resolved Hide resolved
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go.mod Outdated Show resolved Hide resolved
internal/langserver/handlers/did_change.go Outdated Show resolved Hide resolved
internal/state/module.go Outdated Show resolved Hide resolved
internal/state/module.go Outdated Show resolved Hide resolved
internal/terraform/module/module_loader.go Outdated Show resolved Hide resolved
internal/terraform/module/module_loader.go Outdated Show resolved Hide resolved
internal/terraform/module/module_ops.go Outdated Show resolved Hide resolved
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the last two comments this LGTM! Thank you for all your effort to get it to this point @beandrad

I will have a discussion internally about what the right language ID is for tfvars - if not tfvars and then we can merge it.

internal/terraform/module/module_ops.go Outdated Show resolved Hide resolved
internal/decoder/decoder.go Show resolved Hide resolved
@radeksimko radeksimko changed the title Add support for variable schema Add support for tfvars (variable files) Jun 3, 2021
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some more thorough testing in VS Code as well and I just noticed two more things that we should address here:

Screenshot 2021-06-03 at 13 42 08

So that we can use the language server for "tfvars" files.

Related to #50
@beandrad beandrad mentioned this pull request Jun 4, 2021
@radeksimko radeksimko merged commit 9b1ed21 into hashicorp:main Jun 10, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support variable files (*.tfvars)
3 participants