Nice debug logs #463
Merged
Nice debug logs #463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like a good idea so long as there wasn't anyone relying on the old logging output to debug in some way. I assume not though, should still provide enough information about when the error is occurring I would think. Though maybe they are not as familiar with what happens during plan and apply steps specifically but maybe it can be educational |
rainkwan
approved these changes
Mar 25, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims for visually-scannable debug output from tests.
It changes the detailed logging of the provider lifecycle in
resource.runProviderCommandfrom DEBUG to TRACE level. I have used this patch locally for nearly a week. In one example, debug output improves from 166 lines to 30 lines.The DEBUG-level logging originated 3 years ago in b5c80aa. I feel the provider lifecycle is stable enough that we can change it to TRACE logging.
resource.runProviderCommandhas logic to handle various provider errors by returning anerror.