Initial work on Query command for List Resource #531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephybun
previously approved these changes
Aug 1, 2025
|
|
||
| var _ tfprotov6.ProviderServer = ProviderServer{} | ||
|
|
||
| // var _ tfprotov6.ProviderServerWithListResource = ProviderServer{} |
There was a problem hiding this comment.
Should this still be commented out?
There was a problem hiding this comment.
Generally speaking, this interface should only be directly referenced by exported terraform-plugin-go packages or testing packages like in terraform-plugin-mux
Since it's a temporary interface, we will eventually remove it once all downstream provider servers have a chance to implement them (for example, SDKv2 will need to implement the interface eventually, even if it doesn't have an SDK for the RPCs). Once that is removed, since there are no direct references to the interface itself, no downstream packages need to be re-released with the interface removed and provider's CI won't break 🙂
Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: stephybun <steph@hashicorp.com>
stephybun
approved these changes
Aug 5, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Building off #528
Description
Adding ListResource and ValidateListResourceConfig from List Resource to plugin testing.
Rollback Plan
Changes to Security Controls
No