Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add excludes option to document. #33

Closed
wants to merge 1 commit into from

Conversation

heyyou3
Copy link

@heyyou3 heyyou3 commented Dec 4, 2018

I'm sorry for my poor English...

I created a pull request because the excludes option was missing from the document.

If you intentionally didn't list the excludes option in the document, close this pull request.

@kpettijohn
Copy link

Would be nice to get some mention of the excludes option in the documentation. It might also be worth noting that when excluding a directory you must NOT include the trailing slash.

Example:
Fails to exclude the vendor directory.

data "archive_file" "zip" {
  type        = "zip"
  output_path = "lambda.zip"
  source_dir  = "${path.module}/lambda"
  excludes    = ["vendor/", "Makefile"]
}

Successfully excludes the vendor directory.

data "archive_file" "zip" {
  type        = "zip"
  output_path = "lambda.zip"
  source_dir  = "${path.module}/lambda"
  excludes    = ["vendor", "Makefile"]
}

@heyyou3 heyyou3 closed this Apr 5, 2019
@27Bslash6
Copy link

Why close this? Excludes remains undocumented, and I only found this feature via this issue.

@javiercornejo
Copy link

Thanks @kpettijohn works for me. @27Bslash6 agree! this shouldn't be closed

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants