Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Region/partition-agnostic aws_instance acceptance tests #11126

Closed
wants to merge 17 commits into from

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Dec 4, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #4987.

Enable the aws_instance data source and resource acceptance tests to be run outside us-west-2.

Release note for CHANGELOG:

NONE

Output from acceptance testing:

See below.

@ewbankkit ewbankkit requested a review from a team December 4, 2019 00:16
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 4, 2019
@ewbankkit ewbankkit force-pushed the issue-4987 branch 2 times, most recently from cbb36cd to dd865ca Compare December 4, 2019 01:48
@ewbankkit
Copy link
Contributor Author

ewbankkit commented Dec 5, 2019

Acceptance test results.

Data sources:

aws_instance
# EC2-Classic tests now gated by environment variable.
$ EC2_CLASSIC_REGION=us-east-1 make testacc TEST=./aws TESTARGS='-run=TestAccAWSInstanceDataSource_Ec2ClassicSecurityGroups'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSInstanceDataSource_Ec2ClassicSecurityGroups -timeout 1200m
=== RUN   TestAccAWSInstanceDataSource_Ec2ClassicSecurityGroups
=== PAUSE TestAccAWSInstanceDataSource_Ec2ClassicSecurityGroups
=== CONT  TestAccAWSInstanceDataSource_Ec2ClassicSecurityGroups
--- PASS: TestAccAWSInstanceDataSource_Ec2ClassicSecurityGroups (307.50s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	307.527s
# Default acceptance test region (us-west-2):
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSInstanceDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSInstanceDataSource_ -timeout 1200m
=== RUN   TestAccAWSInstanceDataSource_basic
=== PAUSE TestAccAWSInstanceDataSource_basic
=== RUN   TestAccAWSInstanceDataSource_tags
=== PAUSE TestAccAWSInstanceDataSource_tags
=== RUN   TestAccAWSInstanceDataSource_AzUserData
=== PAUSE TestAccAWSInstanceDataSource_AzUserData
=== RUN   TestAccAWSInstanceDataSource_gp2IopsDevice
=== PAUSE TestAccAWSInstanceDataSource_gp2IopsDevice
=== RUN   TestAccAWSInstanceDataSource_blockDevices
=== PAUSE TestAccAWSInstanceDataSource_blockDevices
=== RUN   TestAccAWSInstanceDataSource_EbsBlockDevice_KmsKeyId
=== PAUSE TestAccAWSInstanceDataSource_EbsBlockDevice_KmsKeyId
=== RUN   TestAccAWSInstanceDataSource_RootBlockDevice_KmsKeyId
=== PAUSE TestAccAWSInstanceDataSource_RootBlockDevice_KmsKeyId
=== RUN   TestAccAWSInstanceDataSource_rootInstanceStore
=== PAUSE TestAccAWSInstanceDataSource_rootInstanceStore
=== RUN   TestAccAWSInstanceDataSource_privateIP
=== PAUSE TestAccAWSInstanceDataSource_privateIP
=== RUN   TestAccAWSInstanceDataSource_keyPair
=== PAUSE TestAccAWSInstanceDataSource_keyPair
=== RUN   TestAccAWSInstanceDataSource_VPC
=== PAUSE TestAccAWSInstanceDataSource_VPC
=== RUN   TestAccAWSInstanceDataSource_PlacementGroup
=== PAUSE TestAccAWSInstanceDataSource_PlacementGroup
=== RUN   TestAccAWSInstanceDataSource_Ec2ClassicSecurityGroups
--- SKIP: TestAccAWSInstanceDataSource_Ec2ClassicSecurityGroups (0.00s)
    data_source_aws_instance_test.go:330: EC2_CLASSIC_REGION must be set to run EC2-Classic acceptance tests
=== RUN   TestAccAWSInstanceDataSource_VPCSecurityGroups
=== PAUSE TestAccAWSInstanceDataSource_VPCSecurityGroups
=== RUN   TestAccAWSInstanceDataSource_getPasswordData_trueToFalse
=== PAUSE TestAccAWSInstanceDataSource_getPasswordData_trueToFalse
=== RUN   TestAccAWSInstanceDataSource_getPasswordData_falseToTrue
=== PAUSE TestAccAWSInstanceDataSource_getPasswordData_falseToTrue
=== RUN   TestAccAWSInstanceDataSource_GetUserData
=== PAUSE TestAccAWSInstanceDataSource_GetUserData
=== RUN   TestAccAWSInstanceDataSource_GetUserData_NoUserData
=== PAUSE TestAccAWSInstanceDataSource_GetUserData_NoUserData
=== RUN   TestAccAWSInstanceDataSource_creditSpecification
=== PAUSE TestAccAWSInstanceDataSource_creditSpecification
=== CONT  TestAccAWSInstanceDataSource_basic
=== CONT  TestAccAWSInstanceDataSource_VPC
--- PASS: TestAccAWSInstanceDataSource_VPC (113.78s)
=== CONT  TestAccAWSInstanceDataSource_creditSpecification
--- PASS: TestAccAWSInstanceDataSource_basic (126.65s)
=== CONT  TestAccAWSInstanceDataSource_GetUserData_NoUserData
--- PASS: TestAccAWSInstanceDataSource_creditSpecification (123.93s)
=== CONT  TestAccAWSInstanceDataSource_GetUserData
--- PASS: TestAccAWSInstanceDataSource_GetUserData_NoUserData (286.12s)
=== CONT  TestAccAWSInstanceDataSource_getPasswordData_falseToTrue
--- PASS: TestAccAWSInstanceDataSource_GetUserData (198.00s)
=== CONT  TestAccAWSInstanceDataSource_getPasswordData_trueToFalse
--- PASS: TestAccAWSInstanceDataSource_getPasswordData_falseToTrue (197.48s)
=== CONT  TestAccAWSInstanceDataSource_VPCSecurityGroups
--- PASS: TestAccAWSInstanceDataSource_getPasswordData_trueToFalse (198.58s)
=== CONT  TestAccAWSInstanceDataSource_PlacementGroup
--- PASS: TestAccAWSInstanceDataSource_VPCSecurityGroups (121.09s)
=== CONT  TestAccAWSInstanceDataSource_EbsBlockDevice_KmsKeyId
--- PASS: TestAccAWSInstanceDataSource_PlacementGroup (101.96s)
=== CONT  TestAccAWSInstanceDataSource_keyPair
--- PASS: TestAccAWSInstanceDataSource_keyPair (96.45s)
=== CONT  TestAccAWSInstanceDataSource_privateIP
--- PASS: TestAccAWSInstanceDataSource_EbsBlockDevice_KmsKeyId (132.13s)
=== CONT  TestAccAWSInstanceDataSource_rootInstanceStore
--- PASS: TestAccAWSInstanceDataSource_privateIP (132.63s)
=== CONT  TestAccAWSInstanceDataSource_RootBlockDevice_KmsKeyId
--- PASS: TestAccAWSInstanceDataSource_rootInstanceStore (111.89s)
=== CONT  TestAccAWSInstanceDataSource_gp2IopsDevice
--- PASS: TestAccAWSInstanceDataSource_gp2IopsDevice (105.44s)
=== CONT  TestAccAWSInstanceDataSource_blockDevices
--- PASS: TestAccAWSInstanceDataSource_RootBlockDevice_KmsKeyId (142.21s)
=== CONT  TestAccAWSInstanceDataSource_AzUserData
--- PASS: TestAccAWSInstanceDataSource_blockDevices (105.13s)
=== CONT  TestAccAWSInstanceDataSource_tags
--- PASS: TestAccAWSInstanceDataSource_AzUserData (116.96s)
--- PASS: TestAccAWSInstanceDataSource_tags (208.97s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1394.955s
# us-east-2:
$ AWS_DEFAULT_REGION=us-east-2 make testacc TEST=./aws TESTARGS='-run=TestAccAWSInstanceDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSInstanceDataSource_ -timeout 1200m
=== RUN   TestAccAWSInstanceDataSource_basic
=== PAUSE TestAccAWSInstanceDataSource_basic
=== RUN   TestAccAWSInstanceDataSource_tags
=== PAUSE TestAccAWSInstanceDataSource_tags
=== RUN   TestAccAWSInstanceDataSource_AzUserData
=== PAUSE TestAccAWSInstanceDataSource_AzUserData
=== RUN   TestAccAWSInstanceDataSource_gp2IopsDevice
=== PAUSE TestAccAWSInstanceDataSource_gp2IopsDevice
=== RUN   TestAccAWSInstanceDataSource_blockDevices
=== PAUSE TestAccAWSInstanceDataSource_blockDevices
=== RUN   TestAccAWSInstanceDataSource_EbsBlockDevice_KmsKeyId
=== PAUSE TestAccAWSInstanceDataSource_EbsBlockDevice_KmsKeyId
=== RUN   TestAccAWSInstanceDataSource_RootBlockDevice_KmsKeyId
=== PAUSE TestAccAWSInstanceDataSource_RootBlockDevice_KmsKeyId
=== RUN   TestAccAWSInstanceDataSource_rootInstanceStore
=== PAUSE TestAccAWSInstanceDataSource_rootInstanceStore
=== RUN   TestAccAWSInstanceDataSource_privateIP
=== PAUSE TestAccAWSInstanceDataSource_privateIP
=== RUN   TestAccAWSInstanceDataSource_keyPair
=== PAUSE TestAccAWSInstanceDataSource_keyPair
=== RUN   TestAccAWSInstanceDataSource_VPC
=== PAUSE TestAccAWSInstanceDataSource_VPC
=== RUN   TestAccAWSInstanceDataSource_PlacementGroup
=== PAUSE TestAccAWSInstanceDataSource_PlacementGroup
=== RUN   TestAccAWSInstanceDataSource_Ec2ClassicSecurityGroups
--- SKIP: TestAccAWSInstanceDataSource_Ec2ClassicSecurityGroups (0.00s)
    data_source_aws_instance_test.go:330: EC2_CLASSIC_REGION must be set to run EC2-Classic acceptance tests
=== RUN   TestAccAWSInstanceDataSource_VPCSecurityGroups
=== PAUSE TestAccAWSInstanceDataSource_VPCSecurityGroups
=== RUN   TestAccAWSInstanceDataSource_getPasswordData_trueToFalse
=== PAUSE TestAccAWSInstanceDataSource_getPasswordData_trueToFalse
=== RUN   TestAccAWSInstanceDataSource_getPasswordData_falseToTrue
=== PAUSE TestAccAWSInstanceDataSource_getPasswordData_falseToTrue
=== RUN   TestAccAWSInstanceDataSource_GetUserData
=== PAUSE TestAccAWSInstanceDataSource_GetUserData
=== RUN   TestAccAWSInstanceDataSource_GetUserData_NoUserData
=== PAUSE TestAccAWSInstanceDataSource_GetUserData_NoUserData
=== RUN   TestAccAWSInstanceDataSource_creditSpecification
=== PAUSE TestAccAWSInstanceDataSource_creditSpecification
=== CONT  TestAccAWSInstanceDataSource_basic
=== CONT  TestAccAWSInstanceDataSource_VPC
--- SKIP: TestAccAWSInstanceDataSource_VPC (2.13s)
    resource_aws_instance_test.go:4108: skipping tests; us-east-2 does not offer EC2 instance type: m1.small
=== CONT  TestAccAWSInstanceDataSource_creditSpecification
--- SKIP: TestAccAWSInstanceDataSource_basic (2.27s)
    resource_aws_instance_test.go:4108: skipping tests; us-east-2 does not offer EC2 instance type: m1.small
=== CONT  TestAccAWSInstanceDataSource_GetUserData_NoUserData
--- PASS: TestAccAWSInstanceDataSource_creditSpecification (84.27s)
=== CONT  TestAccAWSInstanceDataSource_GetUserData
--- PASS: TestAccAWSInstanceDataSource_GetUserData_NoUserData (132.05s)
=== CONT  TestAccAWSInstanceDataSource_getPasswordData_falseToTrue
--- PASS: TestAccAWSInstanceDataSource_GetUserData (119.95s)
=== CONT  TestAccAWSInstanceDataSource_getPasswordData_trueToFalse
--- PASS: TestAccAWSInstanceDataSource_getPasswordData_falseToTrue (185.27s)
=== CONT  TestAccAWSInstanceDataSource_VPCSecurityGroups
--- SKIP: TestAccAWSInstanceDataSource_VPCSecurityGroups (1.77s)
    resource_aws_instance_test.go:4108: skipping tests; us-east-2 does not offer EC2 instance type: t1.micro
=== CONT  TestAccAWSInstanceDataSource_PlacementGroup
--- SKIP: TestAccAWSInstanceDataSource_PlacementGroup (1.82s)
    resource_aws_instance_test.go:4108: skipping tests; us-east-2 does not offer EC2 instance type: c3.large
=== CONT  TestAccAWSInstanceDataSource_EbsBlockDevice_KmsKeyId
--- SKIP: TestAccAWSInstanceDataSource_EbsBlockDevice_KmsKeyId (2.01s)
    resource_aws_instance_test.go:4108: skipping tests; us-east-2 does not offer EC2 instance type: m3.medium
=== CONT  TestAccAWSInstanceDataSource_keyPair
--- SKIP: TestAccAWSInstanceDataSource_keyPair (2.01s)
    resource_aws_instance_test.go:4108: skipping tests; us-east-2 does not offer EC2 instance type: t1.micro
=== CONT  TestAccAWSInstanceDataSource_privateIP
--- PASS: TestAccAWSInstanceDataSource_getPasswordData_trueToFalse (205.57s)
=== CONT  TestAccAWSInstanceDataSource_rootInstanceStore
--- SKIP: TestAccAWSInstanceDataSource_rootInstanceStore (1.89s)
    resource_aws_instance_test.go:4108: skipping tests; us-east-2 does not offer EC2 instance type: m3.medium
=== CONT  TestAccAWSInstanceDataSource_RootBlockDevice_KmsKeyId
--- SKIP: TestAccAWSInstanceDataSource_RootBlockDevice_KmsKeyId (2.06s)
    resource_aws_instance_test.go:4108: skipping tests; us-east-2 does not offer EC2 instance type: m3.medium
=== CONT  TestAccAWSInstanceDataSource_gp2IopsDevice
--- SKIP: TestAccAWSInstanceDataSource_gp2IopsDevice (2.04s)
    resource_aws_instance_test.go:4108: skipping tests; us-east-2 does not offer EC2 instance type: m3.medium
=== CONT  TestAccAWSInstanceDataSource_blockDevices
--- SKIP: TestAccAWSInstanceDataSource_blockDevices (1.95s)
    resource_aws_instance_test.go:4108: skipping tests; us-east-2 does not offer EC2 instance type: m3.medium
=== CONT  TestAccAWSInstanceDataSource_AzUserData
--- PASS: TestAccAWSInstanceDataSource_privateIP (93.89s)
=== CONT  TestAccAWSInstanceDataSource_tags
--- SKIP: TestAccAWSInstanceDataSource_AzUserData (2.05s)
    resource_aws_instance_test.go:4108: skipping tests; us-east-2 does not offer EC2 instance type: m1.small
--- SKIP: TestAccAWSInstanceDataSource_tags (2.05s)
    resource_aws_instance_test.go:4108: skipping tests; us-east-2 does not offer EC2 instance type: m1.small
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	423.191s
# us-east-1; EC2-Classic:
$ AWS_DEFAULT_REGION=us-east-1 make testacc TEST=./aws TESTARGS='-run=TestAccAWSInstanceDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSInstanceDataSource_ -timeout 1200m
=== RUN   TestAccAWSInstanceDataSource_basic
=== PAUSE TestAccAWSInstanceDataSource_basic
=== RUN   TestAccAWSInstanceDataSource_tags
=== PAUSE TestAccAWSInstanceDataSource_tags
=== RUN   TestAccAWSInstanceDataSource_AzUserData
=== PAUSE TestAccAWSInstanceDataSource_AzUserData
=== RUN   TestAccAWSInstanceDataSource_gp2IopsDevice
=== PAUSE TestAccAWSInstanceDataSource_gp2IopsDevice
=== RUN   TestAccAWSInstanceDataSource_blockDevices
=== PAUSE TestAccAWSInstanceDataSource_blockDevices
=== RUN   TestAccAWSInstanceDataSource_EbsBlockDevice_KmsKeyId
=== PAUSE TestAccAWSInstanceDataSource_EbsBlockDevice_KmsKeyId
=== RUN   TestAccAWSInstanceDataSource_RootBlockDevice_KmsKeyId
=== PAUSE TestAccAWSInstanceDataSource_RootBlockDevice_KmsKeyId
=== RUN   TestAccAWSInstanceDataSource_rootInstanceStore
=== PAUSE TestAccAWSInstanceDataSource_rootInstanceStore
=== RUN   TestAccAWSInstanceDataSource_privateIP
=== PAUSE TestAccAWSInstanceDataSource_privateIP
=== RUN   TestAccAWSInstanceDataSource_keyPair
=== PAUSE TestAccAWSInstanceDataSource_keyPair
=== RUN   TestAccAWSInstanceDataSource_VPC
=== PAUSE TestAccAWSInstanceDataSource_VPC
=== RUN   TestAccAWSInstanceDataSource_PlacementGroup
=== PAUSE TestAccAWSInstanceDataSource_PlacementGroup
=== RUN   TestAccAWSInstanceDataSource_Ec2ClassicSecurityGroups
--- SKIP: TestAccAWSInstanceDataSource_Ec2ClassicSecurityGroups (0.00s)
    data_source_aws_instance_test.go:330: EC2_CLASSIC_REGION must be set to run EC2-Classic acceptance tests
=== RUN   TestAccAWSInstanceDataSource_VPCSecurityGroups
=== PAUSE TestAccAWSInstanceDataSource_VPCSecurityGroups
=== RUN   TestAccAWSInstanceDataSource_getPasswordData_trueToFalse
=== PAUSE TestAccAWSInstanceDataSource_getPasswordData_trueToFalse
=== RUN   TestAccAWSInstanceDataSource_getPasswordData_falseToTrue
=== PAUSE TestAccAWSInstanceDataSource_getPasswordData_falseToTrue
=== RUN   TestAccAWSInstanceDataSource_GetUserData
=== PAUSE TestAccAWSInstanceDataSource_GetUserData
=== RUN   TestAccAWSInstanceDataSource_GetUserData_NoUserData
=== PAUSE TestAccAWSInstanceDataSource_GetUserData_NoUserData
=== RUN   TestAccAWSInstanceDataSource_creditSpecification
=== PAUSE TestAccAWSInstanceDataSource_creditSpecification
=== CONT  TestAccAWSInstanceDataSource_basic
=== CONT  TestAccAWSInstanceDataSource_VPC
--- PASS: TestAccAWSInstanceDataSource_VPC (97.51s)
=== CONT  TestAccAWSInstanceDataSource_creditSpecification
--- PASS: TestAccAWSInstanceDataSource_creditSpecification (114.98s)
=== CONT  TestAccAWSInstanceDataSource_GetUserData_NoUserData
--- PASS: TestAccAWSInstanceDataSource_basic (242.23s)
=== CONT  TestAccAWSInstanceDataSource_GetUserData
--- PASS: TestAccAWSInstanceDataSource_GetUserData_NoUserData (134.59s)
=== CONT  TestAccAWSInstanceDataSource_getPasswordData_trueToFalse
--- SKIP: TestAccAWSInstanceDataSource_getPasswordData_trueToFalse (2.08s)
    provider_test.go:267: This test can only in regions without EC2 Classic, platforms available in us-east-1: ["EC2" "VPC"]
=== CONT  TestAccAWSInstanceDataSource_getPasswordData_falseToTrue
--- SKIP: TestAccAWSInstanceDataSource_getPasswordData_falseToTrue (2.08s)
    provider_test.go:267: This test can only in regions without EC2 Classic, platforms available in us-east-1: ["EC2" "VPC"]
--- PASS: TestAccAWSInstanceDataSource_GetUserData (139.83s)
=== CONT  TestAccAWSInstanceDataSource_VPCSecurityGroups
=== CONT  TestAccAWSInstanceDataSource_PlacementGroup
--- PASS: TestAccAWSInstanceDataSource_PlacementGroup (83.59s)
=== CONT  TestAccAWSInstanceDataSource_EbsBlockDevice_KmsKeyId
--- PASS: TestAccAWSInstanceDataSource_VPCSecurityGroups (93.94s)
=== CONT  TestAccAWSInstanceDataSource_keyPair
--- PASS: TestAccAWSInstanceDataSource_keyPair (89.46s)
=== CONT  TestAccAWSInstanceDataSource_privateIP
--- PASS: TestAccAWSInstanceDataSource_EbsBlockDevice_KmsKeyId (121.42s)
=== CONT  TestAccAWSInstanceDataSource_rootInstanceStore
--- PASS: TestAccAWSInstanceDataSource_privateIP (97.78s)
=== CONT  TestAccAWSInstanceDataSource_RootBlockDevice_KmsKeyId
--- PASS: TestAccAWSInstanceDataSource_rootInstanceStore (98.38s)
=== CONT  TestAccAWSInstanceDataSource_gp2IopsDevice
--- PASS: TestAccAWSInstanceDataSource_gp2IopsDevice (92.10s)
=== CONT  TestAccAWSInstanceDataSource_blockDevices
--- PASS: TestAccAWSInstanceDataSource_RootBlockDevice_KmsKeyId (121.42s)
=== CONT  TestAccAWSInstanceDataSource_AzUserData
--- PASS: TestAccAWSInstanceDataSource_blockDevices (100.08s)
=== CONT  TestAccAWSInstanceDataSource_tags
--- PASS: TestAccAWSInstanceDataSource_AzUserData (121.54s)
--- PASS: TestAccAWSInstanceDataSource_tags (128.75s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1010.049s
# eu-west-1; No default VPC:
$ AWS_DEFAULT_REGION=eu-west-1 make testacc TEST=./aws TESTARGS='-run=TestAccAWSInstanceDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSInstanceDataSource_ -timeout 1200m
=== RUN   TestAccAWSInstanceDataSource_basic
=== PAUSE TestAccAWSInstanceDataSource_basic
=== RUN   TestAccAWSInstanceDataSource_tags
=== PAUSE TestAccAWSInstanceDataSource_tags
=== RUN   TestAccAWSInstanceDataSource_AzUserData
=== PAUSE TestAccAWSInstanceDataSource_AzUserData
=== RUN   TestAccAWSInstanceDataSource_gp2IopsDevice
=== PAUSE TestAccAWSInstanceDataSource_gp2IopsDevice
=== RUN   TestAccAWSInstanceDataSource_blockDevices
=== PAUSE TestAccAWSInstanceDataSource_blockDevices
=== RUN   TestAccAWSInstanceDataSource_EbsBlockDevice_KmsKeyId
=== PAUSE TestAccAWSInstanceDataSource_EbsBlockDevice_KmsKeyId
=== RUN   TestAccAWSInstanceDataSource_RootBlockDevice_KmsKeyId
=== PAUSE TestAccAWSInstanceDataSource_RootBlockDevice_KmsKeyId
=== RUN   TestAccAWSInstanceDataSource_rootInstanceStore
=== PAUSE TestAccAWSInstanceDataSource_rootInstanceStore
=== RUN   TestAccAWSInstanceDataSource_privateIP
=== PAUSE TestAccAWSInstanceDataSource_privateIP
=== RUN   TestAccAWSInstanceDataSource_keyPair
=== PAUSE TestAccAWSInstanceDataSource_keyPair
=== RUN   TestAccAWSInstanceDataSource_VPC
=== PAUSE TestAccAWSInstanceDataSource_VPC
=== RUN   TestAccAWSInstanceDataSource_PlacementGroup
=== PAUSE TestAccAWSInstanceDataSource_PlacementGroup
=== RUN   TestAccAWSInstanceDataSource_Ec2ClassicSecurityGroups
--- SKIP: TestAccAWSInstanceDataSource_Ec2ClassicSecurityGroups (0.00s)
    data_source_aws_instance_test.go:330: EC2_CLASSIC_REGION must be set to run EC2-Classic acceptance tests
=== RUN   TestAccAWSInstanceDataSource_VPCSecurityGroups
=== PAUSE TestAccAWSInstanceDataSource_VPCSecurityGroups
=== RUN   TestAccAWSInstanceDataSource_getPasswordData_trueToFalse
=== PAUSE TestAccAWSInstanceDataSource_getPasswordData_trueToFalse
=== RUN   TestAccAWSInstanceDataSource_getPasswordData_falseToTrue
=== PAUSE TestAccAWSInstanceDataSource_getPasswordData_falseToTrue
=== RUN   TestAccAWSInstanceDataSource_GetUserData
=== PAUSE TestAccAWSInstanceDataSource_GetUserData
=== RUN   TestAccAWSInstanceDataSource_GetUserData_NoUserData
=== PAUSE TestAccAWSInstanceDataSource_GetUserData_NoUserData
=== RUN   TestAccAWSInstanceDataSource_creditSpecification
=== PAUSE TestAccAWSInstanceDataSource_creditSpecification
=== CONT  TestAccAWSInstanceDataSource_tags
=== CONT  TestAccAWSInstanceDataSource_creditSpecification
--- SKIP: TestAccAWSInstanceDataSource_tags (2.81s)
    resource_aws_instance_test.go:4129: skipping tests; eu-west-1 does not have a default VPC or EC2-Classic
=== CONT  TestAccAWSInstanceDataSource_basic
--- SKIP: TestAccAWSInstanceDataSource_basic (2.44s)
    resource_aws_instance_test.go:4129: skipping tests; eu-west-1 does not have a default VPC or EC2-Classic
=== CONT  TestAccAWSInstanceDataSource_keyPair
--- SKIP: TestAccAWSInstanceDataSource_keyPair (2.46s)
    resource_aws_instance_test.go:4129: skipping tests; eu-west-1 does not have a default VPC or EC2-Classic
=== CONT  TestAccAWSInstanceDataSource_GetUserData_NoUserData
--- PASS: TestAccAWSInstanceDataSource_creditSpecification (129.26s)
=== CONT  TestAccAWSInstanceDataSource_GetUserData
--- PASS: TestAccAWSInstanceDataSource_GetUserData_NoUserData (201.42s)
=== CONT  TestAccAWSInstanceDataSource_getPasswordData_falseToTrue
--- SKIP: TestAccAWSInstanceDataSource_getPasswordData_falseToTrue (2.46s)
    resource_aws_instance_test.go:4119: skipping tests; eu-west-1 does not have a default VPC
=== CONT  TestAccAWSInstanceDataSource_getPasswordData_trueToFalse
--- SKIP: TestAccAWSInstanceDataSource_getPasswordData_trueToFalse (2.42s)
    resource_aws_instance_test.go:4119: skipping tests; eu-west-1 does not have a default VPC
=== CONT  TestAccAWSInstanceDataSource_VPCSecurityGroups
--- PASS: TestAccAWSInstanceDataSource_GetUserData (201.03s)
=== CONT  TestAccAWSInstanceDataSource_PlacementGroup
--- PASS: TestAccAWSInstanceDataSource_VPCSecurityGroups (120.58s)
=== CONT  TestAccAWSInstanceDataSource_VPC
--- PASS: TestAccAWSInstanceDataSource_PlacementGroup (108.51s)
=== CONT  TestAccAWSInstanceDataSource_EbsBlockDevice_KmsKeyId
--- SKIP: TestAccAWSInstanceDataSource_EbsBlockDevice_KmsKeyId (2.53s)
    resource_aws_instance_test.go:4129: skipping tests; eu-west-1 does not have a default VPC or EC2-Classic
=== CONT  TestAccAWSInstanceDataSource_privateIP
--- PASS: TestAccAWSInstanceDataSource_VPC (119.94s)
=== CONT  TestAccAWSInstanceDataSource_rootInstanceStore
--- SKIP: TestAccAWSInstanceDataSource_rootInstanceStore (2.36s)
    resource_aws_instance_test.go:4129: skipping tests; eu-west-1 does not have a default VPC or EC2-Classic
=== CONT  TestAccAWSInstanceDataSource_RootBlockDevice_KmsKeyId
--- SKIP: TestAccAWSInstanceDataSource_RootBlockDevice_KmsKeyId (2.40s)
    resource_aws_instance_test.go:4129: skipping tests; eu-west-1 does not have a default VPC or EC2-Classic
=== CONT  TestAccAWSInstanceDataSource_gp2IopsDevice
--- SKIP: TestAccAWSInstanceDataSource_gp2IopsDevice (2.55s)
    resource_aws_instance_test.go:4129: skipping tests; eu-west-1 does not have a default VPC or EC2-Classic
=== CONT  TestAccAWSInstanceDataSource_blockDevices
--- SKIP: TestAccAWSInstanceDataSource_blockDevices (2.53s)
    resource_aws_instance_test.go:4129: skipping tests; eu-west-1 does not have a default VPC or EC2-Classic
=== CONT  TestAccAWSInstanceDataSource_AzUserData
--- SKIP: TestAccAWSInstanceDataSource_AzUserData (2.51s)
    resource_aws_instance_test.go:4129: skipping tests; eu-west-1 does not have a default VPC or EC2-Classic
--- PASS: TestAccAWSInstanceDataSource_privateIP (128.11s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	569.476s

@ewbankkit
Copy link
Contributor Author

Acceptance test results.

Data sources:

aws_instances
# Default acceptance test region (us-west-2):
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSInstancesDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSInstancesDataSource_ -timeout 1200m
=== RUN   TestAccAWSInstancesDataSource_basic
=== PAUSE TestAccAWSInstancesDataSource_basic
=== RUN   TestAccAWSInstancesDataSource_tags
=== PAUSE TestAccAWSInstancesDataSource_tags
=== RUN   TestAccAWSInstancesDataSource_instance_state_names
=== PAUSE TestAccAWSInstancesDataSource_instance_state_names
=== CONT  TestAccAWSInstancesDataSource_basic
=== CONT  TestAccAWSInstancesDataSource_instance_state_names
--- PASS: TestAccAWSInstancesDataSource_instance_state_names (100.09s)
=== CONT  TestAccAWSInstancesDataSource_tags
--- PASS: TestAccAWSInstancesDataSource_basic (100.16s)
--- PASS: TestAccAWSInstancesDataSource_tags (100.48s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	200.593s
# us-east-2:
$ AWS_DEFAULT_REGION=us-east-2 make testacc TEST=./aws TESTARGS='-run=TestAccAWSInstancesDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSInstancesDataSource_ -timeout 1200m
=== RUN   TestAccAWSInstancesDataSource_basic
=== PAUSE TestAccAWSInstancesDataSource_basic
=== RUN   TestAccAWSInstancesDataSource_tags
=== PAUSE TestAccAWSInstancesDataSource_tags
=== RUN   TestAccAWSInstancesDataSource_instance_state_names
=== PAUSE TestAccAWSInstancesDataSource_instance_state_names
=== CONT  TestAccAWSInstancesDataSource_basic
=== CONT  TestAccAWSInstancesDataSource_instance_state_names
--- PASS: TestAccAWSInstancesDataSource_instance_state_names (77.45s)
=== CONT  TestAccAWSInstancesDataSource_tags
--- PASS: TestAccAWSInstancesDataSource_basic (77.46s)
--- PASS: TestAccAWSInstancesDataSource_tags (87.03s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	164.508s
# us-east-1; EC2-Classic:
$ AWS_DEFAULT_REGION=us-east-1 make testacc TEST=./aws TESTARGS='-run=TestAccAWSInstancesDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSInstancesDataSource_ -timeout 1200m
=== RUN   TestAccAWSInstancesDataSource_basic
=== PAUSE TestAccAWSInstancesDataSource_basic
=== RUN   TestAccAWSInstancesDataSource_tags
=== PAUSE TestAccAWSInstancesDataSource_tags
=== RUN   TestAccAWSInstancesDataSource_instance_state_names
=== PAUSE TestAccAWSInstancesDataSource_instance_state_names
=== CONT  TestAccAWSInstancesDataSource_basic
=== CONT  TestAccAWSInstancesDataSource_instance_state_names
--- SKIP: TestAccAWSInstancesDataSource_basic (1.91s)
    provider_test.go:267: This test can only in regions without EC2 Classic, platforms available in us-east-1: ["EC2" "VPC"]
=== CONT  TestAccAWSInstancesDataSource_tags
--- SKIP: TestAccAWSInstancesDataSource_instance_state_names (1.97s)
    provider_test.go:267: This test can only in regions without EC2 Classic, platforms available in us-east-1: ["EC2" "VPC"]
--- SKIP: TestAccAWSInstancesDataSource_tags (1.67s)
    provider_test.go:267: This test can only in regions without EC2 Classic, platforms available in us-east-1: ["EC2" "VPC"]
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	3.613s
# eu-west-1; No default VPC:
$ AWS_DEFAULT_REGION=eu-west-1 make testacc TEST=./aws TESTARGS='-run=TestAccAWSInstancesDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSInstancesDataSource_ -timeout 1200m
=== RUN   TestAccAWSInstancesDataSource_basic
=== PAUSE TestAccAWSInstancesDataSource_basic
=== RUN   TestAccAWSInstancesDataSource_tags
=== PAUSE TestAccAWSInstancesDataSource_tags
=== RUN   TestAccAWSInstancesDataSource_instance_state_names
=== PAUSE TestAccAWSInstancesDataSource_instance_state_names
=== CONT  TestAccAWSInstancesDataSource_basic
=== CONT  TestAccAWSInstancesDataSource_instance_state_names
--- SKIP: TestAccAWSInstancesDataSource_basic (2.85s)
    resource_aws_instance_test.go:4101: skipping tests; eu-west-1 does not have a default VPC
=== CONT  TestAccAWSInstancesDataSource_tags
--- SKIP: TestAccAWSInstancesDataSource_instance_state_names (2.86s)
    resource_aws_instance_test.go:4101: skipping tests; eu-west-1 does not have a default VPC
--- SKIP: TestAccAWSInstancesDataSource_tags (2.45s)
    resource_aws_instance_test.go:4101: skipping tests; eu-west-1 does not have a default VPC
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	5.328s

@ewbankkit
Copy link
Contributor Author

ewbankkit commented Dec 5, 2019

Acceptance test results.

Resource:

# Default acceptance test region (us-west-2):
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSInstance_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSInstance_ -timeout 1200m
=== RUN   TestAccAWSInstance_inDefaultVpcBySgName
=== PAUSE TestAccAWSInstance_inDefaultVpcBySgName
=== RUN   TestAccAWSInstance_inDefaultVpcBySgId
=== PAUSE TestAccAWSInstance_inDefaultVpcBySgId
=== RUN   TestAccAWSInstance_inEc2Classic
=== PAUSE TestAccAWSInstance_inEc2Classic
=== RUN   TestAccAWSInstance_basic
=== PAUSE TestAccAWSInstance_basic
=== RUN   TestAccAWSInstance_atLeastOneOtherEbsVolume
=== PAUSE TestAccAWSInstance_atLeastOneOtherEbsVolume
=== RUN   TestAccAWSInstance_EbsBlockDevice_KmsKeyArn
=== PAUSE TestAccAWSInstance_EbsBlockDevice_KmsKeyArn
=== RUN   TestAccAWSInstance_RootBlockDevice_KmsKeyArn
=== PAUSE TestAccAWSInstance_RootBlockDevice_KmsKeyArn
=== RUN   TestAccAWSInstance_userDataBase64
=== PAUSE TestAccAWSInstance_userDataBase64
=== RUN   TestAccAWSInstance_GP2IopsDevice
=== PAUSE TestAccAWSInstance_GP2IopsDevice
=== RUN   TestAccAWSInstance_GP2WithIopsValue
=== PAUSE TestAccAWSInstance_GP2WithIopsValue
=== RUN   TestAccAWSInstance_blockDevices
=== PAUSE TestAccAWSInstance_blockDevices
=== RUN   TestAccAWSInstance_rootInstanceStore
=== PAUSE TestAccAWSInstance_rootInstanceStore
=== RUN   TestAccAWSInstance_noAMIEphemeralDevices
=== PAUSE TestAccAWSInstance_noAMIEphemeralDevices
=== RUN   TestAccAWSInstance_sourceDestCheck
=== PAUSE TestAccAWSInstance_sourceDestCheck
=== RUN   TestAccAWSInstance_disableApiTermination
=== PAUSE TestAccAWSInstance_disableApiTermination
=== RUN   TestAccAWSInstance_vpc
=== PAUSE TestAccAWSInstance_vpc
=== RUN   TestAccAWSInstance_placementGroup
=== PAUSE TestAccAWSInstance_placementGroup
=== RUN   TestAccAWSInstance_ipv6_supportAddressCount
=== PAUSE TestAccAWSInstance_ipv6_supportAddressCount
=== RUN   TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError
=== PAUSE TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError
=== RUN   TestAccAWSInstance_ipv6_supportAddressCountWithIpv4
=== PAUSE TestAccAWSInstance_ipv6_supportAddressCountWithIpv4
=== RUN   TestAccAWSInstance_NetworkInstanceSecurityGroups
=== PAUSE TestAccAWSInstance_NetworkInstanceSecurityGroups
=== RUN   TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups
=== PAUSE TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups
=== RUN   TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs
=== PAUSE TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs
=== RUN   TestAccAWSInstance_tags
=== PAUSE TestAccAWSInstance_tags
=== RUN   TestAccAWSInstance_volumeTags
=== PAUSE TestAccAWSInstance_volumeTags
=== RUN   TestAccAWSInstance_volumeTagsComputed
=== PAUSE TestAccAWSInstance_volumeTagsComputed
=== RUN   TestAccAWSInstance_instanceProfileChange
=== PAUSE TestAccAWSInstance_instanceProfileChange
=== RUN   TestAccAWSInstance_withIamInstanceProfile
=== PAUSE TestAccAWSInstance_withIamInstanceProfile
=== RUN   TestAccAWSInstance_privateIP
=== PAUSE TestAccAWSInstance_privateIP
=== RUN   TestAccAWSInstance_associatePublicIPAndPrivateIP
=== PAUSE TestAccAWSInstance_associatePublicIPAndPrivateIP
=== RUN   TestAccAWSInstance_keyPairCheck
=== PAUSE TestAccAWSInstance_keyPairCheck
=== RUN   TestAccAWSInstance_rootBlockDeviceMismatch
=== PAUSE TestAccAWSInstance_rootBlockDeviceMismatch
=== RUN   TestAccAWSInstance_forceNewAndTagsDrift
=== PAUSE TestAccAWSInstance_forceNewAndTagsDrift
=== RUN   TestAccAWSInstance_changeInstanceType
=== PAUSE TestAccAWSInstance_changeInstanceType
=== RUN   TestAccAWSInstance_primaryNetworkInterface
=== PAUSE TestAccAWSInstance_primaryNetworkInterface
=== RUN   TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck
=== PAUSE TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck
=== RUN   TestAccAWSInstance_addSecondaryInterface
=== PAUSE TestAccAWSInstance_addSecondaryInterface
=== RUN   TestAccAWSInstance_addSecurityGroupNetworkInterface
=== PAUSE TestAccAWSInstance_addSecurityGroupNetworkInterface
=== RUN   TestAccAWSInstance_associatePublic_defaultPrivate
=== PAUSE TestAccAWSInstance_associatePublic_defaultPrivate
=== RUN   TestAccAWSInstance_associatePublic_defaultPublic
=== PAUSE TestAccAWSInstance_associatePublic_defaultPublic
=== RUN   TestAccAWSInstance_associatePublic_explicitPublic
=== PAUSE TestAccAWSInstance_associatePublic_explicitPublic
=== RUN   TestAccAWSInstance_associatePublic_explicitPrivate
=== PAUSE TestAccAWSInstance_associatePublic_explicitPrivate
=== RUN   TestAccAWSInstance_associatePublic_overridePublic
=== PAUSE TestAccAWSInstance_associatePublic_overridePublic
=== RUN   TestAccAWSInstance_associatePublic_overridePrivate
=== PAUSE TestAccAWSInstance_associatePublic_overridePrivate
=== RUN   TestAccAWSInstance_getPasswordData_falseToTrue
=== PAUSE TestAccAWSInstance_getPasswordData_falseToTrue
=== RUN   TestAccAWSInstance_getPasswordData_trueToFalse
=== PAUSE TestAccAWSInstance_getPasswordData_trueToFalse
=== RUN   TestAccAWSInstance_CreditSpecification_Empty_NonBurstable
=== PAUSE TestAccAWSInstance_CreditSpecification_Empty_NonBurstable
=== RUN   TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable
=== PAUSE TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable
=== RUN   TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard
=== PAUSE TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard
=== RUN   TestAccAWSInstance_creditSpecification_standardCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecification_standardCpuCredits
=== RUN   TestAccAWSInstance_creditSpecification_unlimitedCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecification_unlimitedCpuCredits
=== RUN   TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2
=== PAUSE TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2
=== RUN   TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3
=== PAUSE TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3
=== RUN   TestAccAWSInstance_creditSpecification_updateCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecification_updateCpuCredits
=== RUN   TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable
=== PAUSE TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable
=== RUN   TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited
=== PAUSE TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited
=== RUN   TestAccAWSInstance_creditSpecificationT3_standardCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecificationT3_standardCpuCredits
=== RUN   TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits
=== RUN   TestAccAWSInstance_creditSpecificationT3_updateCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecificationT3_updateCpuCredits
=== RUN   TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint
=== PAUSE TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint
=== RUN   TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint
=== PAUSE TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint
=== RUN   TestAccAWSInstance_disappears
=== PAUSE TestAccAWSInstance_disappears
=== RUN   TestAccAWSInstance_UserData_EmptyStringToUnspecified
=== PAUSE TestAccAWSInstance_UserData_EmptyStringToUnspecified
=== RUN   TestAccAWSInstance_UserData_UnspecifiedToEmptyString
=== PAUSE TestAccAWSInstance_UserData_UnspecifiedToEmptyString
=== CONT  TestAccAWSInstance_inDefaultVpcBySgId
=== CONT  TestAccAWSInstance_primaryNetworkInterface
--- PASS: TestAccAWSInstance_inDefaultVpcBySgId (110.18s)
=== CONT  TestAccAWSInstance_inDefaultVpcBySgName
--- PASS: TestAccAWSInstance_primaryNetworkInterface (114.34s)
=== CONT  TestAccAWSInstance_UserData_UnspecifiedToEmptyString
--- PASS: TestAccAWSInstance_inDefaultVpcBySgName (110.21s)
=== CONT  TestAccAWSInstance_UserData_EmptyStringToUnspecified
--- PASS: TestAccAWSInstance_UserData_UnspecifiedToEmptyString (134.44s)
=== CONT  TestAccAWSInstance_disappears
--- PASS: TestAccAWSInstance_disappears (106.12s)
=== CONT  TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint
--- PASS: TestAccAWSInstance_UserData_EmptyStringToUnspecified (139.74s)
=== CONT  TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint (197.61s)
=== CONT  TestAccAWSInstance_creditSpecificationT3_updateCpuCredits
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint (197.70s)
=== CONT  TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits
--- PASS: TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits (121.75s)
=== CONT  TestAccAWSInstance_creditSpecificationT3_standardCpuCredits
--- PASS: TestAccAWSInstance_creditSpecificationT3_updateCpuCredits (178.89s)
=== CONT  TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited
--- PASS: TestAccAWSInstance_creditSpecificationT3_standardCpuCredits (132.17s)
=== CONT  TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable
--- PASS: TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited (99.11s)
=== CONT  TestAccAWSInstance_creditSpecification_updateCpuCredits
--- PASS: TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable (137.03s)
=== CONT  TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3
--- PASS: TestAccAWSInstance_creditSpecification_updateCpuCredits (190.28s)
=== CONT  TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3 (120.43s)
=== CONT  TestAccAWSInstance_creditSpecification_unlimitedCpuCredits
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2 (119.37s)
=== CONT  TestAccAWSInstance_creditSpecification_standardCpuCredits
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits (160.84s)
=== CONT  TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits (181.43s)
=== CONT  TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable
--- PASS: TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard (118.35s)
=== CONT  TestAccAWSInstance_CreditSpecification_Empty_NonBurstable
--- PASS: TestAccAWSInstance_CreditSpecification_Empty_NonBurstable (120.94s)
=== CONT  TestAccAWSInstance_getPasswordData_trueToFalse
--- PASS: TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable (168.22s)
=== CONT  TestAccAWSInstance_getPasswordData_falseToTrue
--- PASS: TestAccAWSInstance_getPasswordData_falseToTrue (175.68s)
=== CONT  TestAccAWSInstance_associatePublic_overridePrivate
--- PASS: TestAccAWSInstance_getPasswordData_trueToFalse (215.88s)
=== CONT  TestAccAWSInstance_associatePublic_overridePublic
--- PASS: TestAccAWSInstance_associatePublic_overridePrivate (118.23s)
=== CONT  TestAccAWSInstance_associatePublic_explicitPrivate
--- PASS: TestAccAWSInstance_associatePublic_overridePublic (129.70s)
=== CONT  TestAccAWSInstance_associatePublic_explicitPublic
--- PASS: TestAccAWSInstance_associatePublic_explicitPrivate (121.06s)
=== CONT  TestAccAWSInstance_associatePublic_defaultPublic
--- PASS: TestAccAWSInstance_associatePublic_explicitPublic (120.27s)
=== CONT  TestAccAWSInstance_associatePublic_defaultPrivate
--- PASS: TestAccAWSInstance_associatePublic_defaultPublic (118.73s)
=== CONT  TestAccAWSInstance_addSecurityGroupNetworkInterface
--- PASS: TestAccAWSInstance_associatePublic_defaultPrivate (109.65s)
=== CONT  TestAccAWSInstance_addSecondaryInterface
--- PASS: TestAccAWSInstance_addSecurityGroupNetworkInterface (181.94s)
=== CONT  TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck
--- PASS: TestAccAWSInstance_addSecondaryInterface (167.10s)
=== CONT  TestAccAWSInstance_changeInstanceType
--- PASS: TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck (134.24s)
=== CONT  TestAccAWSInstance_forceNewAndTagsDrift
--- PASS: TestAccAWSInstance_changeInstanceType (167.52s)
=== CONT  TestAccAWSInstance_rootBlockDeviceMismatch
--- PASS: TestAccAWSInstance_forceNewAndTagsDrift (141.33s)
=== CONT  TestAccAWSInstance_keyPairCheck
--- PASS: TestAccAWSInstance_rootBlockDeviceMismatch (106.26s)
=== CONT  TestAccAWSInstance_associatePublicIPAndPrivateIP
--- PASS: TestAccAWSInstance_keyPairCheck (92.80s)
=== CONT  TestAccAWSInstance_privateIP
--- PASS: TestAccAWSInstance_associatePublicIPAndPrivateIP (119.15s)
=== CONT  TestAccAWSInstance_withIamInstanceProfile
--- PASS: TestAccAWSInstance_privateIP (118.50s)
=== CONT  TestAccAWSInstance_instanceProfileChange
--- PASS: TestAccAWSInstance_withIamInstanceProfile (135.83s)
=== CONT  TestAccAWSInstance_volumeTagsComputed
--- PASS: TestAccAWSInstance_instanceProfileChange (171.76s)
=== CONT  TestAccAWSInstance_volumeTags
--- PASS: TestAccAWSInstance_volumeTagsComputed (151.53s)
=== CONT  TestAccAWSInstance_tags
--- PASS: TestAccAWSInstance_volumeTags (188.84s)
=== CONT  TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs
--- PASS: TestAccAWSInstance_tags (164.24s)
=== CONT  TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups
--- PASS: TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs (123.17s)
=== CONT  TestAccAWSInstance_NetworkInstanceSecurityGroups
--- PASS: TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups (143.19s)
=== CONT  TestAccAWSInstance_ipv6_supportAddressCountWithIpv4
--- PASS: TestAccAWSInstance_NetworkInstanceSecurityGroups (123.87s)
=== CONT  TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError
--- PASS: TestAccAWSInstance_ipv6_supportAddressCountWithIpv4 (119.90s)
=== CONT  TestAccAWSInstance_ipv6_supportAddressCount
--- PASS: TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError (32.26s)
=== CONT  TestAccAWSInstance_placementGroup
--- PASS: TestAccAWSInstance_placementGroup (100.74s)
=== CONT  TestAccAWSInstance_vpc
--- PASS: TestAccAWSInstance_ipv6_supportAddressCount (119.93s)
=== CONT  TestAccAWSInstance_disableApiTermination
--- PASS: TestAccAWSInstance_vpc (116.29s)
=== CONT  TestAccAWSInstance_sourceDestCheck
--- PASS: TestAccAWSInstance_disableApiTermination (233.57s)
=== CONT  TestAccAWSInstance_noAMIEphemeralDevices
--- PASS: TestAccAWSInstance_sourceDestCheck (203.75s)
=== CONT  TestAccAWSInstance_rootInstanceStore
--- PASS: TestAccAWSInstance_rootInstanceStore (108.94s)
=== CONT  TestAccAWSInstance_blockDevices
--- PASS: TestAccAWSInstance_noAMIEphemeralDevices (245.90s)
=== CONT  TestAccAWSInstance_GP2WithIopsValue
--- PASS: TestAccAWSInstance_blockDevices (113.15s)
=== CONT  TestAccAWSInstance_GP2IopsDevice
--- PASS: TestAccAWSInstance_GP2WithIopsValue (124.87s)
=== CONT  TestAccAWSInstance_userDataBase64
--- PASS: TestAccAWSInstance_GP2IopsDevice (101.07s)
=== CONT  TestAccAWSInstance_RootBlockDevice_KmsKeyArn
--- PASS: TestAccAWSInstance_userDataBase64 (132.30s)
=== CONT  TestAccAWSInstance_EbsBlockDevice_KmsKeyArn
--- PASS: TestAccAWSInstance_RootBlockDevice_KmsKeyArn (159.12s)
=== CONT  TestAccAWSInstance_atLeastOneOtherEbsVolume
--- PASS: TestAccAWSInstance_EbsBlockDevice_KmsKeyArn (127.06s)
=== CONT  TestAccAWSInstance_basic
--- PASS: TestAccAWSInstance_atLeastOneOtherEbsVolume (166.49s)
=== CONT  TestAccAWSInstance_inEc2Classic
--- SKIP: TestAccAWSInstance_inEc2Classic (2.07s)
    provider_test.go:257: This test can only run in EC2 Classic, platforms available in us-west-2: ["VPC"]
--- PASS: TestAccAWSInstance_basic (131.71s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	4435.021s
# us-east-1; EC2-Classic:
$ AWS_DEFAULT_REGION=us-east-1 make testacc TEST=./aws TESTARGS='-run=TestAccAWSInstance_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSInstance_ -timeout 1200m
=== RUN   TestAccAWSInstance_inDefaultVpcBySgName
=== PAUSE TestAccAWSInstance_inDefaultVpcBySgName
=== RUN   TestAccAWSInstance_inDefaultVpcBySgId
=== PAUSE TestAccAWSInstance_inDefaultVpcBySgId
=== RUN   TestAccAWSInstance_inEc2Classic
=== PAUSE TestAccAWSInstance_inEc2Classic
=== RUN   TestAccAWSInstance_basic
=== PAUSE TestAccAWSInstance_basic
=== RUN   TestAccAWSInstance_atLeastOneOtherEbsVolume
=== PAUSE TestAccAWSInstance_atLeastOneOtherEbsVolume
=== RUN   TestAccAWSInstance_EbsBlockDevice_KmsKeyArn
=== PAUSE TestAccAWSInstance_EbsBlockDevice_KmsKeyArn
=== RUN   TestAccAWSInstance_RootBlockDevice_KmsKeyArn
=== PAUSE TestAccAWSInstance_RootBlockDevice_KmsKeyArn
=== RUN   TestAccAWSInstance_userDataBase64
=== PAUSE TestAccAWSInstance_userDataBase64
=== RUN   TestAccAWSInstance_GP2IopsDevice
=== PAUSE TestAccAWSInstance_GP2IopsDevice
=== RUN   TestAccAWSInstance_GP2WithIopsValue
=== PAUSE TestAccAWSInstance_GP2WithIopsValue
=== RUN   TestAccAWSInstance_blockDevices
=== PAUSE TestAccAWSInstance_blockDevices
=== RUN   TestAccAWSInstance_rootInstanceStore
=== PAUSE TestAccAWSInstance_rootInstanceStore
=== RUN   TestAccAWSInstance_noAMIEphemeralDevices
=== PAUSE TestAccAWSInstance_noAMIEphemeralDevices
=== RUN   TestAccAWSInstance_sourceDestCheck
=== PAUSE TestAccAWSInstance_sourceDestCheck
=== RUN   TestAccAWSInstance_disableApiTermination
=== PAUSE TestAccAWSInstance_disableApiTermination
=== RUN   TestAccAWSInstance_vpc
=== PAUSE TestAccAWSInstance_vpc
=== RUN   TestAccAWSInstance_placementGroup
=== PAUSE TestAccAWSInstance_placementGroup
=== RUN   TestAccAWSInstance_ipv6_supportAddressCount
=== PAUSE TestAccAWSInstance_ipv6_supportAddressCount
=== RUN   TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError
=== PAUSE TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError
=== RUN   TestAccAWSInstance_ipv6_supportAddressCountWithIpv4
=== PAUSE TestAccAWSInstance_ipv6_supportAddressCountWithIpv4
=== RUN   TestAccAWSInstance_NetworkInstanceSecurityGroups
=== PAUSE TestAccAWSInstance_NetworkInstanceSecurityGroups
=== RUN   TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups
=== PAUSE TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups
=== RUN   TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs
=== PAUSE TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs
=== RUN   TestAccAWSInstance_tags
=== PAUSE TestAccAWSInstance_tags
=== RUN   TestAccAWSInstance_volumeTags
=== PAUSE TestAccAWSInstance_volumeTags
=== RUN   TestAccAWSInstance_volumeTagsComputed
=== PAUSE TestAccAWSInstance_volumeTagsComputed
=== RUN   TestAccAWSInstance_instanceProfileChange
=== PAUSE TestAccAWSInstance_instanceProfileChange
=== RUN   TestAccAWSInstance_withIamInstanceProfile
=== PAUSE TestAccAWSInstance_withIamInstanceProfile
=== RUN   TestAccAWSInstance_privateIP
=== PAUSE TestAccAWSInstance_privateIP
=== RUN   TestAccAWSInstance_associatePublicIPAndPrivateIP
=== PAUSE TestAccAWSInstance_associatePublicIPAndPrivateIP
=== RUN   TestAccAWSInstance_keyPairCheck
=== PAUSE TestAccAWSInstance_keyPairCheck
=== RUN   TestAccAWSInstance_rootBlockDeviceMismatch
=== PAUSE TestAccAWSInstance_rootBlockDeviceMismatch
=== RUN   TestAccAWSInstance_forceNewAndTagsDrift
=== PAUSE TestAccAWSInstance_forceNewAndTagsDrift
=== RUN   TestAccAWSInstance_changeInstanceType
=== PAUSE TestAccAWSInstance_changeInstanceType
=== RUN   TestAccAWSInstance_primaryNetworkInterface
=== PAUSE TestAccAWSInstance_primaryNetworkInterface
=== RUN   TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck
=== PAUSE TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck
=== RUN   TestAccAWSInstance_addSecondaryInterface
=== PAUSE TestAccAWSInstance_addSecondaryInterface
=== RUN   TestAccAWSInstance_addSecurityGroupNetworkInterface
=== PAUSE TestAccAWSInstance_addSecurityGroupNetworkInterface
=== RUN   TestAccAWSInstance_associatePublic_defaultPrivate
=== PAUSE TestAccAWSInstance_associatePublic_defaultPrivate
=== RUN   TestAccAWSInstance_associatePublic_defaultPublic
=== PAUSE TestAccAWSInstance_associatePublic_defaultPublic
=== RUN   TestAccAWSInstance_associatePublic_explicitPublic
=== PAUSE TestAccAWSInstance_associatePublic_explicitPublic
=== RUN   TestAccAWSInstance_associatePublic_explicitPrivate
=== PAUSE TestAccAWSInstance_associatePublic_explicitPrivate
=== RUN   TestAccAWSInstance_associatePublic_overridePublic
=== PAUSE TestAccAWSInstance_associatePublic_overridePublic
=== RUN   TestAccAWSInstance_associatePublic_overridePrivate
=== PAUSE TestAccAWSInstance_associatePublic_overridePrivate
=== RUN   TestAccAWSInstance_getPasswordData_falseToTrue
=== PAUSE TestAccAWSInstance_getPasswordData_falseToTrue
=== RUN   TestAccAWSInstance_getPasswordData_trueToFalse
=== PAUSE TestAccAWSInstance_getPasswordData_trueToFalse
=== RUN   TestAccAWSInstance_CreditSpecification_Empty_NonBurstable
=== PAUSE TestAccAWSInstance_CreditSpecification_Empty_NonBurstable
=== RUN   TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable
=== PAUSE TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable
=== RUN   TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard
=== PAUSE TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard
=== RUN   TestAccAWSInstance_creditSpecification_standardCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecification_standardCpuCredits
=== RUN   TestAccAWSInstance_creditSpecification_unlimitedCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecification_unlimitedCpuCredits
=== RUN   TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2
=== PAUSE TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2
=== RUN   TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3
=== PAUSE TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3
=== RUN   TestAccAWSInstance_creditSpecification_updateCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecification_updateCpuCredits
=== RUN   TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable
=== PAUSE TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable
=== RUN   TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited
=== PAUSE TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited
=== RUN   TestAccAWSInstance_creditSpecificationT3_standardCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecificationT3_standardCpuCredits
=== RUN   TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits
=== RUN   TestAccAWSInstance_creditSpecificationT3_updateCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecificationT3_updateCpuCredits
=== RUN   TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint
=== PAUSE TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint
=== RUN   TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint
=== PAUSE TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint
=== RUN   TestAccAWSInstance_disappears
=== PAUSE TestAccAWSInstance_disappears
=== RUN   TestAccAWSInstance_UserData_EmptyStringToUnspecified
=== PAUSE TestAccAWSInstance_UserData_EmptyStringToUnspecified
=== RUN   TestAccAWSInstance_UserData_UnspecifiedToEmptyString
=== PAUSE TestAccAWSInstance_UserData_UnspecifiedToEmptyString
=== CONT  TestAccAWSInstance_inDefaultVpcBySgName
=== CONT  TestAccAWSInstance_changeInstanceType
--- SKIP: TestAccAWSInstance_inDefaultVpcBySgName (2.11s)
    resource_aws_instance_test.go:4454: skipping tests; us-east-1 does not have a default VPC
=== CONT  TestAccAWSInstance_UserData_UnspecifiedToEmptyString
--- FAIL: TestAccAWSInstance_changeInstanceType (103.31s)
    testing.go:635: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
        
        (map[string]string) {
        }
        
        
        (map[string]string) (len=1) {
         (string) (len=17) "source_dest_check": (string) (len=4) "true"
        }
        
=== CONT  TestAccAWSInstance_UserData_EmptyStringToUnspecified
--- PASS: TestAccAWSInstance_UserData_UnspecifiedToEmptyString (124.05s)
=== CONT  TestAccAWSInstance_disappears
--- PASS: TestAccAWSInstance_UserData_EmptyStringToUnspecified (119.92s)
=== CONT  TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint
--- PASS: TestAccAWSInstance_disappears (109.34s)
=== CONT  TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint (166.06s)
=== CONT  TestAccAWSInstance_creditSpecificationT3_updateCpuCredits
--- PASS: TestAccAWSInstance_creditSpecificationT3_updateCpuCredits (121.44s)
=== CONT  TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint (378.28s)
=== CONT  TestAccAWSInstance_creditSpecificationT3_standardCpuCredits
--- PASS: TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits (104.73s)
=== CONT  TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited
--- PASS: TestAccAWSInstance_creditSpecificationT3_standardCpuCredits (95.51s)
=== CONT  TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable
--- PASS: TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable (122.29s)
=== CONT  TestAccAWSInstance_creditSpecification_updateCpuCredits
--- PASS: TestAccAWSInstance_creditSpecification_updateCpuCredits (132.84s)
=== CONT  TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3
--- PASS: TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited (326.62s)
=== CONT  TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3 (93.91s)
=== CONT  TestAccAWSInstance_creditSpecification_unlimitedCpuCredits
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2 (103.72s)
=== CONT  TestAccAWSInstance_creditSpecification_standardCpuCredits
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits (124.53s)
=== CONT  TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits (123.86s)
=== CONT  TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable
--- PASS: TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard (94.65s)
=== CONT  TestAccAWSInstance_CreditSpecification_Empty_NonBurstable
--- PASS: TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable (131.34s)
=== CONT  TestAccAWSInstance_getPasswordData_trueToFalse
--- SKIP: TestAccAWSInstance_getPasswordData_trueToFalse (1.59s)
    provider_test.go:267: This test can only in regions without EC2 Classic, platforms available in us-east-1: ["EC2" "VPC"]
=== CONT  TestAccAWSInstance_getPasswordData_falseToTrue
--- SKIP: TestAccAWSInstance_getPasswordData_falseToTrue (1.71s)
    provider_test.go:267: This test can only in regions without EC2 Classic, platforms available in us-east-1: ["EC2" "VPC"]
=== CONT  TestAccAWSInstance_associatePublic_overridePrivate
--- PASS: TestAccAWSInstance_CreditSpecification_Empty_NonBurstable (125.66s)
=== CONT  TestAccAWSInstance_associatePublic_overridePublic
--- PASS: TestAccAWSInstance_associatePublic_overridePrivate (90.82s)
=== CONT  TestAccAWSInstance_associatePublic_explicitPrivate
--- PASS: TestAccAWSInstance_associatePublic_overridePublic (101.45s)
=== CONT  TestAccAWSInstance_associatePublic_explicitPublic
--- PASS: TestAccAWSInstance_associatePublic_explicitPrivate (121.90s)
=== CONT  TestAccAWSInstance_associatePublic_defaultPublic
--- PASS: TestAccAWSInstance_associatePublic_explicitPublic (94.45s)
=== CONT  TestAccAWSInstance_associatePublic_defaultPrivate
--- PASS: TestAccAWSInstance_associatePublic_defaultPublic (93.06s)
=== CONT  TestAccAWSInstance_addSecurityGroupNetworkInterface
--- PASS: TestAccAWSInstance_associatePublic_defaultPrivate (102.81s)
=== CONT  TestAccAWSInstance_addSecondaryInterface
--- PASS: TestAccAWSInstance_addSecurityGroupNetworkInterface (157.30s)
=== CONT  TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck
--- PASS: TestAccAWSInstance_addSecondaryInterface (138.03s)
=== CONT  TestAccAWSInstance_primaryNetworkInterface
--- PASS: TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck (109.44s)
=== CONT  TestAccAWSInstance_ipv6_supportAddressCount
--- PASS: TestAccAWSInstance_primaryNetworkInterface (107.73s)
=== CONT  TestAccAWSInstance_forceNewAndTagsDrift
--- PASS: TestAccAWSInstance_ipv6_supportAddressCount (95.29s)
=== CONT  TestAccAWSInstance_rootBlockDeviceMismatch
--- SKIP: TestAccAWSInstance_rootBlockDeviceMismatch (1.73s)
    provider_test.go:291: skipping tests; AWS_DEFAULT_REGION (us-east-1) does not equal us-west-2
=== CONT  TestAccAWSInstance_keyPairCheck
--- PASS: TestAccAWSInstance_forceNewAndTagsDrift (115.27s)
=== CONT  TestAccAWSInstance_associatePublicIPAndPrivateIP
--- PASS: TestAccAWSInstance_keyPairCheck (84.01s)
=== CONT  TestAccAWSInstance_privateIP
--- PASS: TestAccAWSInstance_associatePublicIPAndPrivateIP (111.18s)
=== CONT  TestAccAWSInstance_withIamInstanceProfile
--- PASS: TestAccAWSInstance_privateIP (103.52s)
=== CONT  TestAccAWSInstance_instanceProfileChange
--- FAIL: TestAccAWSInstance_withIamInstanceProfile (133.37s)
    testing.go:635: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
        
        (map[string]string) {
        }
        
        
        (map[string]string) (len=1) {
         (string) (len=17) "source_dest_check": (string) (len=4) "true"
        }
        
=== CONT  TestAccAWSInstance_volumeTagsComputed
--- SKIP: TestAccAWSInstance_volumeTagsComputed (1.66s)
    provider_test.go:267: This test can only in regions without EC2 Classic, platforms available in us-east-1: ["EC2" "VPC"]
=== CONT  TestAccAWSInstance_volumeTags
--- FAIL: TestAccAWSInstance_instanceProfileChange (125.38s)
    testing.go:635: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
        
        (map[string]string) {
        }
        
        
        (map[string]string) (len=1) {
         (string) (len=17) "source_dest_check": (string) (len=4) "true"
        }
        
=== CONT  TestAccAWSInstance_tags
--- FAIL: TestAccAWSInstance_volumeTags (103.64s)
    testing.go:635: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
        
        (map[string]string) {
        }
        
        
        (map[string]string) (len=1) {
         (string) (len=17) "source_dest_check": (string) (len=4) "true"
        }
        
=== CONT  TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs
--- FAIL: TestAccAWSInstance_tags (126.04s)
    testing.go:635: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
        
        (map[string]string) {
        }
        
        
        (map[string]string) (len=1) {
         (string) (len=17) "source_dest_check": (string) (len=4) "true"
        }
        
=== CONT  TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups
--- PASS: TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs (96.40s)
=== CONT  TestAccAWSInstance_NetworkInstanceSecurityGroups
--- PASS: TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups (117.18s)
=== CONT  TestAccAWSInstance_ipv6_supportAddressCountWithIpv4
--- PASS: TestAccAWSInstance_NetworkInstanceSecurityGroups (96.98s)
=== CONT  TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError
--- PASS: TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError (25.02s)
=== CONT  TestAccAWSInstance_GP2WithIopsValue
--- PASS: TestAccAWSInstance_ipv6_supportAddressCountWithIpv4 (114.05s)
=== CONT  TestAccAWSInstance_placementGroup
--- FAIL: TestAccAWSInstance_GP2WithIopsValue (95.87s)
    testing.go:635: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
        
        (map[string]string) {
        }
        
        
        (map[string]string) (len=1) {
         (string) (len=17) "source_dest_check": (string) (len=4) "true"
        }
        
=== CONT  TestAccAWSInstance_vpc
--- PASS: TestAccAWSInstance_placementGroup (92.83s)
=== CONT  TestAccAWSInstance_disableApiTermination
--- PASS: TestAccAWSInstance_vpc (94.13s)
=== CONT  TestAccAWSInstance_sourceDestCheck
--- PASS: TestAccAWSInstance_disableApiTermination (133.26s)
=== CONT  TestAccAWSInstance_noAMIEphemeralDevices
--- FAIL: TestAccAWSInstance_noAMIEphemeralDevices (74.60s)
    testing.go:635: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
        
        (map[string]string) {
        }
        
        
        (map[string]string) (len=1) {
         (string) (len=17) "source_dest_check": (string) (len=4) "true"
        }
        
=== CONT  TestAccAWSInstance_rootInstanceStore
--- PASS: TestAccAWSInstance_sourceDestCheck (153.84s)
=== CONT  TestAccAWSInstance_blockDevices
--- FAIL: TestAccAWSInstance_blockDevices (96.36s)
    testing.go:635: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
        
        (map[string]string) {
        }
        
        
        (map[string]string) (len=1) {
         (string) (len=17) "source_dest_check": (string) (len=4) "true"
        }
        
=== CONT  TestAccAWSInstance_EbsBlockDevice_KmsKeyArn
--- FAIL: TestAccAWSInstance_rootInstanceStore (127.49s)
    testing.go:635: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
        
        (map[string]string) {
        }
        
        
        (map[string]string) (len=1) {
         (string) (len=17) "source_dest_check": (string) (len=4) "true"
        }
        
=== CONT  TestAccAWSInstance_GP2IopsDevice
--- FAIL: TestAccAWSInstance_GP2IopsDevice (85.67s)
    testing.go:635: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
        
        (map[string]string) {
        }
        
        
        (map[string]string) (len=1) {
         (string) (len=17) "source_dest_check": (string) (len=4) "true"
        }
        
=== CONT  TestAccAWSInstance_userDataBase64
--- PASS: TestAccAWSInstance_EbsBlockDevice_KmsKeyArn (120.16s)
=== CONT  TestAccAWSInstance_RootBlockDevice_KmsKeyArn
--- FAIL: TestAccAWSInstance_userDataBase64 (117.00s)
    testing.go:635: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
        
        (map[string]string) {
        }
        
        
        (map[string]string) (len=1) {
         (string) (len=17) "source_dest_check": (string) (len=4) "true"
        }
        
=== CONT  TestAccAWSInstance_basic
--- PASS: TestAccAWSInstance_RootBlockDevice_KmsKeyArn (146.82s)
=== CONT  TestAccAWSInstance_atLeastOneOtherEbsVolume
--- FAIL: TestAccAWSInstance_basic (125.10s)
    testing.go:635: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
        
        (map[string]string) {
        }
        
        
        (map[string]string) (len=1) {
         (string) (len=17) "source_dest_check": (string) (len=4) "true"
        }
        
=== CONT  TestAccAWSInstance_inEc2Classic
--- FAIL: TestAccAWSInstance_atLeastOneOtherEbsVolume (122.95s)
    testing.go:635: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
        
        (map[string]string) {
        }
        
        
        (map[string]string) (len=1) {
         (string) (len=17) "source_dest_check": (string) (len=4) "true"
        }
        
=== CONT  TestAccAWSInstance_inDefaultVpcBySgId
--- SKIP: TestAccAWSInstance_inDefaultVpcBySgId (1.85s)
    resource_aws_instance_test.go:4454: skipping tests; us-east-1 does not have a default VPC
--- PASS: TestAccAWSInstance_inEc2Classic (85.95s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	3498.267s
FAIL
GNUmakefile:24: recipe for target 'testacc' failed
make: *** [testacc] Error 1
# us-east-2:
$ AWS_DEFAULT_REGION=us-east-2 make testacc TEST=./aws TESTARGS='-run=TestAccAWSInstance_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSInstance_ -timeout 1200m
=== RUN   TestAccAWSInstance_inDefaultVpcBySgName
=== PAUSE TestAccAWSInstance_inDefaultVpcBySgName
=== RUN   TestAccAWSInstance_inDefaultVpcBySgId
=== PAUSE TestAccAWSInstance_inDefaultVpcBySgId
=== RUN   TestAccAWSInstance_inEc2Classic
=== PAUSE TestAccAWSInstance_inEc2Classic
=== RUN   TestAccAWSInstance_basic
=== PAUSE TestAccAWSInstance_basic
=== RUN   TestAccAWSInstance_atLeastOneOtherEbsVolume
=== PAUSE TestAccAWSInstance_atLeastOneOtherEbsVolume
=== RUN   TestAccAWSInstance_EbsBlockDevice_KmsKeyArn
=== PAUSE TestAccAWSInstance_EbsBlockDevice_KmsKeyArn
=== RUN   TestAccAWSInstance_RootBlockDevice_KmsKeyArn
=== PAUSE TestAccAWSInstance_RootBlockDevice_KmsKeyArn
=== RUN   TestAccAWSInstance_userDataBase64
=== PAUSE TestAccAWSInstance_userDataBase64
=== RUN   TestAccAWSInstance_GP2IopsDevice
=== PAUSE TestAccAWSInstance_GP2IopsDevice
=== RUN   TestAccAWSInstance_GP2WithIopsValue
=== PAUSE TestAccAWSInstance_GP2WithIopsValue
=== RUN   TestAccAWSInstance_blockDevices
=== PAUSE TestAccAWSInstance_blockDevices
=== RUN   TestAccAWSInstance_rootInstanceStore
=== PAUSE TestAccAWSInstance_rootInstanceStore
=== RUN   TestAccAWSInstance_noAMIEphemeralDevices
=== PAUSE TestAccAWSInstance_noAMIEphemeralDevices
=== RUN   TestAccAWSInstance_sourceDestCheck
=== PAUSE TestAccAWSInstance_sourceDestCheck
=== RUN   TestAccAWSInstance_disableApiTermination
=== PAUSE TestAccAWSInstance_disableApiTermination
=== RUN   TestAccAWSInstance_vpc
=== PAUSE TestAccAWSInstance_vpc
=== RUN   TestAccAWSInstance_placementGroup
=== PAUSE TestAccAWSInstance_placementGroup
=== RUN   TestAccAWSInstance_ipv6_supportAddressCount
=== PAUSE TestAccAWSInstance_ipv6_supportAddressCount
=== RUN   TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError
=== PAUSE TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError
=== RUN   TestAccAWSInstance_ipv6_supportAddressCountWithIpv4
=== PAUSE TestAccAWSInstance_ipv6_supportAddressCountWithIpv4
=== RUN   TestAccAWSInstance_NetworkInstanceSecurityGroups
=== PAUSE TestAccAWSInstance_NetworkInstanceSecurityGroups
=== RUN   TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups
=== PAUSE TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups
=== RUN   TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs
=== PAUSE TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs
=== RUN   TestAccAWSInstance_tags
=== PAUSE TestAccAWSInstance_tags
=== RUN   TestAccAWSInstance_volumeTags
=== PAUSE TestAccAWSInstance_volumeTags
=== RUN   TestAccAWSInstance_volumeTagsComputed
=== PAUSE TestAccAWSInstance_volumeTagsComputed
=== RUN   TestAccAWSInstance_instanceProfileChange
=== PAUSE TestAccAWSInstance_instanceProfileChange
=== RUN   TestAccAWSInstance_withIamInstanceProfile
=== PAUSE TestAccAWSInstance_withIamInstanceProfile
=== RUN   TestAccAWSInstance_privateIP
=== PAUSE TestAccAWSInstance_privateIP
=== RUN   TestAccAWSInstance_associatePublicIPAndPrivateIP
=== PAUSE TestAccAWSInstance_associatePublicIPAndPrivateIP
=== RUN   TestAccAWSInstance_keyPairCheck
=== PAUSE TestAccAWSInstance_keyPairCheck
=== RUN   TestAccAWSInstance_rootBlockDeviceMismatch
=== PAUSE TestAccAWSInstance_rootBlockDeviceMismatch
=== RUN   TestAccAWSInstance_forceNewAndTagsDrift
=== PAUSE TestAccAWSInstance_forceNewAndTagsDrift
=== RUN   TestAccAWSInstance_changeInstanceType
=== PAUSE TestAccAWSInstance_changeInstanceType
=== RUN   TestAccAWSInstance_primaryNetworkInterface
=== PAUSE TestAccAWSInstance_primaryNetworkInterface
=== RUN   TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck
=== PAUSE TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck
=== RUN   TestAccAWSInstance_addSecondaryInterface
=== PAUSE TestAccAWSInstance_addSecondaryInterface
=== RUN   TestAccAWSInstance_addSecurityGroupNetworkInterface
=== PAUSE TestAccAWSInstance_addSecurityGroupNetworkInterface
=== RUN   TestAccAWSInstance_associatePublic_defaultPrivate
=== PAUSE TestAccAWSInstance_associatePublic_defaultPrivate
=== RUN   TestAccAWSInstance_associatePublic_defaultPublic
=== PAUSE TestAccAWSInstance_associatePublic_defaultPublic
=== RUN   TestAccAWSInstance_associatePublic_explicitPublic
=== PAUSE TestAccAWSInstance_associatePublic_explicitPublic
=== RUN   TestAccAWSInstance_associatePublic_explicitPrivate
=== PAUSE TestAccAWSInstance_associatePublic_explicitPrivate
=== RUN   TestAccAWSInstance_associatePublic_overridePublic
=== PAUSE TestAccAWSInstance_associatePublic_overridePublic
=== RUN   TestAccAWSInstance_associatePublic_overridePrivate
=== PAUSE TestAccAWSInstance_associatePublic_overridePrivate
=== RUN   TestAccAWSInstance_getPasswordData_falseToTrue
=== PAUSE TestAccAWSInstance_getPasswordData_falseToTrue
=== RUN   TestAccAWSInstance_getPasswordData_trueToFalse
=== PAUSE TestAccAWSInstance_getPasswordData_trueToFalse
=== RUN   TestAccAWSInstance_CreditSpecification_Empty_NonBurstable
=== PAUSE TestAccAWSInstance_CreditSpecification_Empty_NonBurstable
=== RUN   TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable
=== PAUSE TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable
=== RUN   TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard
=== PAUSE TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard
=== RUN   TestAccAWSInstance_creditSpecification_standardCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecification_standardCpuCredits
=== RUN   TestAccAWSInstance_creditSpecification_unlimitedCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecification_unlimitedCpuCredits
=== RUN   TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2
=== PAUSE TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2
=== RUN   TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3
=== PAUSE TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3
=== RUN   TestAccAWSInstance_creditSpecification_updateCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecification_updateCpuCredits
=== RUN   TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable
=== PAUSE TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable
=== RUN   TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited
=== PAUSE TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited
=== RUN   TestAccAWSInstance_creditSpecificationT3_standardCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecificationT3_standardCpuCredits
=== RUN   TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits
=== RUN   TestAccAWSInstance_creditSpecificationT3_updateCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecificationT3_updateCpuCredits
=== RUN   TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint
=== PAUSE TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint
=== RUN   TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint
=== PAUSE TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint
=== RUN   TestAccAWSInstance_disappears
=== PAUSE TestAccAWSInstance_disappears
=== RUN   TestAccAWSInstance_UserData_EmptyStringToUnspecified
=== PAUSE TestAccAWSInstance_UserData_EmptyStringToUnspecified
=== RUN   TestAccAWSInstance_UserData_UnspecifiedToEmptyString
=== PAUSE TestAccAWSInstance_UserData_UnspecifiedToEmptyString
=== CONT  TestAccAWSInstance_inDefaultVpcBySgName
=== CONT  TestAccAWSInstance_changeInstanceType
--- SKIP: TestAccAWSInstance_changeInstanceType (2.16s)
    resource_aws_instance_test.go:4443: skipping tests; us-east-2 does not offer EC2 instance type: m3.medium
=== CONT  TestAccAWSInstance_UserData_UnspecifiedToEmptyString
--- PASS: TestAccAWSInstance_inDefaultVpcBySgName (88.32s)
=== CONT  TestAccAWSInstance_UserData_EmptyStringToUnspecified
--- PASS: TestAccAWSInstance_UserData_UnspecifiedToEmptyString (106.93s)
=== CONT  TestAccAWSInstance_disappears
--- SKIP: TestAccAWSInstance_disappears (1.98s)
    resource_aws_instance_test.go:4443: skipping tests; us-east-2 does not offer EC2 instance type: m1.small
=== CONT  TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint
--- PASS: TestAccAWSInstance_UserData_EmptyStringToUnspecified (107.18s)
=== CONT  TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint (206.23s)
=== CONT  TestAccAWSInstance_creditSpecificationT3_updateCpuCredits
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint (173.83s)
=== CONT  TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits
--- PASS: TestAccAWSInstance_creditSpecificationT3_updateCpuCredits (161.68s)
=== CONT  TestAccAWSInstance_creditSpecificationT3_standardCpuCredits
--- PASS: TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits (132.48s)
=== CONT  TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited
--- PASS: TestAccAWSInstance_creditSpecificationT3_standardCpuCredits (111.99s)
=== CONT  TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable
--- SKIP: TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable (1.84s)
    resource_aws_instance_test.go:4443: skipping tests; us-east-2 does not offer EC2 instance type: m1.small
=== CONT  TestAccAWSInstance_creditSpecification_updateCpuCredits
--- PASS: TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited (93.36s)
=== CONT  TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3 (102.34s)
=== CONT  TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2
--- PASS: TestAccAWSInstance_creditSpecification_updateCpuCredits (140.03s)
=== CONT  TestAccAWSInstance_creditSpecification_unlimitedCpuCredits
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2 (81.43s)
=== CONT  TestAccAWSInstance_creditSpecification_standardCpuCredits
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits (110.49s)
=== CONT  TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits (111.00s)
=== CONT  TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable
--- PASS: TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard (91.77s)
=== CONT  TestAccAWSInstance_CreditSpecification_Empty_NonBurstable
--- PASS: TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable (123.22s)
=== CONT  TestAccAWSInstance_forceNewAndTagsDrift
--- PASS: TestAccAWSInstance_CreditSpecification_Empty_NonBurstable (102.22s)
=== CONT  TestAccAWSInstance_rootBlockDeviceMismatch
--- SKIP: TestAccAWSInstance_rootBlockDeviceMismatch (1.76s)
    provider_test.go:291: skipping tests; AWS_DEFAULT_REGION (us-east-2) does not equal us-west-2
=== CONT  TestAccAWSInstance_keyPairCheck
--- SKIP: TestAccAWSInstance_keyPairCheck (1.99s)
    resource_aws_instance_test.go:4443: skipping tests; us-east-2 does not offer EC2 instance type: t1.micro
=== CONT  TestAccAWSInstance_associatePublicIPAndPrivateIP
--- PASS: TestAccAWSInstance_forceNewAndTagsDrift (100.84s)
=== CONT  TestAccAWSInstance_privateIP
--- PASS: TestAccAWSInstance_associatePublicIPAndPrivateIP (103.15s)
=== CONT  TestAccAWSInstance_withIamInstanceProfile
--- SKIP: TestAccAWSInstance_withIamInstanceProfile (2.02s)
    resource_aws_instance_test.go:4443: skipping tests; us-east-2 does not offer EC2 instance type: m1.small
=== CONT  TestAccAWSInstance_instanceProfileChange
--- SKIP: TestAccAWSInstance_instanceProfileChange (1.96s)
    resource_aws_instance_test.go:4443: skipping tests; us-east-2 does not offer EC2 instance type: m1.small
=== CONT  TestAccAWSInstance_getPasswordData_trueToFalse
--- PASS: TestAccAWSInstance_privateIP (92.43s)
=== CONT  TestAccAWSInstance_volumeTagsComputed
--- PASS: TestAccAWSInstance_volumeTagsComputed (135.07s)
=== CONT  TestAccAWSInstance_getPasswordData_falseToTrue
--- PASS: TestAccAWSInstance_getPasswordData_trueToFalse (215.60s)
=== CONT  TestAccAWSInstance_volumeTags
--- SKIP: TestAccAWSInstance_volumeTags (1.81s)
    resource_aws_instance_test.go:4443: skipping tests; us-east-2 does not offer EC2 instance type: m3.medium
=== CONT  TestAccAWSInstance_associatePublic_overridePrivate
--- PASS: TestAccAWSInstance_associatePublic_overridePrivate (91.43s)
=== CONT  TestAccAWSInstance_tags
=== CONT  TestAccAWSInstance_associatePublic_overridePublic
--- SKIP: TestAccAWSInstance_tags (2.00s)
    resource_aws_instance_test.go:4443: skipping tests; us-east-2 does not offer EC2 instance type: m1.small
--- PASS: TestAccAWSInstance_getPasswordData_falseToTrue (164.25s)
=== CONT  TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs
--- SKIP: TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs (1.89s)
    resource_aws_instance_test.go:4443: skipping tests; us-east-2 does not offer EC2 instance type: t1.micro
=== CONT  TestAccAWSInstance_associatePublic_explicitPrivate
--- PASS: TestAccAWSInstance_associatePublic_overridePublic (101.83s)
=== CONT  TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups
--- SKIP: TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups (1.92s)
    resource_aws_instance_test.go:4443: skipping tests; us-east-2 does not offer EC2 instance type: t1.micro
=== CONT  TestAccAWSInstance_associatePublic_explicitPublic
--- PASS: TestAccAWSInstance_associatePublic_explicitPrivate (91.46s)
=== CONT  TestAccAWSInstance_NetworkInstanceSecurityGroups
--- SKIP: TestAccAWSInstance_NetworkInstanceSecurityGroups (1.90s)
    resource_aws_instance_test.go:4443: skipping tests; us-east-2 does not offer EC2 instance type: t1.micro
=== CONT  TestAccAWSInstance_associatePublic_defaultPublic
--- PASS: TestAccAWSInstance_associatePublic_explicitPublic (91.65s)
=== CONT  TestAccAWSInstance_ipv6_supportAddressCountWithIpv4
--- PASS: TestAccAWSInstance_associatePublic_defaultPublic (91.89s)
=== CONT  TestAccAWSInstance_associatePublic_defaultPrivate
--- PASS: TestAccAWSInstance_ipv6_supportAddressCountWithIpv4 (92.07s)
=== CONT  TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError
--- PASS: TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError (19.26s)
=== CONT  TestAccAWSInstance_addSecurityGroupNetworkInterface
--- PASS: TestAccAWSInstance_associatePublic_defaultPrivate (91.50s)
=== CONT  TestAccAWSInstance_ipv6_supportAddressCount
--- PASS: TestAccAWSInstance_ipv6_supportAddressCount (90.92s)
=== CONT  TestAccAWSInstance_addSecondaryInterface
--- PASS: TestAccAWSInstance_addSecurityGroupNetworkInterface (130.75s)
=== CONT  TestAccAWSInstance_placementGroup
--- SKIP: TestAccAWSInstance_placementGroup (1.71s)
    resource_aws_instance_test.go:4443: skipping tests; us-east-2 does not offer EC2 instance type: c3.large
=== CONT  TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck
--- PASS: TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck (94.87s)
=== CONT  TestAccAWSInstance_vpc
--- SKIP: TestAccAWSInstance_vpc (1.88s)
    resource_aws_instance_test.go:4443: skipping tests; us-east-2 does not offer EC2 instance type: m1.small
=== CONT  TestAccAWSInstance_primaryNetworkInterface
--- PASS: TestAccAWSInstance_addSecondaryInterface (121.06s)
=== CONT  TestAccAWSInstance_disableApiTermination
--- SKIP: TestAccAWSInstance_disableApiTermination (1.84s)
    resource_aws_instance_test.go:4443: skipping tests; us-east-2 does not offer EC2 instance type: m1.small
=== CONT  TestAccAWSInstance_RootBlockDevice_KmsKeyArn
--- PASS: TestAccAWSInstance_primaryNetworkInterface (104.29s)
=== CONT  TestAccAWSInstance_userDataBase64
--- SKIP: TestAccAWSInstance_userDataBase64 (2.02s)
    resource_aws_instance_test.go:4443: skipping tests; us-east-2 does not offer EC2 instance type: m1.small
=== CONT  TestAccAWSInstance_EbsBlockDevice_KmsKeyArn
--- SKIP: TestAccAWSInstance_EbsBlockDevice_KmsKeyArn (1.96s)
    resource_aws_instance_test.go:4443: skipping tests; us-east-2 does not offer EC2 instance type: m3.medium
=== CONT  TestAccAWSInstance_atLeastOneOtherEbsVolume
--- SKIP: TestAccAWSInstance_atLeastOneOtherEbsVolume (2.12s)
    resource_aws_instance_test.go:4443: skipping tests; us-east-2 does not offer EC2 instance type: m1.small
=== CONT  TestAccAWSInstance_sourceDestCheck
--- SKIP: TestAccAWSInstance_sourceDestCheck (1.75s)
    resource_aws_instance_test.go:4443: skipping tests; us-east-2 does not offer EC2 instance type: m1.small
=== CONT  TestAccAWSInstance_basic
--- SKIP: TestAccAWSInstance_basic (1.98s)
    resource_aws_instance_test.go:4443: skipping tests; us-east-2 does not offer EC2 instance type: m1.small
=== CONT  TestAccAWSInstance_noAMIEphemeralDevices
--- SKIP: TestAccAWSInstance_noAMIEphemeralDevices (1.93s)
    resource_aws_instance_test.go:4443: skipping tests; us-east-2 does not offer EC2 instance type: c3.large
=== CONT  TestAccAWSInstance_inEc2Classic
--- SKIP: TestAccAWSInstance_inEc2Classic (1.74s)
    provider_test.go:257: This test can only run in EC2 Classic, platforms available in us-east-2: ["VPC"]
=== CONT  TestAccAWSInstance_rootInstanceStore
--- PASS: TestAccAWSInstance_RootBlockDevice_KmsKeyArn (114.67s)
=== CONT  TestAccAWSInstance_blockDevices
--- SKIP: TestAccAWSInstance_rootInstanceStore (2.03s)
    resource_aws_instance_test.go:4443: skipping tests; us-east-2 does not offer EC2 instance type: m3.medium
=== CONT  TestAccAWSInstance_GP2WithIopsValue
--- SKIP: TestAccAWSInstance_blockDevices (1.93s)
    resource_aws_instance_test.go:4443: skipping tests; us-east-2 does not offer EC2 instance type: m3.medium
=== CONT  TestAccAWSInstance_GP2IopsDevice
--- SKIP: TestAccAWSInstance_GP2WithIopsValue (1.91s)
    resource_aws_instance_test.go:4443: skipping tests; us-east-2 does not offer EC2 instance type: m3.medium
=== CONT  TestAccAWSInstance_inDefaultVpcBySgId
--- SKIP: TestAccAWSInstance_GP2IopsDevice (1.94s)
    resource_aws_instance_test.go:4443: skipping tests; us-east-2 does not offer EC2 instance type: m3.medium
--- PASS: TestAccAWSInstance_inDefaultVpcBySgId (88.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2204.761s

@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Dec 5, 2019
@ewbankkit ewbankkit force-pushed the issue-4987 branch 4 times, most recently from 63274e8 to da60009 Compare December 12, 2019 19:14
@ewbankkit
Copy link
Contributor Author

ewbankkit commented Dec 12, 2019

The acceptance test failures for the aws_instance resource in us-east-1 are because that account has EC2-Classic available and source_dest_check has a default value of true in the resource's schema but isn't set on Read when the instance is not on a subnet (i.e. in EC2-Classic).

I'm removing WIP - this PR is now ready for review.

The gist of the changes is:

  • Pass instance_type as a parameter to each test case's configuration generation function (plus a random instance name) and check that the current test region (as configured via AWS_DEFAULT_REGION) supports that instance type by using the new EC2 DescribeInstanceTypeOfferings API and a PreCheckfunction. No instance types were changed
  • Add PreChecks that the test region either has a default VPC or supports EC2-Classic in the (many) test cases that no subnet_id is specified for the instance
  • Changed the image_ids to use the preferred amzn-ami-minimal-hvm-instance-store AMI (region-agnostic) except when an AMI with a very specific device configuration is required
  • In the one case where a very specific AMI is required and is only available in us-west-2, add a PreCheck for that region

I don't have access to a GovCloud or CN partition account so couldn't test the partition-agnosticness.

@ewbankkit ewbankkit changed the title [WIP] Region/partition-agnostic aws_instance acceptance tests Region/partition-agnostic aws_instance acceptance tests Dec 12, 2019
@ewbankkit
Copy link
Contributor Author

Rebased to remove merge conflict and re-ran affected acceptance test:

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSInstance_instanceProfileChange'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSInstance_instanceProfileChange -timeout 120m
=== RUN   TestAccAWSInstance_instanceProfileChange
=== PAUSE TestAccAWSInstance_instanceProfileChange
=== CONT  TestAccAWSInstance_instanceProfileChange
--- PASS: TestAccAWSInstance_instanceProfileChange (286.57s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	287.871s

@ewbankkit
Copy link
Contributor Author

See also #12277.

@ewbankkit ewbankkit changed the title Region/partition-agnostic aws_instance acceptance tests [WIP] Region/partition-agnostic aws_instance acceptance tests Apr 29, 2020
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Jul 1, 2020
@YakDriver
Copy link
Member

@ewbankkit 👋 Kit, this is a tremendous effort! Thank you. This fixes issues that we are currently working to fix and so we'd like to move this along. However, due to its size, this PR creates conflicts and is difficult to review. Would you be willing to break it into several incremental steps? I'm not sure of the exact best way to break it up but figured you'd know better than anyone.

@ewbankkit
Copy link
Contributor Author

@YakDriver Yes, this one has become a bit stale over the months and is probably not worth keeping in its current form.
Since I started on this the aws_ec2_instance_type_offering data source has been introduced and the testAccAvailableEc2InstanceTypeForRegion() function can be used instead of hard-coding and checking for the instance types. I'd also make the tests independent of the default VPC wherever possible (#13260).
As a preliminary, could you look at #13361 and #13091 as these provide some useful shared methods for tackling this problem?
I'd also have separate PRs for each data source and resource.
Let's leave this one open until I have submitted at least WIP replacement PRs.

@YakDriver
Copy link
Member

@ewbankkit Sorry to leave this languishing. Where do you want to take this PR at this point? The flurry of region/partition activity has calmed down so may be a good time to see what's what here.

@ewbankkit
Copy link
Contributor Author

I'll do a review but I think that the material changes have all been made via the PRs you mention.
If that's the case I'll just close this one.

@ewbankkit
Copy link
Contributor Author

OK, I'm going to close this one. The only changes that haven't been covered by other PRs are ones that check for default VPC with default subnets (using testAccPreCheckEc2ClassicOrHasDefaultVpcWithDefaultSubnets) that should be addressed for #13260.

@ewbankkit ewbankkit closed this Nov 10, 2020
@ewbankkit ewbankkit deleted the issue-4987 branch November 10, 2020 22:57
@ghost
Copy link

ghost commented Dec 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup Region/Partition Agnostic aws_instance Acceptance Testing
3 participants