Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_iam_group_policy_attachments: New Data Source #27902

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vicyap
Copy link
Contributor

@vicyap vicyap commented Nov 19, 2022

Description

Adds aws_iam_group_policy_attachments new data source.

Relations

References

https://awscli.amazonaws.com/v2/documentation/api/latest/reference/iam/list-attached-group-policies.html

Output from Acceptance Testing

$ make testacc TESTS=TestAccIAMGroupPolicyAttachmentsDataSource PKG=iam
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMGroupPolicyAttachmentsDataSource'  -timeout 180m
=== RUN   TestAccIAMGroupPolicyAttachmentsDataSource_basic
=== PAUSE TestAccIAMGroupPolicyAttachmentsDataSource_basic
=== RUN   TestAccIAMGroupPolicyAttachmentsDataSource_multiple
=== PAUSE TestAccIAMGroupPolicyAttachmentsDataSource_multiple
=== RUN   TestAccIAMGroupPolicyAttachmentsDataSource_withPathPrefixMatching
=== PAUSE TestAccIAMGroupPolicyAttachmentsDataSource_withPathPrefixMatching
=== RUN   TestAccIAMGroupPolicyAttachmentsDataSource_withPathPrefixNotMatching
=== PAUSE TestAccIAMGroupPolicyAttachmentsDataSource_withPathPrefixNotMatching
=== CONT  TestAccIAMGroupPolicyAttachmentsDataSource_basic
=== CONT  TestAccIAMGroupPolicyAttachmentsDataSource_withPathPrefixMatching
=== CONT  TestAccIAMGroupPolicyAttachmentsDataSource_withPathPrefixNotMatching
=== CONT  TestAccIAMGroupPolicyAttachmentsDataSource_multiple
--- PASS: TestAccIAMGroupPolicyAttachmentsDataSource_withPathPrefixMatching (17.93s)
--- PASS: TestAccIAMGroupPolicyAttachmentsDataSource_multiple (17.94s)
--- PASS: TestAccIAMGroupPolicyAttachmentsDataSource_withPathPrefixNotMatching (18.14s)
--- PASS: TestAccIAMGroupPolicyAttachmentsDataSource_basic (18.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	20.557s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/iam Issues and PRs that pertain to the iam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/iam Issues and PRs that pertain to the iam service. provider Pertains to the provider itself, rather than any interaction with AWS. labels Nov 19, 2022
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/iam Issues and PRs that pertain to the iam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 19, 2022
@breathingdust breathingdust added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/iam Issues and PRs that pertain to the iam service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants