Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_nat_gateway: Select private IP address #27953

Merged
merged 6 commits into from
Nov 22, 2022

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Nov 22, 2022

Description

Changes the private_ip address to Optional (and Computed), allowing the private IP address to be configurable.

Relations

Closes #27921.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccVPCNATGateway' PKG=ec2 ACCTEST_PARALLELISM=2 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVPCNATGateway -timeout 180m
=== RUN   TestAccVPCNATGatewayDataSource_basic
=== PAUSE TestAccVPCNATGatewayDataSource_basic
=== RUN   TestAccVPCNATGateway_basic
=== PAUSE TestAccVPCNATGateway_basic
=== RUN   TestAccVPCNATGateway_disappears
=== PAUSE TestAccVPCNATGateway_disappears
=== RUN   TestAccVPCNATGateway_ConnectivityType_private
=== PAUSE TestAccVPCNATGateway_ConnectivityType_private
=== RUN   TestAccVPCNATGateway_privateIP
=== PAUSE TestAccVPCNATGateway_privateIP
=== RUN   TestAccVPCNATGateway_tags
=== PAUSE TestAccVPCNATGateway_tags
=== RUN   TestAccVPCNATGatewaysDataSource_basic
=== PAUSE TestAccVPCNATGatewaysDataSource_basic
=== CONT  TestAccVPCNATGatewayDataSource_basic
=== CONT  TestAccVPCNATGateway_privateIP
--- PASS: TestAccVPCNATGatewayDataSource_basic (201.14s)
=== CONT  TestAccVPCNATGatewaysDataSource_basic
--- PASS: TestAccVPCNATGateway_privateIP (202.72s)
=== CONT  TestAccVPCNATGateway_tags
--- PASS: TestAccVPCNATGatewaysDataSource_basic (210.18s)
=== CONT  TestAccVPCNATGateway_disappears
--- PASS: TestAccVPCNATGateway_tags (220.80s)
=== CONT  TestAccVPCNATGateway_ConnectivityType_private
--- PASS: TestAccVPCNATGateway_disappears (177.75s)
=== CONT  TestAccVPCNATGateway_basic
--- PASS: TestAccVPCNATGateway_ConnectivityType_private (219.49s)
--- PASS: TestAccVPCNATGateway_basic (230.35s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	824.423s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/vpc Issues and PRs that pertain to the vpc service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. labels Nov 22, 2022
@ewbankkit ewbankkit marked this pull request as ready for review November 22, 2022 18:51
@ewbankkit ewbankkit merged commit cdc7d98 into main Nov 22, 2022
@ewbankkit ewbankkit deleted the f-aws_nat_gateway.private_ip-optional branch November 22, 2022 18:54
@github-actions github-actions bot added this to the v4.41.0 milestone Nov 22, 2022
github-actions bot pushed a commit that referenced this pull request Nov 22, 2022
@github-actions
Copy link

This functionality has been released in v4.41.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/vpc Issues and PRs that pertain to the vpc service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_nat_gateway select private IP address
1 participant