Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add subnet attribute: enable_lni_at_device_index #30798

Merged
merged 3 commits into from
Apr 18, 2023
Merged

add subnet attribute: enable_lni_at_device_index #30798

merged 3 commits into from
Apr 18, 2023

Conversation

silvaalbert
Copy link
Contributor

@silvaalbert silvaalbert commented Apr 18, 2023 •
edited by ewbankkit
Loading

Description

Add attribute enable_lni_at_device_index to aws_subnet resource & datasource.

Relations

Closes #30779.
Closes #25631.

References

https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_Subnet.html

Output from Acceptance Testing

Attribute-specific resource test

make testacc TESTS=TestAccVPCSubnet_enableLNIAtDeviceIndex PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCSubnet_enableLNIAtDeviceIndex'  -timeout 180m
=== RUN   TestAccVPCSubnet_enableLNIAtDeviceIndex
=== PAUSE TestAccVPCSubnet_enableLNIAtDeviceIndex
=== CONT  TestAccVPCSubnet_enableLNIAtDeviceIndex
--- PASS: TestAccVPCSubnet_enableLNIAtDeviceIndex (84.05s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        87.338s

Attribute-specific data source test

make testacc TESTS=TestAccVPCSubnetDataSource_enableLniAtDeviceIndex PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCSubnetDataSource_enableLniAtDeviceIndex'  -timeout 180m
=== RUN   TestAccVPCSubnetDataSource_enableLniAtDeviceIndex
=== PAUSE TestAccVPCSubnetDataSource_enableLniAtDeviceIndex
=== CONT  TestAccVPCSubnetDataSource_enableLniAtDeviceIndex
--- PASS: TestAccVPCSubnetDataSource_enableLniAtDeviceIndex (37.49s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        40.609s

All resource tests

make testacc TESTS=TestAccVPCSubnet_ PKG=ec2 ACCTEST_PARALLELISM=5 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 5 -run='TestAccVPCSubnet_'  -timeout 180m
=== RUN   TestAccVPCSubnet_basic
=== PAUSE TestAccVPCSubnet_basic
=== RUN   TestAccVPCSubnet_tags
=== PAUSE TestAccVPCSubnet_tags
=== RUN   TestAccVPCSubnet_DefaultTags_providerOnly
=== PAUSE TestAccVPCSubnet_DefaultTags_providerOnly
=== RUN   TestAccVPCSubnet_DefaultTags_updateToProviderOnly
=== PAUSE TestAccVPCSubnet_DefaultTags_updateToProviderOnly
=== RUN   TestAccVPCSubnet_DefaultTags_updateToResourceOnly
=== PAUSE TestAccVPCSubnet_DefaultTags_updateToResourceOnly
=== RUN   TestAccVPCSubnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== PAUSE TestAccVPCSubnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== RUN   TestAccVPCSubnet_DefaultTagsProviderAndResource_overlappingTag
=== PAUSE TestAccVPCSubnet_DefaultTagsProviderAndResource_overlappingTag
=== RUN   TestAccVPCSubnet_DefaultTagsProviderAndResource_duplicateTag
=== PAUSE TestAccVPCSubnet_DefaultTagsProviderAndResource_duplicateTag
=== RUN   TestAccVPCSubnet_defaultAndIgnoreTags
=== PAUSE TestAccVPCSubnet_defaultAndIgnoreTags
=== RUN   TestAccVPCSubnet_updateTagsKnownAtApply
=== PAUSE TestAccVPCSubnet_updateTagsKnownAtApply
=== RUN   TestAccVPCSubnet_ignoreTags
=== PAUSE TestAccVPCSubnet_ignoreTags
=== RUN   TestAccVPCSubnet_ipv6
=== PAUSE TestAccVPCSubnet_ipv6
=== RUN   TestAccVPCSubnet_enableIPv6
=== PAUSE TestAccVPCSubnet_enableIPv6
=== RUN   TestAccVPCSubnet_availabilityZoneID
=== PAUSE TestAccVPCSubnet_availabilityZoneID
=== RUN   TestAccVPCSubnet_disappears
=== PAUSE TestAccVPCSubnet_disappears
=== RUN   TestAccVPCSubnet_customerOwnedIPv4Pool
=== PAUSE TestAccVPCSubnet_customerOwnedIPv4Pool
=== RUN   TestAccVPCSubnet_mapCustomerOwnedIPOnLaunch
=== PAUSE TestAccVPCSubnet_mapCustomerOwnedIPOnLaunch
=== RUN   TestAccVPCSubnet_mapPublicIPOnLaunch
=== PAUSE TestAccVPCSubnet_mapPublicIPOnLaunch
=== RUN   TestAccVPCSubnet_outpost
=== PAUSE TestAccVPCSubnet_outpost
=== RUN   TestAccVPCSubnet_enableDNS64
=== PAUSE TestAccVPCSubnet_enableDNS64
=== RUN   TestAccVPCSubnet_enableLNIAtDeviceIndex
=== PAUSE TestAccVPCSubnet_enableLNIAtDeviceIndex
=== RUN   TestAccVPCSubnet_privateDNSNameOptionsOnLaunch
=== PAUSE TestAccVPCSubnet_privateDNSNameOptionsOnLaunch
=== RUN   TestAccVPCSubnet_ipv6Native
=== PAUSE TestAccVPCSubnet_ipv6Native
=== CONT  TestAccVPCSubnet_basic
=== CONT  TestAccVPCSubnet_enableIPv6
=== CONT  TestAccVPCSubnet_outpost
=== CONT  TestAccVPCSubnet_customerOwnedIPv4Pool
=== CONT  TestAccVPCSubnet_privateDNSNameOptionsOnLaunch
=== NAME  TestAccVPCSubnet_customerOwnedIPv4Pool
    acctest.go:1047: skipping since no Outposts found
--- SKIP: TestAccVPCSubnet_customerOwnedIPv4Pool (0.83s)
=== CONT  TestAccVPCSubnet_enableLNIAtDeviceIndex
=== NAME  TestAccVPCSubnet_outpost
    acctest.go:1047: skipping since no Outposts found
--- SKIP: TestAccVPCSubnet_outpost (0.86s)
=== CONT  TestAccVPCSubnet_mapPublicIPOnLaunch
=== NAME  TestAccVPCSubnet_enableLNIAtDeviceIndex
    acctest.go:1047: skipping since no Outposts found
--- SKIP: TestAccVPCSubnet_enableLNIAtDeviceIndex (0.11s)
=== CONT  TestAccVPCSubnet_mapCustomerOwnedIPOnLaunch
    acctest.go:1047: skipping since no Outposts found
--- SKIP: TestAccVPCSubnet_mapCustomerOwnedIPOnLaunch (0.15s)
=== CONT  TestAccVPCSubnet_DefaultTagsProviderAndResource_overlappingTag
--- PASS: TestAccVPCSubnet_basic (12.93s)
=== CONT  TestAccVPCSubnet_ipv6
--- PASS: TestAccVPCSubnet_DefaultTagsProviderAndResource_overlappingTag (25.58s)
=== CONT  TestAccVPCSubnet_ignoreTags
--- PASS: TestAccVPCSubnet_ignoreTags (19.14s)
=== CONT  TestAccVPCSubnet_updateTagsKnownAtApply
--- PASS: TestAccVPCSubnet_mapPublicIPOnLaunch (56.50s)
=== CONT  TestAccVPCSubnet_defaultAndIgnoreTags
--- PASS: TestAccVPCSubnet_enableIPv6 (58.62s)
=== CONT  TestAccVPCSubnet_DefaultTagsProviderAndResource_duplicateTag
--- PASS: TestAccVPCSubnet_DefaultTagsProviderAndResource_duplicateTag (1.11s)
=== CONT  TestAccVPCSubnet_enableDNS64
--- PASS: TestAccVPCSubnet_updateTagsKnownAtApply (21.79s)
=== CONT  TestAccVPCSubnet_disappears
--- PASS: TestAccVPCSubnet_ipv6 (57.35s)
=== CONT  TestAccVPCSubnet_availabilityZoneID
--- PASS: TestAccVPCSubnet_disappears (10.17s)
=== CONT  TestAccVPCSubnet_DefaultTags_updateToProviderOnly
--- PASS: TestAccVPCSubnet_defaultAndIgnoreTags (21.03s)
=== CONT  TestAccVPCSubnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== CONT  TestAccVPCSubnet_DefaultTags_updateToResourceOnly
--- PASS: TestAccVPCSubnet_availabilityZoneID (12.15s)
=== NAME  TestAccVPCSubnet_DefaultTags_updateToResourceOnly
    vpc_subnet_test.go:215: Step 2/3 error: After applying this test step, the plan was not empty.
        stdout:


        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place

        Terraform will perform the following actions:

          # aws_vpc.test will be updated in-place
          ~ resource "aws_vpc" "test" {
                id                                   = "vpc-0716bbcd186e783d0"
              ~ tags                                 = {
                    "Name" = "tf-acc-test-139608398850753941"
                  - "key1" = "value1" -> null
                }
              ~ tags_all                             = {
                  - "key1" = "value1" -> null
                    # (1 unchanged element hidden)
                }
                # (16 unchanged attributes hidden)
            }

        Plan: 0 to add, 1 to change, 0 to destroy.
--- PASS: TestAccVPCSubnet_DefaultTags_updateToProviderOnly (19.00s)
=== CONT  TestAccVPCSubnet_DefaultTags_providerOnly
--- FAIL: TestAccVPCSubnet_DefaultTags_updateToResourceOnly (15.54s)
=== CONT  TestAccVPCSubnet_tags
--- PASS: TestAccVPCSubnet_DefaultTagsProviderAndResource_nonOverlappingTag (25.68s)
=== CONT  TestAccVPCSubnet_ipv6Native
--- PASS: TestAccVPCSubnet_DefaultTags_providerOnly (25.84s)
--- PASS: TestAccVPCSubnet_tags (24.69s)
--- PASS: TestAccVPCSubnet_ipv6Native (21.68s)
--- PASS: TestAccVPCSubnet_privateDNSNameOptionsOnLaunch (130.60s)
--- PASS: TestAccVPCSubnet_enableDNS64 (76.27s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	139.199s
FAIL
make: *** [testacc] Error 1

All data source tests

make testacc TESTS=TestAccVPCSubnetDataSource_ PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCSubnetDataSource_'  -timeout 180m
=== RUN   TestAccVPCSubnetDataSource_basic
=== PAUSE TestAccVPCSubnetDataSource_basic
=== RUN   TestAccVPCSubnetDataSource_ipv6ByIPv6Filter
=== PAUSE TestAccVPCSubnetDataSource_ipv6ByIPv6Filter
=== RUN   TestAccVPCSubnetDataSource_ipv6ByIPv6CIDRBlock
=== PAUSE TestAccVPCSubnetDataSource_ipv6ByIPv6CIDRBlock
=== RUN   TestAccVPCSubnetDataSource_enableLniAtDeviceIndex
=== PAUSE TestAccVPCSubnetDataSource_enableLniAtDeviceIndex
=== CONT  TestAccVPCSubnetDataSource_basic
=== CONT  TestAccVPCSubnetDataSource_ipv6ByIPv6CIDRBlock
=== CONT  TestAccVPCSubnetDataSource_ipv6ByIPv6Filter
=== CONT  TestAccVPCSubnetDataSource_enableLniAtDeviceIndex
    acctest.go:1047: skipping since no Outposts found
--- SKIP: TestAccVPCSubnetDataSource_enableLniAtDeviceIndex (0.83s)
--- PASS: TestAccVPCSubnetDataSource_basic (11.42s)
--- PASS: TestAccVPCSubnetDataSource_ipv6ByIPv6CIDRBlock (27.23s)
--- PASS: TestAccVPCSubnetDataSource_ipv6ByIPv6Filter (28.18s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	31.250s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/vpc Issues and PRs that pertain to the vpc service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Apr 18, 2023
@silvaalbert silvaalbert marked this pull request as ready for review April 18, 2023 17:53
@ewbankkit ewbankkit added partner Contribution from a partner. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 18, 2023
@ewbankkit ewbankkit self-assigned this Apr 18, 2023
ewbankkit
ewbankkit approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVPCSubnet_' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccVPCSubnet_ -timeout 180m
=== RUN   TestAccVPCSubnet_basic
=== PAUSE TestAccVPCSubnet_basic
=== RUN   TestAccVPCSubnet_tags
=== PAUSE TestAccVPCSubnet_tags
=== RUN   TestAccVPCSubnet_DefaultTags_providerOnly
=== PAUSE TestAccVPCSubnet_DefaultTags_providerOnly
=== RUN   TestAccVPCSubnet_DefaultTags_updateToProviderOnly
=== PAUSE TestAccVPCSubnet_DefaultTags_updateToProviderOnly
=== RUN   TestAccVPCSubnet_DefaultTags_updateToResourceOnly
=== PAUSE TestAccVPCSubnet_DefaultTags_updateToResourceOnly
=== RUN   TestAccVPCSubnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== PAUSE TestAccVPCSubnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== RUN   TestAccVPCSubnet_DefaultTagsProviderAndResource_overlappingTag
=== PAUSE TestAccVPCSubnet_DefaultTagsProviderAndResource_overlappingTag
=== RUN   TestAccVPCSubnet_DefaultTagsProviderAndResource_duplicateTag
=== PAUSE TestAccVPCSubnet_DefaultTagsProviderAndResource_duplicateTag
=== RUN   TestAccVPCSubnet_defaultAndIgnoreTags
=== PAUSE TestAccVPCSubnet_defaultAndIgnoreTags
=== RUN   TestAccVPCSubnet_updateTagsKnownAtApply
=== PAUSE TestAccVPCSubnet_updateTagsKnownAtApply
=== RUN   TestAccVPCSubnet_ignoreTags
=== PAUSE TestAccVPCSubnet_ignoreTags
=== RUN   TestAccVPCSubnet_ipv6
=== PAUSE TestAccVPCSubnet_ipv6
=== RUN   TestAccVPCSubnet_enableIPv6
=== PAUSE TestAccVPCSubnet_enableIPv6
=== RUN   TestAccVPCSubnet_availabilityZoneID
=== PAUSE TestAccVPCSubnet_availabilityZoneID
=== RUN   TestAccVPCSubnet_disappears
=== PAUSE TestAccVPCSubnet_disappears
=== RUN   TestAccVPCSubnet_customerOwnedIPv4Pool
=== PAUSE TestAccVPCSubnet_customerOwnedIPv4Pool
=== RUN   TestAccVPCSubnet_mapCustomerOwnedIPOnLaunch
=== PAUSE TestAccVPCSubnet_mapCustomerOwnedIPOnLaunch
=== RUN   TestAccVPCSubnet_mapPublicIPOnLaunch
=== PAUSE TestAccVPCSubnet_mapPublicIPOnLaunch
=== RUN   TestAccVPCSubnet_outpost
=== PAUSE TestAccVPCSubnet_outpost
=== RUN   TestAccVPCSubnet_enableDNS64
=== PAUSE TestAccVPCSubnet_enableDNS64
=== RUN   TestAccVPCSubnet_enableLNIAtDeviceIndex
=== PAUSE TestAccVPCSubnet_enableLNIAtDeviceIndex
=== RUN   TestAccVPCSubnet_privateDNSNameOptionsOnLaunch
=== PAUSE TestAccVPCSubnet_privateDNSNameOptionsOnLaunch
=== RUN   TestAccVPCSubnet_ipv6Native
=== PAUSE TestAccVPCSubnet_ipv6Native
=== CONT  TestAccVPCSubnet_basic
=== CONT  TestAccVPCSubnet_enableIPv6
=== CONT  TestAccVPCSubnet_DefaultTagsProviderAndResource_overlappingTag
--- PASS: TestAccVPCSubnet_basic (22.54s)
=== CONT  TestAccVPCSubnet_updateTagsKnownAtApply
--- PASS: TestAccVPCSubnet_DefaultTagsProviderAndResource_overlappingTag (46.00s)
=== CONT  TestAccVPCSubnet_ipv6
--- PASS: TestAccVPCSubnet_updateTagsKnownAtApply (42.93s)
=== CONT  TestAccVPCSubnet_ignoreTags
--- PASS: TestAccVPCSubnet_enableIPv6 (82.45s)
=== CONT  TestAccVPCSubnet_defaultAndIgnoreTags
--- PASS: TestAccVPCSubnet_ignoreTags (37.46s)
=== CONT  TestAccVPCSubnet_DefaultTags_updateToProviderOnly
--- PASS: TestAccVPCSubnet_defaultAndIgnoreTags (37.87s)
=== CONT  TestAccVPCSubnet_DefaultTagsProviderAndResource_nonOverlappingTag
--- PASS: TestAccVPCSubnet_ipv6 (81.83s)
=== CONT  TestAccVPCSubnet_DefaultTags_updateToResourceOnly
--- PASS: TestAccVPCSubnet_DefaultTags_updateToProviderOnly (35.93s)
=== CONT  TestAccVPCSubnet_DefaultTagsProviderAndResource_duplicateTag
--- PASS: TestAccVPCSubnet_DefaultTagsProviderAndResource_duplicateTag (2.23s)
=== CONT  TestAccVPCSubnet_DefaultTags_providerOnly
--- PASS: TestAccVPCSubnet_DefaultTags_updateToResourceOnly (35.46s)
=== CONT  TestAccVPCSubnet_outpost
    acctest.go:1047: skipping since no Outposts found
--- SKIP: TestAccVPCSubnet_outpost (0.83s)
=== CONT  TestAccVPCSubnet_ipv6Native
--- PASS: TestAccVPCSubnet_DefaultTagsProviderAndResource_nonOverlappingTag (45.35s)
=== CONT  TestAccVPCSubnet_privateDNSNameOptionsOnLaunch
--- PASS: TestAccVPCSubnet_DefaultTags_providerOnly (44.35s)
=== CONT  TestAccVPCSubnet_enableLNIAtDeviceIndex
    acctest.go:1047: skipping since no Outposts found
--- SKIP: TestAccVPCSubnet_enableLNIAtDeviceIndex (0.17s)
=== CONT  TestAccVPCSubnet_enableDNS64
--- PASS: TestAccVPCSubnet_ipv6Native (31.46s)
=== CONT  TestAccVPCSubnet_customerOwnedIPv4Pool
    acctest.go:1047: skipping since no Outposts found
--- SKIP: TestAccVPCSubnet_customerOwnedIPv4Pool (0.18s)
=== CONT  TestAccVPCSubnet_mapPublicIPOnLaunch
--- PASS: TestAccVPCSubnet_mapPublicIPOnLaunch (79.38s)
=== CONT  TestAccVPCSubnet_mapCustomerOwnedIPOnLaunch
    acctest.go:1047: skipping since no Outposts found
--- SKIP: TestAccVPCSubnet_mapCustomerOwnedIPOnLaunch (0.18s)
=== CONT  TestAccVPCSubnet_tags
--- PASS: TestAccVPCSubnet_enableDNS64 (100.45s)
=== CONT  TestAccVPCSubnet_disappears
--- PASS: TestAccVPCSubnet_disappears (18.30s)
=== CONT  TestAccVPCSubnet_availabilityZoneID
--- PASS: TestAccVPCSubnet_privateDNSNameOptionsOnLaunch (152.68s)
--- PASS: TestAccVPCSubnet_tags (49.66s)
--- PASS: TestAccVPCSubnet_availabilityZoneID (22.65s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	332.583s
% AWS_DEFAULT_REGION=eu-west-1 make testacc TESTARGS='-run=TestAccVPCDefaultVPCAndSubnet_serial/Subnet' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPCDefaultVPCAndSubnet_serial/Subnet -timeout 180m
=== RUN   TestAccVPCDefaultVPCAndSubnet_serial
=== PAUSE TestAccVPCDefaultVPCAndSubnet_serial
=== CONT  TestAccVPCDefaultVPCAndSubnet_serial
=== RUN   TestAccVPCDefaultVPCAndSubnet_serial/Subnet
=== RUN   TestAccVPCDefaultVPCAndSubnet_serial/Subnet/existing.forceDestroy
=== RUN   TestAccVPCDefaultVPCAndSubnet_serial/Subnet/existing.ipv6
=== RUN   TestAccVPCDefaultVPCAndSubnet_serial/Subnet/existing.privateDnsNameOptionsOnLaunch
=== RUN   TestAccVPCDefaultVPCAndSubnet_serial/Subnet/notFound.basic
    vpc_default_subnet_test.go:63: Deleting existing default subnet: subnet-0d02adf1c339ae7e8
    vpc_default_subnet_test.go:63: Deleting existing default subnet: subnet-0e74b86a0fe7845dd
    vpc_default_subnet_test.go:63: Deleting existing default subnet: subnet-008eabfc8b4688ea2
=== RUN   TestAccVPCDefaultVPCAndSubnet_serial/Subnet/notFound.ipv6Native
    vpc_default_subnet_test.go:63: Deleting existing default subnet: subnet-09aaf7ec3f74540f9
    vpc_default_subnet_test.go:63: Deleting existing default subnet: subnet-0251590dc4cc8ef16
    vpc_default_subnet_test.go:63: Deleting existing default subnet: subnet-07aca9d87c4a45340
=== RUN   TestAccVPCDefaultVPCAndSubnet_serial/Subnet/existing.basic
--- PASS: TestAccVPCDefaultVPCAndSubnet_serial (175.79s)
    --- PASS: TestAccVPCDefaultVPCAndSubnet_serial/Subnet (175.79s)
        --- PASS: TestAccVPCDefaultVPCAndSubnet_serial/Subnet/existing.forceDestroy (22.28s)
        --- PASS: TestAccVPCDefaultVPCAndSubnet_serial/Subnet/existing.ipv6 (47.98s)
        --- PASS: TestAccVPCDefaultVPCAndSubnet_serial/Subnet/existing.privateDnsNameOptionsOnLaunch (39.47s)
        --- PASS: TestAccVPCDefaultVPCAndSubnet_serial/Subnet/notFound.basic (21.39s)
        --- PASS: TestAccVPCDefaultVPCAndSubnet_serial/Subnet/notFound.ipv6Native (25.77s)
        --- PASS: TestAccVPCDefaultVPCAndSubnet_serial/Subnet/existing.basic (18.90s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	181.007s

@ewbankkit
Copy link
Contributor

@silvaalbert Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit a0450ad into hashicorp:main Apr 18, 2023
@github-actions github-actions bot added this to the v4.64.0 milestone Apr 18, 2023
@github-actions
Copy link

This functionality has been released in v4.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@ewbankkit ewbankkit mentioned this pull request Apr 24, 2023
Open
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. service/vpc Issues and PRs that pertain to the vpc service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.64.0
3 participants
@silvaalbert @ewbankkit @albsilv-aws