Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add association_config attribute to aws_wafv2_web_acl resource #32367

Conversation

sergiocharpineljr
Copy link
Contributor

@sergiocharpineljr sergiocharpineljr commented Jul 4, 2023

Description

Add AssociationConfig attribute to the aws_wafv2_web_acl resource.

Relations

Closes #32141

References

Output from Acceptance Testing

$ AWS_DEFAULT_REGION=us-east-1 make testacc PKG=wafv2 TESTS=TestAccWAFV2WebACL_AssociationConfig
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/wafv2/... -v -count 1 -parallel 20 -run='TestAccWAFV2WebACL_AssociationConfig'  -timeout 180m
=== RUN   TestAccWAFV2WebACL_AssociationConfig
=== PAUSE TestAccWAFV2WebACL_AssociationConfig
=== RUN   TestAccWAFV2WebACL_AssociationConfig_Update
=== PAUSE TestAccWAFV2WebACL_AssociationConfig_Update
=== CONT  TestAccWAFV2WebACL_AssociationConfig
=== CONT  TestAccWAFV2WebACL_AssociationConfig_Update
--- PASS: TestAccWAFV2WebACL_AssociationConfig (40.50s)
--- PASS: TestAccWAFV2WebACL_AssociationConfig_Update (67.12s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/wafv2	67.203s

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/wafv2 Issues and PRs that pertain to the wafv2 service. size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/wafv2 Issues and PRs that pertain to the wafv2 service. labels Jul 4, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @sergiocharpineljr 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/wafv2 Issues and PRs that pertain to the wafv2 service. labels Jul 4, 2023
@sergiocharpineljr sergiocharpineljr marked this pull request as ready for review July 4, 2023 17:19
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 6, 2023
@ewbankkit
Copy link
Contributor

@sergiocharpineljr Thanks for the contribution 🎉 👏.
This functionality has been implemented via #31668.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2023
@sergiocharpineljr sergiocharpineljr deleted the f-aws_wafv2_web_acl-association_config branch January 15, 2024 18:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/wafv2 Issues and PRs that pertain to the wafv2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_wafv2_web_acl should allow changing the maximum request body inspection.
3 participants