Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identitystore: Restore filter argument for Group and User data sources #33311

Merged
merged 7 commits into from
Sep 5, 2023

Conversation

ewbankkit
Copy link
Contributor

Description

Restores the filter argument to the aws_identitystore_group and aws_identitystore_user data sources as certain AWS Regions are returning UnknownOperationException errors for the GetGroupId and GetUserId APIs.

Relations

Closes #31624.
Relates #31312.
Relates #28937.
Relates #27762.
Relates #27053.

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccIdentityStoreGroupDataSource_' PKG=identitystore ACCTEST_PARALLELISM=2 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/identitystore/... -v -count 1 -parallel 2  -run=TestAccIdentityStoreGroupDataSource_ -timeout 180m
=== RUN   TestAccIdentityStoreGroupDataSource_filterDisplayName
=== PAUSE TestAccIdentityStoreGroupDataSource_filterDisplayName
=== RUN   TestAccIdentityStoreGroupDataSource_uniqueAttributeDisplayName
=== PAUSE TestAccIdentityStoreGroupDataSource_uniqueAttributeDisplayName
=== RUN   TestAccIdentityStoreGroupDataSource_filterDisplayNameAndGroupID
=== PAUSE TestAccIdentityStoreGroupDataSource_filterDisplayNameAndGroupID
=== CONT  TestAccIdentityStoreGroupDataSource_filterDisplayName
=== CONT  TestAccIdentityStoreGroupDataSource_filterDisplayNameAndGroupID
--- PASS: TestAccIdentityStoreGroupDataSource_filterDisplayNameAndGroupID (44.22s)
=== CONT  TestAccIdentityStoreGroupDataSource_uniqueAttributeDisplayName
--- PASS: TestAccIdentityStoreGroupDataSource_filterDisplayName (44.26s)
--- PASS: TestAccIdentityStoreGroupDataSource_uniqueAttributeDisplayName (37.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/identitystore	87.769s
% make testacc TESTARGS='-run=TestAccIdentityStoreUserDataSource_' PKG=identitystore ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/identitystore/... -v -count 1 -parallel 2  -run=TestAccIdentityStoreUserDataSource_ -timeout 180m
=== RUN   TestAccIdentityStoreUserDataSource_basic
=== PAUSE TestAccIdentityStoreUserDataSource_basic
=== RUN   TestAccIdentityStoreUserDataSource_filterUserName
=== PAUSE TestAccIdentityStoreUserDataSource_filterUserName
=== RUN   TestAccIdentityStoreUserDataSource_uniqueAttributeUserName
=== PAUSE TestAccIdentityStoreUserDataSource_uniqueAttributeUserName
=== RUN   TestAccIdentityStoreUserDataSource_email
=== PAUSE TestAccIdentityStoreUserDataSource_email
=== RUN   TestAccIdentityStoreUserDataSource_userID
=== PAUSE TestAccIdentityStoreUserDataSource_userID
=== CONT  TestAccIdentityStoreUserDataSource_basic
=== CONT  TestAccIdentityStoreUserDataSource_email
--- PASS: TestAccIdentityStoreUserDataSource_basic (42.84s)
=== CONT  TestAccIdentityStoreUserDataSource_userID
--- PASS: TestAccIdentityStoreUserDataSource_email (42.86s)
=== CONT  TestAccIdentityStoreUserDataSource_uniqueAttributeUserName
--- PASS: TestAccIdentityStoreUserDataSource_userID (42.01s)
=== CONT  TestAccIdentityStoreUserDataSource_filterUserName
--- PASS: TestAccIdentityStoreUserDataSource_uniqueAttributeUserName (42.09s)
--- PASS: TestAccIdentityStoreUserDataSource_filterUserName (38.02s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/identitystore	128.981s

…ownOperationException` errors in certain Regions.
% make testacc TESTARGS='-run=TestAccIdentityStoreGroupDataSource_' PKG=identitystore ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/identitystore/... -v -count 1 -parallel 2  -run=TestAccIdentityStoreGroupDataSource_ -timeout 180m
=== RUN   TestAccIdentityStoreGroupDataSource_filterDisplayName
=== PAUSE TestAccIdentityStoreGroupDataSource_filterDisplayName
=== RUN   TestAccIdentityStoreGroupDataSource_uniqueAttributeDisplayName
=== PAUSE TestAccIdentityStoreGroupDataSource_uniqueAttributeDisplayName
=== RUN   TestAccIdentityStoreGroupDataSource_filterDisplayNameAndGroupID
=== PAUSE TestAccIdentityStoreGroupDataSource_filterDisplayNameAndGroupID
=== CONT  TestAccIdentityStoreGroupDataSource_filterDisplayName
=== CONT  TestAccIdentityStoreGroupDataSource_filterDisplayNameAndGroupID
--- PASS: TestAccIdentityStoreGroupDataSource_filterDisplayNameAndGroupID (44.22s)
=== CONT  TestAccIdentityStoreGroupDataSource_uniqueAttributeDisplayName
--- PASS: TestAccIdentityStoreGroupDataSource_filterDisplayName (44.26s)
--- PASS: TestAccIdentityStoreGroupDataSource_uniqueAttributeDisplayName (37.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/identitystore	87.769s
…wnOperationException` errors in certain Regions.
% make testacc TESTARGS='-run=TestAccIdentityStoreUserDataSource_' PKG=identitystore ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/identitystore/... -v -count 1 -parallel 2  -run=TestAccIdentityStoreUserDataSource_ -timeout 180m
=== RUN   TestAccIdentityStoreUserDataSource_basic
=== PAUSE TestAccIdentityStoreUserDataSource_basic
=== RUN   TestAccIdentityStoreUserDataSource_filterUserName
=== PAUSE TestAccIdentityStoreUserDataSource_filterUserName
=== RUN   TestAccIdentityStoreUserDataSource_uniqueAttributeUserName
=== PAUSE TestAccIdentityStoreUserDataSource_uniqueAttributeUserName
=== RUN   TestAccIdentityStoreUserDataSource_email
=== PAUSE TestAccIdentityStoreUserDataSource_email
=== RUN   TestAccIdentityStoreUserDataSource_userID
=== PAUSE TestAccIdentityStoreUserDataSource_userID
=== CONT  TestAccIdentityStoreUserDataSource_basic
=== CONT  TestAccIdentityStoreUserDataSource_email
--- PASS: TestAccIdentityStoreUserDataSource_basic (42.84s)
=== CONT  TestAccIdentityStoreUserDataSource_userID
--- PASS: TestAccIdentityStoreUserDataSource_email (42.86s)
=== CONT  TestAccIdentityStoreUserDataSource_uniqueAttributeUserName
--- PASS: TestAccIdentityStoreUserDataSource_userID (42.01s)
=== CONT  TestAccIdentityStoreUserDataSource_filterUserName
--- PASS: TestAccIdentityStoreUserDataSource_uniqueAttributeUserName (42.09s)
--- PASS: TestAccIdentityStoreUserDataSource_filterUserName (38.02s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/identitystore	128.981s
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Sep 5, 2023
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/identitystore Issues and PRs that pertain to the identitystore service. labels Sep 5, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 5, 2023
@ewbankkit ewbankkit merged commit 8a09c3a into main Sep 5, 2023
41 checks passed
@ewbankkit ewbankkit deleted the f-identitystore-restore-filter branch September 5, 2023 19:03
@github-actions github-actions bot added this to the v5.16.0 milestone Sep 5, 2023
github-actions bot pushed a commit that referenced this pull request Sep 5, 2023
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

This functionality has been released in v5.16.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 8, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2023
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/identitystore Issues and PRs that pertain to the identitystore service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants