-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aws_rds_cluster copy_tags_to_snapshot #34102
Fix aws_rds_cluster copy_tags_to_snapshot #34102
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @marcie001 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
477bfc0
to
9bb9e74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccRDSCluster_copyTagsToSnapshot' PKG=rds ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/rds/... -v -count 1 -parallel 3 -run=TestAccRDSCluster_copyTagsToSnapshot -timeout 360m
=== RUN TestAccRDSCluster_copyTagsToSnapshot
=== PAUSE TestAccRDSCluster_copyTagsToSnapshot
=== RUN TestAccRDSCluster_copyTagsToSnapshot_restorePointInTime
=== PAUSE TestAccRDSCluster_copyTagsToSnapshot_restorePointInTime
=== CONT TestAccRDSCluster_copyTagsToSnapshot
=== CONT TestAccRDSCluster_copyTagsToSnapshot_restorePointInTime
--- PASS: TestAccRDSCluster_copyTagsToSnapshot (207.15s)
--- PASS: TestAccRDSCluster_copyTagsToSnapshot_restorePointInTime (438.51s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/rds 443.456s
@marcie001 Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Fix so that copy_tags_to_snapshot is reflected when the restore_to_point_in_time block is specified.
Relations
Closes #34044
References
Output from Acceptance Testing